Download video to sync to local cache #113

Open
pseudoscalar wants to merge 7 commits from pseudoscalar/issue/112/v1 into local
Showing only changes of commit 8ea15afce8 - Show all commits

View file

@ -9,19 +9,27 @@ import (
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"os"
"os/exec"
"path"
"regexp"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"sort"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"strings"
log "github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"github.com/abadojack/whatlanggo"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/lbryio/ytsync/v5/downloader/ytdl"
"github.com/lbryio/ytsync/v5/namer"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/lbryio/ytsync/v5/tags_manager"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/lbryio/lbry.go/v2/extras/jsonrpc"
"github.com/lbryio/lbry.go/v2/extras/util"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
)
type SyncContext struct {
TempDir string
LbrynetAddr string
ChannelID string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
PublishBid float64
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
func (c *SyncContext) Validate() error {
@ -31,6 +39,12 @@ func (c *SyncContext) Validate() error {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if c.LbrynetAddr == "" {
return errors.New("No Lbrynet address provided")
}
if c.ChannelID == "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return errors.New("No channel ID provided")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if c.PublishBid <= 0.0 {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return errors.New("Publish bid is not greater than zero")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil
}
@ -44,7 +58,9 @@ func AddCommand(rootCmd *cobra.Command) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Args: cobra.ExactArgs(1),
}
cmd.Flags().StringVar(&syncContext.TempDir, "temp-dir", getEnvDefault("TEMP_DIR", ""), "directory to use for temporary files")
cmd.Flags().Float64Var(&syncContext.PublishBid, "publish-bid", 0.01, "Bid amount for the stream claim")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
cmd.Flags().StringVar(&syncContext.LbrynetAddr, "lbrynet-address", getEnvDefault("LBRYNET_ADDRESS", ""), "JSONRPC address of the local LBRYNet daemon")
cmd.Flags().StringVar(&syncContext.ChannelID, "channel-id", "", "LBRY channel ID to publish to")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
rootCmd.AddCommand(cmd)
}
@ -75,12 +91,25 @@ func localCmd(cmd *cobra.Command, args []string) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
}
fmt.Println(status.IsRunning)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println(status.Wallet.Connected)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if !status.IsRunning {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Error("SDK is not running")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// Should check to see if the SDK owns the channel
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// Should check to see if wallet is unlocked
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// but jsonrpc.Client doesn't have WalletStatus method
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// so skip for now
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// Should check to see if streams are configured to be reflected and warn if not
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// but jsonrpc.Client doesn't have SettingsGet method to see if streams are reflected
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// so use File.UploadingToReflector as a proxy for now
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoBasePath := path.Join(syncContext.TempDir, videoID)
_, videoMetadataPath, err := getVideoMetadata(videoBasePath, videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoMetadata, videoMetadataPath, err := getVideoMetadata(videoBasePath, videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
log.Errorf("Error getting video metadata: %v", err)
return
@ -89,6 +118,82 @@ func localCmd(cmd *cobra.Command, args []string) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
err = downloadVideo(videoBasePath, videoMetadataPath)
if err != nil {
log.Errorf("Error downloading video: %v", err)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
tags, err := tags_manager.SanitizeTags(videoMetadata.Tags, syncContext.ChannelID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error sanitizing tags: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
urlsRegex := regexp.MustCompile(`(?m) ?(f|ht)(tp)(s?)(://)(.*)[.|/](.*)`)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
descriptionSample := urlsRegex.ReplaceAllString(videoMetadata.Description, "")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
info := whatlanggo.Detect(descriptionSample)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
info2 := whatlanggo.Detect(videoMetadata.Title)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var languages []string = nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if info.IsReliable() && info.Lang.Iso6391() != "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
language := info.Lang.Iso6391()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
languages = []string{language}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
} else if info2.IsReliable() && info2.Lang.Iso6391() != "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
language := info2.Lang.Iso6391()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
languages = []string{language}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// Thumbnail and ReleaseTime need to be properly determined
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
streamCreateOptions := jsonrpc.StreamCreateOptions {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ClaimCreateOptions: jsonrpc.ClaimCreateOptions {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Title: &videoMetadata.Title,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Description: util.PtrToString(getAbbrevDescription(videoMetadata)),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Languages: languages,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
//ThumbnailURL: &v.thumbnailURL,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Tags: tags,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
},
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ReleaseTime: util.PtrToInt64(time.Now().Unix()),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ChannelID: &syncContext.ChannelID,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
License: util.PtrToString("Copyrighted (contact publisher)"),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoPath, err := getVideoDownloadedPath(syncContext.TempDir, videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error determining downloaded video path: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println("%s", *streamCreateOptions.ClaimCreateOptions.Title)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println("%s", *streamCreateOptions.ClaimCreateOptions.Description)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println("%v", streamCreateOptions.ClaimCreateOptions.Languages)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println("%v", streamCreateOptions.ClaimCreateOptions.Tags)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
claimName := namer.NewNamer().GetNextName(videoMetadata.Title)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Infof("Publishing stream as %s", claimName)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
txSummary, err := lbrynet.StreamCreate(claimName, videoPath, syncContext.PublishBid, streamCreateOptions)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error creating stream: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
for {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fileListResponse, fileIndex, err := findFileByTxid(lbrynet, txSummary.Txid)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error finding file by txid: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if fileListResponse == nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Could not find file in list with correct txid")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fileStatus := fileListResponse.Items[fileIndex]
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if fileStatus.IsFullyReflected {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Info("Stream is fully reflected")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
break
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if !fileStatus.UploadingToReflector {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Warn("Stream is not being uploaded to a reflector. Check your lbrynet settings if this is a mistake.")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
break
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Infof("Stream reflector progress: %d%%", fileStatus.ReflectorProgress)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
time.Sleep(5 * time.Second)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
log.Info("Done")
@ -120,13 +225,7 @@ func getVideoMetadata(basePath, videoID string) (*ytdl.YtdlVideo, string, error)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
func loadVideoMetadata(path string) (*ytdl.YtdlVideo, error) {
f, err := os.Open(path)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
defer f.Close()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
metadataBytes, err := ioutil.ReadAll(f)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
metadataBytes, err := os.ReadFile(path)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
return nil, err
}
@ -221,3 +320,50 @@ func runCmd(cmd *exec.Cmd) ([]string, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return strings.Split(strings.Replace(string(outLog), "\r\n", "\n", -1), "\n"), nil
}
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func getVideoDownloadedPath(videoDir, videoID string) (string, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
files, err := ioutil.ReadDir(videoDir)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return "", err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
for _, f := range files {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if f.IsDir() {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
continue
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if path.Ext(f.Name()) == ".mp4" && strings.Contains(f.Name(), videoID) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return path.Join(videoDir, f.Name()), nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return "", errors.New("could not find any downloaded videos")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func getAbbrevDescription(v *ytdl.YtdlVideo) string {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
maxLength := 2800
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
description := strings.TrimSpace(v.Description)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
additionalDescription := "\nhttps://www.youtube.com/watch?v=" + v.ID
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if len(description) > maxLength {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
description = description[:maxLength]
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return description + "\n..." + additionalDescription
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// if jsonrpc.Client.FileList is extended to match the actual jsonrpc schema, this can be removed
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func findFileByTxid(client *jsonrpc.Client, txid string) (*jsonrpc.FileListResponse, int, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
response, err := client.FileList(0, 20)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
for {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error getting file list page: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, 0, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
index := sort.Search(len(response.Items), func (i int) bool { return response.Items[i].Txid == txid })
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if index < len(response.Items) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return response, index, nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if response.Page >= response.TotalPages {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, 0, nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
response, err = client.FileList(response.Page + 1, 20)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)