Download video to sync to local cache #113

Open
pseudoscalar wants to merge 7 commits from pseudoscalar/issue/112/v1 into local
Showing only changes of commit b9bf2f6e73 - Show all commits

View file

@ -1,22 +1,223 @@
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
package local package local
import ( import (
"encoding/json"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"errors"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"fmt" "fmt"
"io/ioutil"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"time"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"os"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"os/exec"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"path"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"strings"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log "github.com/sirupsen/logrus"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/spf13/cobra" "github.com/spf13/cobra"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/lbryio/ytsync/v5/downloader/ytdl"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/lbryio/lbry.go/v2/extras/jsonrpc"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
) )
type SyncContext struct {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
TempDir string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
LbrynetAddr string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func (c *SyncContext) Validate() error {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if c.TempDir == "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return errors.New("No TempDir provided")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if c.LbrynetAddr == "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return errors.New("No Lbrynet address provided")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var syncContext SyncContext
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func AddCommand(rootCmd *cobra.Command) { func AddCommand(rootCmd *cobra.Command) {
cmd := &cobra.Command{ cmd := &cobra.Command{
Use: "local", Use: "local",
Short: "run a personal ytsync", Short: "run a personal ytsync",
Run: localCmd, Run: localCmd,
Args: cobra.ExactArgs(1),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
} }
//cmd.Flags().StringVar(&cache, "cache", "", "path to cache") cmd.Flags().StringVar(&syncContext.TempDir, "temp-dir", getEnvDefault("TEMP_DIR", ""), "directory to use for temporary files")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
cmd.Flags().StringVar(&syncContext.LbrynetAddr, "lbrynet-address", getEnvDefault("LBRYNET_ADDRESS", ""), "JSONRPC address of the local LBRYNet daemon")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
rootCmd.AddCommand(cmd) rootCmd.AddCommand(cmd)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func getEnvDefault(key, defaultValue string) string {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if value, ok := os.LookupEnv(key); ok {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return value
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return defaultValue
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
} }
func localCmd(cmd *cobra.Command, args []string) { func localCmd(cmd *cobra.Command, args []string) {
fmt.Println("local") err := syncContext.Validate()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Error(err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println(syncContext.LbrynetAddr)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoID := args[0]
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println(videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lbrynet := jsonrpc.NewClient(syncContext.LbrynetAddr)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lbrynet.SetRPCTimeout(5 * time.Minute)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
status, err := lbrynet.Status()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Error(err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println(status.IsRunning)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println(status.Wallet.Connected)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoBasePath := path.Join(syncContext.TempDir, videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
_, videoMetadataPath, err := getVideoMetadata(videoBasePath, videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error getting video metadata: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
err = downloadVideo(videoBasePath, videoMetadataPath)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-11-05 21:31:22 +01:00 (Migrated from github.com)
Review

prolly need to make sure this exists

prolly need to make sure this exists
pseudoscalar commented 2021-11-08 16:37:40 +01:00 (Migrated from github.com)
Review

This should be guaranteed by cobra.ExactArgs(1), but I can a check and error here too.

This should be guaranteed by `cobra.ExactArgs(1)`, but I can a check and error here too.
lyoshenka commented 2021-11-11 23:09:58 +01:00 (Migrated from github.com)
Review

you're right, i just didnt notice that

you're right, i just didnt notice that
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error downloading video: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Info("Done")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func getVideoMetadata(basePath, videoID string) (*ytdl.YtdlVideo, string, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
metadataPath := basePath + ".info.json"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
_, err := os.Stat(metadataPath)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil && !os.IsNotExist(err) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error determining if video metadata already exists: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, "", err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
} else if err == nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Debugf("Video metadata file %s already exists. Attempting to load existing file.", metadataPath)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoMetadata, err := loadVideoMetadata(metadataPath)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Debugf("Error loading pre-existing video metadata: %v. Deleting file and attempting re-download.", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
} else {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return videoMetadata, metadataPath, nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err := downloadVideoMetadata(basePath, videoID); err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, "", err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoMetadata, err := loadVideoMetadata(metadataPath)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return videoMetadata, metadataPath, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func loadVideoMetadata(path string) (*ytdl.YtdlVideo, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
f, err := os.Open(path)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
defer f.Close()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
metadataBytes, err := ioutil.ReadAll(f)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var videoMetadata *ytdl.YtdlVideo
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
err = json.Unmarshal(metadataBytes, &videoMetadata)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return videoMetadata, nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func downloadVideoMetadata(basePath, videoID string) error {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ytdlArgs := []string{
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--skip-download",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--write-info-json",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--force-overwrites",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Sprintf("https://www.youtube.com/watch?v=%s", videoID),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--cookies",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"cookies.txt",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"-o",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
basePath,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ytdlCmd := exec.Command("yt-dlp", ytdlArgs...)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
output, err := runCmd(ytdlCmd)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Debug(output)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func downloadVideo(basePath, metadataPath string) error {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ytdlArgs := []string{
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--no-progress",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"-o",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
basePath,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--merge-output-format",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"mp4",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--postprocessor-args",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"ffmpeg:-movflags faststart",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--abort-on-unavailable-fragment",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--fragment-retries",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"1",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--cookies",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"cookies.txt",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--extractor-args",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"youtube:player_client=android",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--load-info-json",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
metadataPath,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"-fbestvideo[ext=mp4][vcodec!*=av01][height<=720]+bestaudio[ext!=webm][format_id!=258][format_id!=251][format_id!=256][format_id!=327]",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ytdlCmd := exec.Command("yt-dlp", ytdlArgs...)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
output, err := runCmd(ytdlCmd)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Debug(output)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func runCmd(cmd *exec.Cmd) ([]string, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Infof("running cmd: %s", strings.Join(cmd.Args, " "))
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var err error
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
stderr, err := cmd.StderrPipe()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
stdout, err := cmd.StdoutPipe()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
err = cmd.Start()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
outLog, err := ioutil.ReadAll(stdout)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
errorLog, err := ioutil.ReadAll(stderr)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
done := make(chan error, 1)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
go func() {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
done <- cmd.Wait()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
select {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
case err := <-done:
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Error(string(errorLog))
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return strings.Split(strings.Replace(string(outLog), "\r\n", "\n", -1), "\n"), nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
} }

lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)