pylint and other fixes

Makefile

@@ -14,7 +14,7 @@ idea:
 start:
 	dropdb lbry --if-exists
 	createdb lbry
-	lbrynet start --full-node \
+	lbrynet start node \
 		--db-url=postgresql:///lbry --workers=0 --console=advanced --no-spv-address-filters \
 		--lbrycrd-rpc-user=lbry --lbrycrd-rpc-pass=somethingelse \
 		--lbrycrd-dir=${HOME}/.lbrycrd --data-dir=/tmp/tmp-lbrynet

lbry/db/database.py

@@ -113,7 +113,7 @@ class Database:
     def temp_sqlite_regtest(cls, lbrycrd_dir=None):
         from lbry import Config, RegTestLedger  # pylint: disable=import-outside-toplevel
         directory = tempfile.mkdtemp()
-        conf = Config.with_same_dir(directory)
+        conf = Config.with_same_dir(directory).set(blockchain="regtest")
         if lbrycrd_dir is not None:
             conf.lbrycrd_dir = lbrycrd_dir
         ledger = RegTestLedger(conf)

lbry/service/base.py

@@ -58,7 +58,6 @@ class Service:
     This is the programmatic api (as compared to API)
     """
 
-    name: str
     sync: Sync
 
     def __init__(self, ledger: Ledger):