Madiator2011/lbry-sdk
1
0
Fork 0
forked from LBRYCommunity/lbry-sdk
Code Pull requests Activity

test fetchall prevents SQLITE_MISUSE

Browse source
This commit is contained in:
Jack Robison 2019-09-13 14:35:59 -04:00
parent 7dc3e4e7a1
commit 287902f01b
No known key found for this signature in database
GPG key ID: DF25C68FE0239BB2
1 changed files with 31 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
torba/tests/client_tests/unit/test_database.py
View file

@ -436,6 +436,8 @@ class TestUpgrade(AsyncioTestCase):
class TestSQLiteRace(AsyncioTestCase): class TestSQLiteRace(AsyncioTestCase):
max_misuse_attempts = 40000
def setup_db(self): def setup_db(self):
self.db = sqlite3.connect(":memory:", isolation_level=None) self.db = sqlite3.connect(":memory:", isolation_level=None)
self.db.executescript( self.db.executescript(
@ -473,11 +475,12 @@ class TestSQLiteRace(AsyncioTestCase):
except sqlite3.InterfaceError as err: except sqlite3.InterfaceError as err:
self.assertEqual(str(err), "Error binding parameter 0 - probably unsupported type.") self.assertEqual(str(err), "Error binding parameter 0 - probably unsupported type.")
async def test_unhandled_sqlite_misuse(self, max_attempts=100000): async def test_unhandled_sqlite_misuse(self):
# test SQLITE_MISUSE being incorrectly raised as a param 0 binding error # test SQLITE_MISUSE being incorrectly raised as a param 0 binding error
attempts = 0 attempts = 0
try: try:
while attempts < max_attempts: while attempts < self.max_misuse_attempts:
f1 = asyncio.wrap_future( f1 = asyncio.wrap_future(
self.loop.run_in_executor( self.loop.run_in_executor(
self.executor, self.db.executemany, "update test1 set val='derp' where id=?", self.executor, self.db.executemany, "update test1 set val='derp' where id=?",
@ -492,6 +495,31 @@ class TestSQLiteRace(AsyncioTestCase):
) )
attempts += 1 attempts += 1
await asyncio.gather(f1, f2) await asyncio.gather(f1, f2)
self.assertTrue(False, f'failed to raise SQLITE_MISUSE within {max_attempts} tries') self.assertTrue(False, f'failed to raise SQLITE_MISUSE within {self.max_misuse_attempts} tries\n'
f'this test failing means either the sqlite race conditions '
f'have been fixed in cpython or the test max_attempts needs to be increased')
except sqlite3.InterfaceError as err: except sqlite3.InterfaceError as err:
self.assertEqual(str(err), "Error binding parameter 0 - probably unsupported type.") self.assertEqual(str(err), "Error binding parameter 0 - probably unsupported type.")
async def test_fetchall_prevents_sqlite_misuse(self):
# test that calling fetchall sufficiently avoids the race
attempts = 0
def executemany_fetchall(query, params):
self.db.executemany(query, params).fetchall()
while attempts < self.max_misuse_attempts:
f1 = asyncio.wrap_future(
self.loop.run_in_executor(
self.executor, executemany_fetchall, "update test1 set val='derp' where id=?",
((str(i),) for i in range(2))
)
)
f2 = asyncio.wrap_future(
self.loop.run_in_executor(
self.executor, executemany_fetchall, "update test2 set val='derp' where id=?",
((str(i),) for i in range(2))
)
)
attempts += 1
await asyncio.gather(f1, f2)