lint the osx and windows apps

This also fixes a trivial bug in the osx release.
This commit is contained in:
Job Evers-Meltzer 2016-11-01 13:26:03 -05:00
parent e5ba70c3ba
commit 7de4340c38
5 changed files with 7 additions and 7 deletions

View file

@ -7,7 +7,6 @@ import platform
import shutil import shutil
from appdirs import user_data_dir from appdirs import user_data_dir
from twisted.internet import reactor from twisted.internet import reactor
from twisted.web import server
import Foundation import Foundation
bundle = Foundation.NSBundle.mainBundle() bundle = Foundation.NSBundle.mainBundle()
lbrycrdd_path = bundle.pathForResource_ofType_('lbrycrdd', None) lbrycrdd_path = bundle.pathForResource_ofType_('lbrycrdd', None)
@ -22,9 +21,7 @@ if not os.path.isfile(lbrycrdd_path_conf):
f.write(lbrycrdd_path) f.write(lbrycrdd_path)
f.close() f.close()
from lbrynet.lbrynet_daemon.DaemonServer import DaemonServer
from lbrynet.lbrynet_daemon import DaemonControl from lbrynet.lbrynet_daemon import DaemonControl
from lbrynet.lbrynet_daemon.DaemonRequest import DaemonRequest
from lbrynet.conf import settings from lbrynet.conf import settings
from lbrynet.core import utils from lbrynet.core import utils

View file

@ -15,7 +15,7 @@ log = logging.getLogger()
def main(): def main():
conf.update_settings_from_file() conf.update_settings_from_file()
log_file = settings.get_log_filename() log_file = conf.settings.get_log_filename()
log_support.configure_logging(log_file, console=True) log_support.configure_logging(log_file, console=True)
app = LBRYDaemonApp.sharedApplication() app = LBRYDaemonApp.sharedApplication()
reactor.addSystemEventTrigger("after", "shutdown", AppHelper.stopEventLoop) reactor.addSystemEventTrigger("after", "shutdown", AppHelper.stopEventLoop)

View file

@ -61,6 +61,11 @@ VERSION=`python setup.py -V`
pip install -r requirements.txt pip install -r requirements.txt
# not totally sure if pyOpenSSl is needed (JIE) # not totally sure if pyOpenSSl is needed (JIE)
pip install pyOpenSSL pip install pyOpenSSL
pip install pylint
pylint -E --disable=inherit-non-class --disable=no-member --ignored-modules=distutils \
--enable=unused-import lbrynet packaging/osx/lbry-osx-app/lbrygui/
python setup.py install python setup.py install
echo "Building URI Handler" echo "Building URI Handler"

View file

@ -9,7 +9,6 @@ import win32con
import win32gui_struct import win32gui_struct
from jsonrpc.proxy import JSONRPCProxy from jsonrpc.proxy import JSONRPCProxy
from twisted.internet import reactor, error from twisted.internet import reactor, error
from twisted.web import server
try: try:
import winxpgui as win32gui import winxpgui as win32gui
@ -20,8 +19,6 @@ from lbrynet import conf
from lbrynet.core import log_support from lbrynet.core import log_support
from lbrynet.core import utils from lbrynet.core import utils
from lbrynet.lbrynet_daemon import DaemonControl from lbrynet.lbrynet_daemon import DaemonControl
from lbrynet.lbrynet_daemon.DaemonServer import DaemonServer
from lbrynet.lbrynet_daemon.DaemonRequest import DaemonRequest
from lbrynet.conf import settings from lbrynet.conf import settings
from packaging.uri_handler.LBRYURIHandler import LBRYURIHandler from packaging.uri_handler.LBRYURIHandler import LBRYURIHandler

View file

@ -1,4 +1,5 @@
C:\Python27\Scripts\pip.exe install mock C:\Python27\Scripts\pip.exe install mock
C:\Python27\Scripts\pip.exe install pylint C:\Python27\Scripts\pip.exe install pylint
C:\Python27\python.exe C:\Python27\Scripts\trial.py C:\projects\lbry\tests\unit C:\Python27\python.exe C:\Python27\Scripts\trial.py C:\projects\lbry\tests\unit
C:\Python27\Scripts\pylint.exe -E --disable=inherit-non-class --disable=no-member --ignored-modules=distutils --enable=unused-import lbrynet packaging/windows/lbry-win32-app/LBRYWin32App.py
if ($LastExitCode -ne 0) { $host.SetShouldExit($LastExitCode) } if ($LastExitCode -ne 0) { $host.SetShouldExit($LastExitCode) }