Madiator2011/lbry-sdk
1
0
Fork 0
forked from LBRYCommunity/lbry-sdk
Code Pull requests Activity

warn if reader is garbage collected but not closed, do the same for writer

Browse source
This commit is contained in:
Kay Kurokawa 2017-09-29 14:29:35 -04:00
parent 23108585f4
commit d68ca65e41
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lbrynet/blob/reader.py
View file

@ -40,11 +40,15 @@ class HashBlobReader(object):
read(size) and close() read(size) and close()
""" """
def __init__(self, file_path, finished_cb): def __init__(self, file_path, finished_cb):
self.file_path = file_path
self.finished_cb = finished_cb self.finished_cb = finished_cb
self.finished_cb_d = None self.finished_cb_d = None
self.read_handle = open(file_path, 'rb') self.read_handle = open(self.file_path, 'rb')
def __del__(self): def __del__(self):
if self.finished_cb_d is None:
log.warn("Garbage collection was called, but reader for %s was not closed yet",
self.file_path)
self.close() self.close()
def read(self, size=-1): def read(self, size=-1):

5
lbrynet/blob/writer.py
View file

@ -16,6 +16,11 @@ class HashBlobWriter(object):
self._hashsum = get_lbry_hash_obj() self._hashsum = get_lbry_hash_obj()
self.len_so_far = 0 self.len_so_far = 0
def __del__(self):
if self.finished_cb_d is None:
log.warn("Garbage collection was called, but writer was not closed yet")
self.close()
@property @property
def blob_hash(self): def blob_hash(self):
return self._hashsum.hexdigest() return self._hashsum.hexdigest()