Fix unhandled errors #15

Merged

jackrobison merged 4 commits from fix-unhandled-errors into master

2019-08-15 23:00:49 +02:00

jackrobison commented

2019-08-15 20:38:48 +02:00

(Migrated from github.com)

- fixes https://github.com/lbryio/aioupnp/issues/11 - fixes https://github.com/lbryio/aioupnp/issues/14

codecov[bot] commented

2019-08-15 20:40:54 +02:00

(Migrated from github.com)

Codecov Report

Merging #15 into master will increase coverage by 0.08%.
The diff coverage is 96.49%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   92.76%   92.84%   +0.08%     
==========================================
  Files          18       18              
  Lines        1340     1369      +29     
==========================================
+ Hits         1243     1271      +28     
- Misses         97       98       +1

Impacted Files	Coverage Δ
aioupnp/gateway.py	`85.71% <100%> (+0.14%)`	⬆️
aioupnp/serialization/soap.py	`100% <100%> (ø)`	⬆️
aioupnp/protocols/scpd.py	`98.24% <100%> (+0.01%)`	⬆️
aioupnp/commands.py	`92.5% <93.1%> (+0.47%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22586e3...21a379e. Read the comment docs.

# [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/15?src=pr&el=h1) Report > Merging [#15](https://codecov.io/gh/lbryio/aioupnp/pull/15?src=pr&el=desc) into [master](https://codecov.io/gh/lbryio/aioupnp/commit/22586e3cdfea8e03c4943e1663df840684abd182?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `96.49%`. [![Impacted file tree graph](https://codecov.io/gh/lbryio/aioupnp/pull/15/graphs/tree.svg?width=650&token=WAT2zW6Wy6&height=150&src=pr)](https://codecov.io/gh/lbryio/aioupnp/pull/15?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #15 +/- ## ========================================== + Coverage 92.76% 92.84% +0.08% ========================================== Files 18 18 Lines 1340 1369 +29 ========================================== + Hits 1243 1271 +28 - Misses 97 98 +1 ``` | [Impacted Files](https://codecov.io/gh/lbryio/aioupnp/pull/15?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [aioupnp/gateway.py](https://codecov.io/gh/lbryio/aioupnp/pull/15/diff?src=pr&el=tree#diff-YWlvdXBucC9nYXRld2F5LnB5) | `85.71% <100%> (+0.14%)` | :arrow_up: | | [aioupnp/serialization/soap.py](https://codecov.io/gh/lbryio/aioupnp/pull/15/diff?src=pr&el=tree#diff-YWlvdXBucC9zZXJpYWxpemF0aW9uL3NvYXAucHk=) | `100% <100%> (ø)` | :arrow_up: | | [aioupnp/protocols/scpd.py](https://codecov.io/gh/lbryio/aioupnp/pull/15/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvc2NwZC5weQ==) | `98.24% <100%> (+0.01%)` | :arrow_up: | | [aioupnp/commands.py](https://codecov.io/gh/lbryio/aioupnp/pull/15/diff?src=pr&el=tree#diff-YWlvdXBucC9jb21tYW5kcy5weQ==) | `92.5% <93.1%> (+0.47%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/15?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/15?src=pr&el=footer). Last update [22586e3...21a379e](https://codecov.io/gh/lbryio/aioupnp/pull/15?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/aioupnp#15

No description provided.