Daniel Cousens
063643b4a1
HDWallet: show clearer BIP32 adherence for Master key
2014-05-12 09:56:00 +10:00
Daniel Cousens
3ed7d78e59
HDWallet: adhere to BIP32 for CKD
2014-05-10 09:57:16 +10:00
Daniel Cousens
25514d6ac1
HDWallet: remove HmacBytesToBytes
2014-05-10 09:57:16 +10:00
Daniel Cousens
da36003d09
Script: remove sort requirement for multisig
2014-05-09 18:03:41 +10:00
Daniel Cousens
de343b2093
Script: remove Address requirement
2014-05-09 18:03:22 +10:00
Daniel Cousens
f18c5e4c1e
Script: removes Script.createP2SHMultiSigScriptSig
...
It is favoured to compose the scriptSig manually using
Script.createP2SHScriptSig and Script.createMultisigScriptSig.
Added a test to verify that createMultisigScriptSig throws when not
enough signatures a provided and the redeemScript is given.
2014-05-09 16:26:35 +10:00
Daniel Cousens
f8e662e495
Script: rename toScriptHash to getHash and add tests
2014-05-09 13:07:06 +10:00
Daniel Cousens
342c55c864
Address: remove circular dependency fix
...
This is no longer a problem.
2014-05-09 12:26:38 +10:00
Daniel Cousens
48e15b587a
Address: remove redundant comments
2014-05-09 12:25:24 +10:00
Daniel Cousens
708aa03390
Transaction/Script: bitcoin network no longer implied
...
A Transaction (and its subsequent scripts) do not carry any network
specific information in the Bitcoin protocol.
Therefore they can not (without further context) produce the network
specific constants for the generation of the base58 Addresses.
As TransactionOut.address is used heavily throughout Wallet and other
areas of the library, this could not be entirely removed without a large
number of changes.
For now, TransactionOut.address is only defined in the case of
Tx.addOutput being used directly:
Transaction.addOutput(address, value)
2014-05-08 10:59:58 +10:00
Daniel Cousens
4207a0df99
Address: use Address.Error instead
...
This change is necessary for instanceof comparison when attempting to
rethrow. Callbacks may be a better solution to introduce later.
2014-05-08 10:59:58 +10:00
Daniel Cousens
5e0d38ba54
Address: add Address.*ScriptPubKey and tests
...
The introduction of these two functions allow for the all the network
related code to be eventually removed from Transaction and Script.
Previously the result for non-standard transactions was undefined
behaviour. This change mandates that an exception is thrown if a
non-standard transaction is input.
2014-05-08 10:59:58 +10:00
Daniel Cousens
0822def7e0
Script: add standard Script.create*ScriptPubKey
...
Extracts the two Script types out of Script.createOutputScript, and puts
them both under test.
Also renames Script.createMultiSigOutputScript to adhere to the same
convention.
2014-05-08 10:59:58 +10:00
Daniel Cousens
d0f684844c
Script: add toHex, fromHex
...
Script.fromHex previously existed, but was not under any kind of test.
This commit adds tests (despite being a little circular in nature) to
check that the output is as expected.
2014-05-08 10:59:58 +10:00
Daniel Cousens
57b8afbdab
Network: rename Network to Networks
...
This change removes the most common ambiguities.
As the network module is not representative of a class, the lower case
has been used.
2014-05-08 10:59:58 +10:00
Daniel Cousens
929b8d2b62
Script: more consistent input handling
2014-05-08 10:59:58 +10:00
Daniel Cousens
7ad695e427
Script: fix assertion message grammar
2014-05-08 10:59:58 +10:00
Daniel Cousens
74e53b49a5
Script/Transaction: remove untested functions
...
These functions are not under test, and are unnecessary bloat due to a
confusing API.
Script.from*(asmStr) were two functions that attempted to parse ASM
codes and produce a script from this.
While useful, an parser can be introduced later under a single function
and under test... removed.
Although Script.extractPublicKeys implementation is likely to be correct,
it is not absolute in that what it returns is even strictly a set of
public keys.
It is a useful function, but can be done in a better way later,
probably checking against the Script templates instead.
Transaction.signWithKeys has some inherent undocumented behaviour, and it is not
clear when you would use it over just Transaction.addOutput and
Transaction.sign individually. Nor does it mimic anything in the
bitcoind API... removed.
2014-05-08 10:59:58 +10:00
Daniel Cousens
76323a07d0
Transaction: restrict TxIn/TxOut constructor params
...
To keep this change minimal, both TxIn/TxOut still use the parameter
object for initialization. TxOut accepts only the types it uses
internally, and not hex or byte arrays for scripts.
The clone is unnecessary as a TransactionOut is never mutated after its
creation.
This resulted in TransactionOut.scriptPubKey no longer being needed,
and was removed. To access the scriptPubKey as a byte buffer, a user
can simply use:
TransactionOut.script.toBuffer()
Unfortunately, this leaves TransactionOut in a sorry state of test.
Something that needs to be fixed.
2014-05-08 10:59:58 +10:00
Daniel Cousens
9a7e291d70
Transaction: fix incorrect outIndex type
2014-05-08 08:52:07 +10:00
Daniel Cousens
a77846701f
Fixes network support for TxOut
2014-05-06 15:40:40 +10:00
Daniel Cousens
4012b82bec
Fixes Transaction.addOutput(Address, Number)
2014-05-06 15:40:40 +10:00
Daniel Cousens
695eb64a3a
Clarifies Transaction.addOutput param documentation
2014-05-06 15:40:40 +10:00
Daniel Cousens
d65a3c36e2
Merge pull request #159 from williamcotton/master
...
fixed issues with testnet and createTx
2014-05-06 08:04:02 +10:00
Daniel Cousens
baa568697b
Transaction.deserialize no longer mutates input
2014-05-05 09:11:37 +10:00
Daniel Cousens
02013beda9
Renames variables to be more verbose
2014-05-05 09:11:37 +10:00
Daniel Cousens
b860daf70b
Corrects endianness comments
2014-05-04 17:31:47 +10:00
Daniel Cousens
87048d3b4e
Adds performance notes
2014-05-04 17:31:47 +10:00
Daniel Cousens
4716eb29bf
Removes redundant convert functions
2014-05-04 17:31:47 +10:00
Daniel Cousens
a8cf2fdd9e
Changes internal serialization to use Buffers instead
2014-05-04 17:31:22 +10:00
Daniel Cousens
c8bda6dde6
Adds Buffer extensions
2014-05-04 17:30:59 +10:00
Daniel Cousens
10ee5532c3
Serialize now returns a buffer
2014-05-04 15:37:25 +10:00
Daniel Cousens
09c6a787d9
Changes sequence number to an actual Number
2014-05-04 15:37:25 +10:00
Wei Lu
a830e2cded
Merge pull request #168 from dcousens/167fix
...
Fixes #167
2014-05-04 10:11:19 +08:00
Daniel Cousens
ff08c2eec3
Fixes #167 and adds temporary test
2014-05-04 12:07:05 +10:00
Daniel Cousens
e6a9186af3
Removes unnecessary new Buffer
2014-05-04 11:58:06 +10:00
Daniel Cousens
e2e190c766
Variables names made consistent with constructor
2014-05-04 11:57:49 +10:00
Daniel Cousens
bb80eda218
Merge pull request #165 from bitcoinjs/bigi-monkey-patching-no-more
...
Upgrade bigi & remove monkey patching
2014-05-04 07:39:19 +10:00
Wei Lu
1e6b283f9a
Remove Number.isFinite check on tx input index
2014-05-03 10:19:38 +08:00
Wei Lu
af1f121fd4
upgrade bigi & remove monkey patching
2014-05-03 10:04:54 +08:00
Wei Lu
39516d5532
Merge pull request #163 from dcousens/wordass
...
Enforces convert.wordsToBytes to only allow for byte input
2014-04-30 08:49:05 +08:00
Kyle Drake
5fd9fe62dc
Fix address prefixes, add dogecoin/litecoin BIP32 versions
2014-04-29 15:07:15 -07:00
Daniel Cousens
b09dd73cbe
Enforces bytesToWordArray only operates on byte arrays
2014-04-30 05:07:41 +10:00
Wei Lu
45c1c8350e
Merge pull request #154 from dcousens/convrem
...
Remove dead code from Convert module
2014-04-26 12:27:08 +08:00
Wei Lu
6833acaf3a
Merge pull request #152 from dcousens/p2shsign
...
Preliminary test for P2shsign
2014-04-26 12:26:50 +08:00
William Cotton
590bb8e1c3
custom changeAddress for wallet.createTx()
2014-04-25 12:49:51 -07:00
William Cotton
a9bc42019a
fixed issues with testnet and createTx
2014-04-25 12:39:30 -07:00
Daniel Cousens
e40377a471
Removes unused functions from convert
2014-04-26 05:11:45 +10:00
Daniel Cousens
69c0497038
Renames createInputScript to createPubKeyHashScriptSig
2014-04-26 04:04:19 +10:00
Daniel Cousens
a4e68d142d
Adds assertions for types in signScriptSig
2014-04-26 04:04:16 +10:00
Daniel Cousens
8ad8f6f169
Renames p2shsign to signScriptSig
2014-04-26 03:51:13 +10:00
Daniel Cousens
5546cae928
Removes type coercion for a stricter TX API
2014-04-26 03:51:13 +10:00
Daniel Cousens
9af8d95daf
Removes applyMultisigs and adds setScriptSig
2014-04-26 03:51:13 +10:00
Daniel Cousens
89cf731ac7
Adds assertion messages
2014-04-26 02:37:48 +10:00
Daniel Cousens
c3e9d568c5
Adds RFC6979 test vectors and fixes ecdsa.sign/detGenK
2014-04-26 02:17:28 +10:00
ethers
1c8f135d9c
assertion message
2014-04-24 23:29:12 -07:00
Wei Lu
102f2bd0c9
make sure createInputScript convert pubKey to buffer before writing out bytes
...
[fixes #156 ]
2014-04-25 10:01:50 +08:00
Daniel Cousens
df6ea8aea2
Removes toPaddedBuffer and extends toBuffer
2014-04-25 00:18:13 +10:00
Daniel Cousens
d8883e8d32
Adds BI.toPaddedBuffer and toBuffer
2014-04-24 07:22:23 +10:00
Daniel Cousens
bc37e65014
Enforces Array input for deterministicGenerateK
2014-04-23 06:28:00 +10:00
Kyle Drake
1b66976d92
Merge pull request #146 from dcousens/magictests
...
MagicHash Tests
2014-04-21 09:39:50 -07:00
Kyle Drake
21aa517cd2
Merge pull request #143 from dcousens/multisigfix
...
Multi-sig ScriptSig Support
2014-04-21 09:39:03 -07:00
Daniel Cousens
ae60e6eb95
Replacse JSBN with bigi
2014-04-22 02:19:30 +10:00
Daniel Cousens
96ebb65099
Removes ecdsa.getBigRandom
2014-04-22 02:04:56 +10:00
Daniel Cousens
f5ce83beca
Adds working implementation of Script.createP2SHMultisigScriptSig
2014-04-22 00:28:13 +10:00
Daniel Cousens
fb6c76a976
Merges Buffer refactorings from base58-native by Stephen Pair
2014-04-22 00:24:20 +10:00
Daniel Cousens
1b46a10d2a
magicHash now uses Buffers internally
2014-04-22 00:23:12 +10:00
Daniel Cousens
c44af2109e
Uses typeof address === 'string' instead
2014-04-20 04:54:50 +10:00
Daniel Cousens
64dc11486c
Removes resolved TODO
2014-04-20 04:49:04 +10:00
Daniel Cousens
92f1c3e319
Fixes Transaction.addOutput() param handling to match documentation
...
Now (horrendously) supports other networks
2014-04-20 04:47:56 +10:00
Daniel Cousens
f3a55f63dc
Assert uses strictEqual instead of direct comparison
2014-04-20 04:39:29 +10:00
Daniel Cousens
1d1306b054
Removes Address.fromPubKey and improves test vectors
2014-04-20 04:38:33 +10:00
Daniel Cousens
eae613d244
Adds error messages and better version checking
2014-04-18 17:12:29 +10:00
Daniel Cousens
682ec133bb
Migrates Address to stricter API subset
2014-04-18 17:12:29 +10:00
Wei Lu
701af74ade
Merge pull request #142 from dcousens/asserts
...
Adds assertion error messages for HDWallet
2014-04-18 09:59:06 +08:00
Wei Lu
06cd6a698b
Merge pull request #139 from dcousens/eckeystrict
...
Migrates ECKey to stricter API
2014-04-18 09:56:41 +08:00
Daniel Cousens
5adaa7dd54
Prefer Array.prototype.slice over map
2014-04-18 06:43:59 +10:00
Daniel Cousens
de59f6d3ac
Adds assertion error messages for HDWallet
2014-04-18 06:43:14 +10:00
Daniel Cousens
ca4ba91d9c
Cleans up ECKey error handling
2014-04-18 06:36:34 +10:00
Daniel Cousens
b4f70dcdde
Migrates ECKey to stricter API
2014-04-18 06:36:27 +10:00
Kyle Drake
669444cb10
Merge pull request #135 from greenaddress/low-s-signatures
...
Uses low 's' values for signatures
2014-04-17 08:51:40 -07:00
Daniel Cousens
505e33c942
Changes netstr to networkString
2014-04-17 19:49:03 +10:00
GreenAddress.it
d7c2e4d5a5
Uses low 's' values for signatures
2014-04-17 06:05:41 +02:00
Kyle Drake
3219e5e727
Merge pull request #132 from dcousens/remmisc
...
Removes test/misc.js and moves tests to appropriate location
2014-04-16 14:25:35 -07:00
Daniel Cousens
ddea4b176b
Moves derivation math out into the open
2014-04-17 06:45:57 +10:00
Daniel Cousens
bacf7e7ae2
Removes format dependency
2014-04-17 06:45:29 +10:00
Daniel Cousens
814aa9e552
HDWallet now uses Buffers internally
2014-04-17 06:45:24 +10:00
Daniel Cousens
a4ab75d560
Renames network parameter to netstr
...
This should make the intent clearer.
This commit also catches the `null` case for the seed parameter.
2014-04-17 06:09:45 +10:00
Daniel Cousens
bc05828fbc
Adds Buffers as input parameters
2014-04-17 06:07:06 +10:00
Daniel Cousens
f047afef2d
Updates network.js constant names
2014-04-17 05:50:59 +10:00
Daniel Cousens
56336b9c2b
Removes use of convert module
2014-04-17 04:16:51 +10:00
Daniel Cousens
a689c6fc9a
Renames ecparams to curve to avoid confusion
2014-04-16 21:13:54 +10:00
Daniel Cousens
8a9a377d70
Merge pull request #129 from dcousens/indexclean
...
Cleanup of Index.js
2014-04-14 16:21:54 +10:00
Daniel Cousens
db115e1b27
CryptoJS no longer exported by default
2014-04-14 16:19:17 +10:00
Daniel Cousens
addf4528d4
Removes Key module (use ECKey)
2014-04-14 15:45:31 +10:00
Wei Lu
4b86b1c7b8
clean up comments & extract methods
...
[follow-up #125 ]
2014-04-14 12:53:12 +08:00
Daniel Cousens
82a17de5c4
Orders modules by name
2014-04-14 13:15:43 +10:00
sidazhang
aa43e98ac0
Aligning type naming with bitcoind and fixed pubkeyhash bug
2014-04-11 15:20:42 -07:00
Daniel Cousens
1f0fb90213
Pads zeros in toBytes output, fixes #121
2014-04-09 18:06:50 +10:00
Daniel Cousens
6de94856e3
Makes ECDSA capitalization consistent
2014-04-09 04:11:13 +10:00
Wei Lu
dd509d05cf
Merge pull request #114 from dcousens/secsimpl
...
Removal of curveFpDecodePointHex
2014-04-08 22:24:33 +08:00
Daniel Cousens
aa8d86e6a4
Hash160 now outputs a buffer
2014-04-08 23:44:55 +10:00
Daniel Cousens
c99a576fbd
Migrates all usage of crypto-js/sha256 to ./crypto
2014-04-08 23:07:46 +10:00
Daniel Cousens
81d9c8e759
Renames util.js to crypto.js
2014-04-08 22:00:28 +10:00
Daniel Cousens
a4c2cc6dd4
Removes pointless error utility function
2014-04-08 21:53:47 +10:00
Daniel Cousens
7451c54cc6
Removes curveFpDecodePointHex
2014-04-07 13:51:12 +10:00
Daniel Cousens
39abb2b9f9
Stops using decodeFromHex
2014-04-07 13:49:53 +10:00
Wei Lu
703275f235
Merge pull request #112 from dcousens/b58
...
Base58 isolation and preparation for Buffers
2014-04-04 16:41:00 +08:00
Daniel Cousens
6fa0c07763
Changes existing code to use new base58 API
2014-04-04 05:10:12 +11:00
Daniel Cousens
f53b821cc9
Isolates Base58Check encoding from Base58 code/tests
2014-04-03 19:45:05 +11:00
lms
b79ccb2c0c
100% coverage of wallet.js
2014-04-01 21:05:46 +02:00
Daniel Cousens
04684b74f1
Some cosmetic fixes
2014-04-01 15:52:40 +11:00
Wei Lu
93fe1b4c78
cosmetic standardization
...
[closes #56 ]
2014-03-31 11:47:47 +08:00
Wei Lu
161127d65a
Merge branch 'msgvers-patch2' of github.com:dcousens/bitcoinjs-lib into dcousens-msgvers-patch2
...
Conflicts:
src/message.js
2014-03-31 10:08:25 +08:00
Wei Lu
06b6112d58
Merge branch 'dangerpriv' of github.com:dcousens/bitcoinjs-lib into dcousens-dangerpriv
2014-03-29 21:56:44 +08:00
Wei Lu
db35a84a80
Merge pull request #105 from dcousens/removeexport
...
Removes deprecated ECKey.export function
2014-03-29 19:24:54 +08:00
Daniel Cousens
8fd06681ef
Adds fail fast assertions for invalid input
2014-03-29 19:41:05 +11:00
Daniel Cousens
3fa43b83b6
Comma consistency
2014-03-29 19:25:04 +11:00
Daniel Cousens
626c31911b
Removes dangerous private key throwaway
2014-03-29 19:25:04 +11:00
Daniel Cousens
8f7f50d555
Removes deprecated ECKey.export function
2014-03-29 18:12:02 +11:00
Daniel Cousens
10dea421d5
Removes circular dependancy of ECKey
2014-03-29 17:50:50 +11:00
Daniel Cousens
bfc5924522
Compression is irrelevant in comparison
2014-03-29 17:31:27 +11:00
Daniel Cousens
669a58bbf8
Removes unnecessary SHA256 calculations
2014-03-29 17:27:10 +11:00
Daniel Cousens
78e91e8648
Further isolates failure tests and joins [un]/compressed key tests
2014-03-29 17:06:33 +11:00
Daniel Cousens
38f09b49e9
Now using Bytes consistently for signatures
2014-03-29 06:05:07 +11:00
Daniel Cousens
7ec046f797
Changes Message.*Message function names to Message.*
2014-03-29 06:03:43 +11:00
Daniel Cousens
373f668562
Adds version support to Message.verifyMessage
2014-03-28 16:44:00 +11:00
Wei Lu
a1c80b8f51
minor cleanup of wallet.sign
2014-03-28 11:32:15 +08:00
Wei Lu
0ce14a7c84
Merge pull request #96 from ralphtheninja/master
...
cleaned up address.js and util.js
2014-03-28 10:01:26 +08:00
lms
98aeb47c6f
cleaned up address.js
2014-03-27 23:11:04 +01:00
Kyle Drake
275d5509dc
Merge pull request #98 from symaxian/master
...
Cleaning up message.js
2014-03-27 13:59:29 -07:00
Jonathon Reesor
096f8c982e
Cleaning up message.js
2014-03-26 21:00:08 -04:00
Kyle Drake
2f5b302288
Merge pull request #97 from dcousens/reverseVarInt
...
Adds varIntToNum conversion function
2014-03-26 16:20:58 -07:00
Wei Lu
39c181dce6
allow fee to be set to zero
2014-03-26 20:20:58 +08:00
Wei Lu
4d4388f6bf
make wallet async functions truly async
2014-03-26 20:05:13 +08:00
Daniel Cousens
63dd7c7dec
Now uses varIntToNum
2014-03-26 19:11:37 +11:00
Daniel Cousens
20599f66c9
Adds varIntToNum conversion function
2014-03-26 18:30:17 +11:00
Wei Lu
8d2525dba1
allow feePerKb to be set to zero
2014-03-26 08:43:34 +08:00
Wei Lu
68b08b638a
add async version of createTx
2014-03-26 08:43:33 +08:00
Wei Lu
f7d4895b74
add async version of setUnspentOutputs
2014-03-26 08:43:33 +08:00
Wei Lu
83db6483fa
remove unnecessary imports from wallet
2014-03-26 08:43:33 +08:00
Wei Lu
75218e784f
Transaction fee calculation does not need BigInteger
2014-03-26 08:43:33 +08:00
Wei Lu
7bfa6ab9d2
remove scriptPubKey from wallet.outputs, set/get unspent outputs as it is unused
2014-03-26 08:43:33 +08:00
Wei Lu
7bd312de71
get rid of magic numbers in fee estimation
2014-03-26 08:43:33 +08:00
Wei Lu
58ab0b631e
getBalance returns total unspent
2014-03-26 08:43:33 +08:00
Wei Lu
9fc5505730
getUnspentOutputs excludes spent outputs
2014-03-26 08:43:33 +08:00
Wei Lu
77b5d1ee21
getCandidateOuputs ignores spent outputs
2014-03-26 08:43:33 +08:00
Wei Lu
2501868f52
remove old methods
2014-03-26 08:43:32 +08:00
Wei Lu
471bc7ed97
skip change if it is not above dust threshold
2014-03-26 08:43:32 +08:00
Wei Lu
90921798cf
throws error on insufficient fund
2014-03-26 08:43:32 +08:00