Commit graph

651 commits

Author SHA1 Message Date
Daniel Cousens 58fd12e66d ecdsa: always use signature object 2014-05-24 16:25:38 +10:00
Wei Lu 52217ea262 Merge pull request #187 from dcousens/messagefixtures
Improved message fixtures and data driven testing
2014-05-24 04:40:02 +00:00
Daniel Cousens bd1a08bfa1 ecdsa: use signum() over compareTo 2014-05-24 14:33:25 +10:00
Daniel Cousens 37d5147cac ecdsa: add invalid tests for verifyRaw 2014-05-24 14:33:25 +10:00
Daniel Cousens 1d6b1fe58b message: better variable names 2014-05-24 14:33:24 +10:00
Daniel Cousens 2114deba95 message: data-driven tests 2014-05-24 13:50:27 +10:00
Wei Lu 3f80882939 Merge pull request #186 from dcousens/jsontests
JSON Test data
2014-05-23 16:31:04 +00:00
Wei Lu d4e1652688 Merge pull request #185 from dcousens/secclean
SEC clean and bigi upgrade
2014-05-23 16:21:06 +00:00
Wei Lu c6bc0ebdcb Merge pull request #184 from dcousens/ecclean
ECDSA cleanup
2014-05-23 16:16:05 +00:00
Daniel Cousens b2351f9026 tests: use JSON fixtures exclusively 2014-05-24 00:52:24 +10:00
Daniel Cousens 0fcda5835e tests: remove bigi test fixture 2014-05-24 00:52:24 +10:00
Daniel Cousens aca565239a ECKey: remove unnecessary slice 2014-05-24 00:51:56 +10:00
Daniel Cousens cd326921bc bigi: upgrade to 1.1.0 2014-05-24 00:51:56 +10:00
Daniel Cousens 1087ac07de sec: fix formatting 2014-05-24 00:51:56 +10:00
Daniel Cousens b8858c0bc9 sec: use BigInteger.fromHex directly 2014-05-24 00:51:56 +10:00
Daniel Cousens da48c988f6 sec: use a hashtable for lookup 2014-05-24 00:51:56 +10:00
Daniel Cousens 087ca551f5 ecdsa: fix indentation 2014-05-24 00:48:31 +10:00
Daniel Cousens d05d661aea ecdsa: use standard declarative notation for functions 2014-05-24 00:48:31 +10:00
Daniel Cousens bcfd62fdb5 ecdsa: remove implicit ecparams 2014-05-24 00:48:31 +10:00
Daniel Cousens ab2ca395ac ecdsa: remove ECKey dependency in tests 2014-05-24 00:48:31 +10:00
Daniel Cousens 2dec1375a1 ecdsa: use (r, s) values directly 2014-05-24 00:48:31 +10:00
Daniel Cousens 8d7408202f ecdsa: consistent parameter ordering 2014-05-24 00:48:31 +10:00
Daniel Cousens abe65b8d4a ecdsa: use shamirs trick 2014-05-24 00:48:20 +10:00
Wei Lu d9184ba6b8 Package: node-browserify -> browserify 2014-05-24 00:47:26 +10:00
Wei Lu e4aac0f2de Merge pull request #183 from dcousens/ecconst
EC constants and bitShifts
2014-05-22 21:36:59 +10:00
Wei Lu b56a039350 Merge pull request #182 from dcousens/ectests
EC Tests and further use of Buffers
2014-05-22 19:18:35 +10:00
Daniel Cousens a17a5b23d9 ec: fix point decoding for other curves 2014-05-22 12:33:47 +10:00
Daniel Cousens 5ec9504ed6 ecdsa: opt for shiftRight, pow and square
In the given situations, these offer better readability, or in the case
of shiftRight, a substantial performance increase.
2014-05-22 12:33:47 +10:00
Daniel Cousens 7d89ff427c ecdsa: comment cleanup 2014-05-22 12:33:47 +10:00
Daniel Cousens 0865f09d20 ec/dsa: extract P_OVER_FOUR as a curve specific constant
This actually resolves a possible bug if multiple ecparams were used
(aka different values for P_OVER_FOUR, but only the cached was used).
2014-05-22 12:33:47 +10:00
Daniel Cousens 1e54c521d5 ec: extract BigInteger constants 2014-05-22 12:33:47 +10:00
Daniel Cousens d9ce4bee6b ec: use signum() not equals(BigInteger.ZERO) 2014-05-22 12:33:47 +10:00
Daniel Cousens d14b08efd1 ec/dsa: recovery param now used consistently
Also added an assertion rather than massaging the input.
2014-05-22 12:32:28 +10:00
Wei Lu aafbe46b35 Merge pull request #181 from dcousens/mesnet
Message signing and altcoins
2014-05-19 00:12:42 +10:00
Wei Lu fe5ac4dde2 Merge pull request #180 from dcousens/eckey1
ECKey WIF only
2014-05-19 00:10:58 +10:00
Daniel Cousens 24371425f9 ec: decodeFrom now uses Buffers and handles errors 2014-05-18 17:52:49 +10:00
Daniel Cousens a3f691bf7c ecdsa: parseSigCompact use Buffer API
parseSigCompact also now returns the correct recovert parameter without
the need to subtract the compression bit.
This makes it easier to use.
2014-05-18 17:52:49 +10:00
Daniel Cousens f7c7265d64 ecdsa: parseSig now uses buffer API 2014-05-18 17:52:49 +10:00
Daniel Cousens ccca6989b5 ec: getEncoded now uses Buffer API 2014-05-18 17:52:49 +10:00
Daniel Cousens db3ffe58d1 message: use serializeSigCompact 2014-05-18 17:52:49 +10:00
Daniel Cousens 1c76bdf9c3 ec: add better test vectors for ECPointFp encode/decode
These test vectors were generated internally.
2014-05-18 17:52:49 +10:00
Daniel Cousens 4c7108d561 ecdsa: add serializeSigCompact and tests
This also adds tests for all other ECDSA serialize/parsing functions.
The k, r, s and D values were sourced from test vectors on
https://bitcointalk.org/index.php?topic=285142.40 .

The compact signatures (aka, i values) were generated from bitcoinjslib, but they
are straight forward anyway.
2014-05-18 17:52:49 +10:00
Daniel Cousens b208a6ab78 crypto/ecdsa: moves HmacSHA256 to crypto 2014-05-18 17:52:49 +10:00
Daniel Cousens 99a1b7274c Transaction: use the type embedded in the signature 2014-05-18 17:52:48 +10:00
Daniel Cousens 6eb167b2c8 message: remove unnecessary tests 2014-05-18 17:51:36 +10:00
Daniel Cousens 87567e008a message: use base64 for signature data 2014-05-18 17:51:36 +10:00
Daniel Cousens 6b5990c6e2 message: support alternate networks 2014-05-18 17:51:36 +10:00
Daniel Cousens dc69162757 message: remove signing verification
The signature verifications here are unnecessary, as this
is not what is under test.
2014-05-18 17:51:36 +10:00
Daniel Cousens 10fe4474d1 ECKey: remove *Buffer/*Hex functions
An ECKey is a composition of a private key (D), a public key (Q) and its
compression flag.

These functions gave the impression of serialization of this
composition, when really they only serialized `D`.
They have therefore been removed in favour of always using a sane
serialization format (WIF) that matches the needed behaviour.

If a user needs the previous functionality, simply use `privKey.D.*`
instead of `privKey.*`, as BigInteger supports `*Buffer/*Hex` functions
as expected.
2014-05-18 17:50:10 +10:00
Daniel Cousens bf109f32a9 ECPubKey: improve tests and extract test data to fixtures
The use of fixtures allows for more behavioural driven tests and simpler
addition of more test cases in future.

However, as ECPubKey is just a wrapper around other strenuously tested
modules, the test data is currently limited to testing a subset of the
total wrapper.

This should probably be done better by using mocked out modules instead.
2014-05-18 17:50:10 +10:00