LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Projects Releases 14 Packages Wiki Activity

Update RangeField #28

Merged
jeffreypicard merged 2 commits from feature/jeffreypicard/update-range-query into master 2021-12-06 17:24:48 +01:00
Conversation 0 Commits 2 Files changed 9 +1959 -229
jeffreypicard commented 2021-12-03 02:37:19 +01:00 (Migrated from github.com)
Copy link

Allow repeated range fields per term (for i.e. 0 < x < 100).
Use int32 in RangeField instead of str, as str is never needed.
Remove channel_join field.

Also decided to add the generated python protobufs to source control, like the go ones.

Allow repeated range fields per term (for i.e. 0 < x < 100). Use int32 in RangeField instead of str, as str is never needed. Remove channel_join field. Also decided to add the generated python protobufs to source control, like the go ones.
shyba (Migrated from github.com) reviewed 2021-12-03 02:37:19 +01:00
jackrobison (Migrated from github.com) reviewed 2021-12-03 02:37:19 +01:00
lyoshenka (Migrated from github.com) approved these changes 2021-12-03 17:17:24 +01:00
server/search.go
lyoshenka (Migrated from github.com) commented 2021-12-03 17:17:17 +01:00
Copy link

what is this doing? numbers like 1 and 360 should either be constants or there should be a comment explaining what this is

what is this doing? numbers like `1` and `360` should either be constants or there should be a comment explaining what this is
lyoshenka (Migrated from github.com) reviewed 2021-12-03 17:17:50 +01:00
server/search.go
lyoshenka (Migrated from github.com) commented 2021-12-03 17:17:49 +01:00
Copy link

probably both

probably both
jackrobison (Migrated from github.com) reviewed 2021-12-03 17:18:15 +01:00
server/search.go
jackrobison (Migrated from github.com) commented 2021-12-03 17:18:15 +01:00
Copy link

This is for rounding off times to improve cache hits. It should probably be a config setting, we were thinking of doing the same thing in python

This is for rounding off times to improve cache hits. It should probably be a config setting, we were thinking of doing the same thing in python
Sign in to join this conversation.
Reviewers
No reviewers
jackrobison
shyba
lyoshenka
Labels
Clear labels   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
documentation

Improvements or additions to documentation

  
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

No labels
consider soon
documentation
good first issue
hacktoberfest
help wanted
priority: blocker
priority: high
priority: low
priority: medium
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/herald.go#28
No description provided.
Delete branch "feature/jeffreypicard/update-range-query"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?