Update RangeField #28

Merged
jeffreypicard merged 2 commits from feature/jeffreypicard/update-range-query into master 2021-12-06 17:24:48 +01:00
jeffreypicard commented 2021-12-03 02:37:19 +01:00 (Migrated from github.com)

Allow repeated range fields per term (for i.e. 0 < x < 100).
Use int32 in RangeField instead of str, as str is never needed.
Remove channel_join field.

Also decided to add the generated python protobufs to source control, like the go ones.

Allow repeated range fields per term (for i.e. 0 < x < 100). Use int32 in RangeField instead of str, as str is never needed. Remove channel_join field. Also decided to add the generated python protobufs to source control, like the go ones.
shyba (Migrated from github.com) reviewed 2021-12-03 02:37:19 +01:00
jackrobison (Migrated from github.com) reviewed 2021-12-03 02:37:19 +01:00
lyoshenka (Migrated from github.com) approved these changes 2021-12-03 17:17:24 +01:00
lyoshenka (Migrated from github.com) commented 2021-12-03 17:17:17 +01:00

what is this doing? numbers like 1 and 360 should either be constants or there should be a comment explaining what this is

what is this doing? numbers like `1` and `360` should either be constants or there should be a comment explaining what this is
lyoshenka (Migrated from github.com) reviewed 2021-12-03 17:17:50 +01:00
lyoshenka (Migrated from github.com) commented 2021-12-03 17:17:49 +01:00

probably both

probably both
jackrobison (Migrated from github.com) reviewed 2021-12-03 17:18:15 +01:00
jackrobison (Migrated from github.com) commented 2021-12-03 17:18:15 +01:00

This is for rounding off times to improve cache hits. It should probably be a config setting, we were thinking of doing the same thing in python

This is for rounding off times to improve cache hits. It should probably be a config setting, we were thinking of doing the same thing in python
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/herald.go#28
No description provided.