LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Projects Releases 14 Packages Wiki Activity

Herald.go #47

Merged
jeffreypicard merged 5 commits from herald.go into master 2022-08-09 13:43:02 +02:00
Conversation 3 Commits 5 Files changed 38 +124 -121
jeffreypicard commented 2022-08-04 21:10:36 +02:00 (Migrated from github.com)
Copy link
  • Changes to the codebase for the second repo rename.
  • Updates to the ci/cd scripts and docker files for static builds
* Changes to the codebase for the second repo rename. * Updates to the ci/cd scripts and docker files for static builds
lyoshenka (Migrated from github.com) reviewed 2022-08-04 21:10:36 +02:00
moodyjon (Migrated from github.com) reviewed 2022-08-04 22:31:03 +02:00
moodyjon (Migrated from github.com) left a comment
Copy link

The issue with "go build" producing herald.go is a problem because it has a name like a source file. Could we rename the repository a second time to "go-herald" or "herald-go"?

The issue with "go build" producing herald.go is a problem because it has a name like a source file. Could we rename the repository a second time to "go-herald" or "herald-go"?
docker/Dockerfile
@ -4,7 +4,7 @@ EXPOSE 50051
RUN mkdir /app
WORKDIR /app
COPY . /app
moodyjon (Migrated from github.com) commented 2022-08-04 22:07:07 +02:00
Copy link

Should this be changed also? It looks like it would be building herald.go at line #7.

See also https://github.com/lbryio/herald.go/blob/master/docker/Dockerfile.action where there is some commented out reference to "/hub".

Should this be changed also? It looks like it would be building herald.go at line #7. See also https://github.com/lbryio/herald.go/blob/master/docker/Dockerfile.action where there is some commented out reference to "/hub".
go.mod
@ -1,4 +1,4 @@
module github.com/lbryio/herald
module github.com/lbryio/herald.go
moodyjon (Migrated from github.com) commented 2022-08-04 22:27:14 +02:00
Copy link

I'm not sure about this, but I thing think is what controls the default output file (-o) for "go build".

Now that I think about it, having the binary be named "herald.go" is a potential source of confusion. Name looks like it could be a .go source file which you might open.

I'm not sure about this, but I thing think is what controls the default output file (-o) for "go build". Now that I think about it, having the binary be named "herald.go" is a potential source of confusion. Name looks like it could be a .go source file which you might open.
protobuf/go/result.pb.go
moodyjon (Migrated from github.com) commented 2022-08-04 22:03:08 +02:00
Copy link

Is this changing because build.sh is downloading a different version of protoc-gen-go-grpc?

Stuff in lbryio/types has not changed much recently.

Is this changing because build.sh is downloading a different version of protoc-gen-go-grpc? Stuff in lbryio/types has not changed much recently.
scripts/version.py
@ -31,3 +31,2 @@
os.system(cmd)
with open("./hub", "rb") as f:
release.upload_asset("binary", "hub", f)
with open("./herald", "rb") as f:
moodyjon (Migrated from github.com) commented 2022-08-04 22:13:18 +02:00
Copy link

Another /hub reference. Should be /herald or /herald.go.

Another /hub reference. Should be /herald or /herald.go.
jeffreypicard (Migrated from github.com) reviewed 2022-08-05 14:41:44 +02:00
go.mod
@ -1,4 +1,4 @@
module github.com/lbryio/herald
module github.com/lbryio/herald.go
jeffreypicard (Migrated from github.com) commented 2022-08-05 14:41:43 +02:00
Copy link

Yeah, this is definitely a problem, you're right there's confusion after the herald.go is generate.

Yeah, this is definitely a problem, you're right there's confusion after the herald.go is generate.
jeffreypicard commented 2022-08-05 14:42:33 +02:00 (Migrated from github.com)
Copy link

The issue with "go build" producing herald.go is a problem because it has a name like a source file. Could we rename the repository a second time to "go-herald" or "herald-go"?

We've already renamed it twice haha, I think this time was being X.go is the standard naming convention, so we'll just have to figure out how to fix the binary at this point I think.

> The issue with "go build" producing herald.go is a problem because it has a name like a source file. Could we rename the repository a second time to "go-herald" or "herald-go"? We've already renamed it twice haha, I think this time was being X.go is the standard naming convention, so we'll just have to figure out how to fix the binary at this point I think.
jeffreypicard (Migrated from github.com) reviewed 2022-08-05 14:43:33 +02:00
protobuf/go/result.pb.go
jeffreypicard (Migrated from github.com) commented 2022-08-05 14:43:33 +02:00
Copy link

Yes, I believe so. Perhaps also due to the move to go 1.18. Let's talk about which direction we want to sync these up in in the call.

Yes, I believe so. Perhaps also due to the move to go 1.18. Let's talk about which direction we want to sync these up in in the call.
jeffreypicard (Migrated from github.com) reviewed 2022-08-05 16:32:29 +02:00
docker/Dockerfile
@ -4,7 +4,7 @@ EXPOSE 50051
RUN mkdir /app
WORKDIR /app
COPY . /app
jeffreypicard (Migrated from github.com) commented 2022-08-05 16:32:28 +02:00
Copy link

Yup, good catch.

Yup, good catch.
moodyjon commented 2022-08-08 16:02:10 +02:00 (Migrated from github.com)
Copy link

Looks good. Only open question is why the .pb.go files changed.

Looks good. Only open question is why the .pb.go files changed.
jeffreypicard commented 2022-08-09 13:42:16 +02:00 (Migrated from github.com)
Copy link

Looks good. Only open question is why the .pb.go files changed.

So I think it's a moot point now actually, he package name in the .proto had to change anyways actually so it had to change the generated files. I'm going to merge this, pull in your change from the other one, and then cut a new version.

> Looks good. Only open question is why the .pb.go files changed. So I think it's a moot point now actually, he package name in the .proto had to change anyways actually so it had to change the generated files. I'm going to merge this, pull in your change from the other one, and then cut a new version.
Sign in to join this conversation.
Reviewers
No reviewers
lyoshenka
Labels
Clear labels   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
documentation

Improvements or additions to documentation

  
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

No labels
consider soon
documentation
good first issue
hacktoberfest
help wanted
priority: blocker
priority: high
priority: low
priority: medium
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/herald.go#47
No description provided.
Delete branch "herald.go"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?