Herald.go #47
No reviewers
Labels
No labels
consider soon
documentation
good first issue
hacktoberfest
help wanted
priority: blocker
priority: high
priority: low
priority: medium
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/herald.go#47
Loading…
Reference in a new issue
No description provided.
Delete branch "herald.go"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The issue with "go build" producing herald.go is a problem because it has a name like a source file. Could we rename the repository a second time to "go-herald" or "herald-go"?
@ -4,7 +4,7 @@ EXPOSE 50051
RUN mkdir /app
WORKDIR /app
COPY . /app
Should this be changed also? It looks like it would be building herald.go at line #7.
See also https://github.com/lbryio/herald.go/blob/master/docker/Dockerfile.action where there is some commented out reference to "/hub".
@ -1,4 +1,4 @@
module github.com/lbryio/herald
module github.com/lbryio/herald.go
I'm not sure about this, but I thing think is what controls the default output file (-o) for "go build".
Now that I think about it, having the binary be named "herald.go" is a potential source of confusion. Name looks like it could be a .go source file which you might open.
Is this changing because build.sh is downloading a different version of protoc-gen-go-grpc?
Stuff in lbryio/types has not changed much recently.
@ -31,3 +31,2 @@
os.system(cmd)
with open("./hub", "rb") as f:
release.upload_asset("binary", "hub", f)
with open("./herald", "rb") as f:
Another /hub reference. Should be /herald or /herald.go.
@ -1,4 +1,4 @@
module github.com/lbryio/herald
module github.com/lbryio/herald.go
Yeah, this is definitely a problem, you're right there's confusion after the herald.go is generate.
We've already renamed it twice haha, I think this time was being X.go is the standard naming convention, so we'll just have to figure out how to fix the binary at this point I think.
Yes, I believe so. Perhaps also due to the move to go 1.18. Let's talk about which direction we want to sync these up in in the call.
@ -4,7 +4,7 @@ EXPOSE 50051
RUN mkdir /app
WORKDIR /app
COPY . /app
Yup, good catch.
Looks good. Only open question is why the .pb.go files changed.
So I think it's a moot point now actually, he package name in the .proto had to change anyways actually so it had to change the generated files. I'm going to merge this, pull in your change from the other one, and then cut a new version.