LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Projects Releases 14 Packages Wiki Activity

Herald.go #47

Merged
jeffreypicard merged 5 commits from herald.go into master 2022-08-09 13:43:02 +02:00
Conversation 3 Commits 5 Files changed 38 +5 -6
3 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit a5f300d9f7 - Show all commits

6
docker/Dockerfile
View file

@ -4,7 +4,7 @@ EXPOSE 50051
RUN mkdir /app
WORKDIR /app
COPY . /app
moodyjon commented 2022-08-04 22:07:07 +02:00 (Migrated from github.com)
Review
Copy link

Should this be changed also? It looks like it would be building herald.go at line #7.

See also https://github.com/lbryio/herald.go/blob/master/docker/Dockerfile.action where there is some commented out reference to "/hub".

Should this be changed also? It looks like it would be building herald.go at line #7. See also https://github.com/lbryio/herald.go/blob/master/docker/Dockerfile.action where there is some commented out reference to "/hub".
jeffreypicard commented 2022-08-05 16:32:28 +02:00 (Migrated from github.com)
Review
Copy link

Yup, good catch.

Yup, good catch.
RUN go build
RUN go build -o herald .
FROM alpine:latest
COPY --from=stage1 /app/hub /hub
ENTRYPOINT ["/herald.go", "serve"]
COPY --from=stage1 /app/herald /herald
ENTRYPOINT ["/herald", "serve"]

2
scripts/build_and_push.sh
View file

@ -22,7 +22,7 @@ echo "using tag $LATEST_TAG"
git checkout "$LATEST_TAG"
# CGO_ENABLED=0 go build -v -ldflags "-X ${IMPORT_PATH}/meta.Version=${VERSION}"
go build -v -ldflags "-X ${IMPORT_PATH}/meta.Version=${VERSION}"
go build -o herald -v -ldflags "-X ${IMPORT_PATH}/meta.Version=${VERSION}"
docker build . -t lbry/herald.go:latest
docker tag lbry/herald.go:latest lbry/herald.go:"$LATEST_TAG"
docker push lbry/herald.go:latest

3
scripts/build_and_test.sh
View file

@ -1,6 +1,5 @@
#!/bin/bash
./protobuf/build.sh
go version
go build .
rm herald.go
go build -o herald .
go test -v -race -cover ./...