Add element type param T to SlicedBacked[T]. Require T satisfy #56
No reviewers
Labels
No labels
consider soon
documentation
good first issue
hacktoberfest
help wanted
priority: blocker
priority: high
priority: low
priority: medium
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/herald.go#56
Loading…
Reference in a new issue
No description provided.
Delete branch "slicebacked_type_param"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add element type param T to SlicedBacked[T]. Require T satisfy constraints.Ordered to make BisectRight() statically type-safe.
Found this working on the RPCs. I want to use
db.TxCounts
to lookup the height of a TXO. (And I don't have two txcounts, just one). While changing the argument/return signature, I added a type param.We should figure out why the unit tests don't run automatically for PRs from other repos, or if you have the permissions you could just make branches in our repo and I think then they'll trigger properly.
Otherwise this looks good, I like taking advantage of these features.