LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Projects Releases 14 Packages Wiki Activity

WIP: Resolve json rpc #57

Merged
jeffreypicard merged 8 commits from resolve-json-rpc into master 2022-09-07 20:36:07 +02:00
Conversation 0 Commits 8 Files changed 11 +127 -10
jeffreypicard commented 2022-09-05 17:24:46 +02:00 (Migrated from github.com)
Copy link
No description provided.
lyoshenka (Migrated from github.com) reviewed 2022-09-05 17:24:46 +02:00
moodyjon (Migrated from github.com) requested changes 2022-09-06 21:27:06 +02:00
requirements.txt
@ -0,0 +13,4 @@
requests==2.28.1
six==1.16.0
uritemplate==4.1.1
urllib3==1.26.11
moodyjon (Migrated from github.com) commented 2022-09-06 21:24:23 +02:00
Copy link

Is this needed by scripts/version.py? Did it get created inadvertently?

Is this needed by scripts/version.py? Did it get created inadvertently?
server/jsonrpc_service.go
moodyjon (Migrated from github.com) commented 2022-09-06 21:12:56 +02:00
Copy link

JSON port number should be a new thing in args.go, defaulting to 50001.

Then pass the args struct (or json parts of it) into StartJsonRPC111().

JSON port number should be a new thing in args.go, defaulting to 50001. Then pass the args struct (or json parts of it) into StartJsonRPC111().
test_rpc.sh
moodyjon (Migrated from github.com) commented 2022-09-06 21:24:59 +02:00
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard (Migrated from github.com) reviewed 2022-09-07 07:16:47 +02:00
requirements.txt
@ -0,0 +13,4 @@
requests==2.28.1
six==1.16.0
uritemplate==4.1.1
urllib3==1.26.11
jeffreypicard (Migrated from github.com) commented 2022-09-07 07:16:46 +02:00
Copy link

Yes, this is needed by the version.py, it was intentional.

Yes, this is needed by the version.py, it was intentional.
jeffreypicard (Migrated from github.com) reviewed 2022-09-07 07:17:25 +02:00
server/jsonrpc_service.go
jeffreypicard (Migrated from github.com) commented 2022-09-07 07:17:25 +02:00
Copy link

Yup, I just added that. It's already carried in through the Server struct.

Yup, I just added that. It's already carried in through the Server struct.
jeffreypicard (Migrated from github.com) reviewed 2022-09-07 07:18:11 +02:00
test_rpc.sh
jeffreypicard (Migrated from github.com) commented 2022-09-07 07:18:11 +02:00
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
moodyjon (Migrated from github.com) approved these changes 2022-09-07 20:17:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lyoshenka
moodyjon
Labels
Clear labels   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
documentation

Improvements or additions to documentation

  
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

No labels
consider soon
documentation
good first issue
hacktoberfest
help wanted
priority: blocker
priority: high
priority: low
priority: medium
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/herald.go#57
No description provided.
Delete branch "resolve-json-rpc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?