LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Projects Releases 14 Packages Wiki Activity

WIP: Resolve json rpc #57

Merged
jeffreypicard merged 8 commits from resolve-json-rpc into master 2022-09-07 20:36:07 +02:00
Conversation 0 Commits 8 Files changed 11 -10
1 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 040bb78f06 - Show all commits

10
test_rpc.sh
View file

@ -1,10 +0,0 @@
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
#!/bin/bash
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
curl --request POST 'localhost:8686/' \
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
--http1.1 \
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
--header 'Content-Type: application/json' \
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
--data-raw '{
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
"jsonrpc":"2.0",
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
"method":"resolve",
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
"params":{"data": "asdf"},
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
"id":1
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.
}'
moodyjon commented 2022-09-06 21:24:59 +02:00 (Migrated from github.com)
Review
Copy link

Where does this port number come from? I would expect to see 8080 (or 50001)

Also does this need "/rpc" to match line 45 of jsonrpc_service.go?

I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).

Where does this port number come from? I would expect to see 8080 (or 50001) Also does this need "/rpc" to match line 45 of jsonrpc_service.go? I haven't been able to determine whether (Python) herald uses "/rpc" or any other path(s).
jeffreypicard commented 2022-09-07 07:18:11 +02:00 (Migrated from github.com)
Review
Copy link

This is an old script added in by mistake, I'll move and change it.

This is an old script added in by mistake, I'll move and change it.