LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Packages Projects Releases 14 Wiki Activity

WIP: Server xxx endpoints #68

Closed
jeffreypicard wants to merge 3 commits from server-xxx-endpoints into master
pull from: server-xxx-endpoints
merge into: LBRYCommunity:master
Conversation 0 Commits 3 Files changed 10 +290 -112
jeffreypicard commented 2022-10-12 11:56:43 +02:00 (Migrated from github.com)
Copy link
No description provided.
moodyjon (Migrated from github.com) reviewed 2022-10-12 17:51:45 +02:00
server/args.go
moodyjon (Migrated from github.com) commented 2022-10-12 17:51:45 +02:00
Copy link

This should be derived from "chain" param (mainnet, testnet, ...). See chaincfg.MainNetParams, chaincfg.TestNet3Params, etc.

The place to decide this is in MakeHubServer() where it the final value of chain is derived from dbChain and cliChain.

This should be derived from "chain" param (mainnet, testnet, ...). See `chaincfg.MainNetParams`, `chaincfg.TestNet3Params`, etc. The place to decide this is in `MakeHubServer()` where it the final value of `chain` is derived from `dbChain` and `cliChain`.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
documentation

Improvements or additions to documentation

  
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

No labels
consider soon
documentation
good first issue
hacktoberfest
help wanted
priority: blocker
priority: high
priority: low
priority: medium
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/herald.go#68
No description provided.
Delete branch "server-xxx-endpoints"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?