Elasticsearch and elastic sync notifier failover (WIP) #95

2022-09-19T16:17:06+02:00

jackrobison commented

2022-09-19 16:17:06 +02:00

(Migrated from github.com)

No description provided.

github-advanced-security[bot] (Migrated from github.com) reviewed 2022-09-19 16:22:32 +02:00

					
				@ -2,2 +2,4 @@

				from collections import deque

				from hub.env import Env

				ELASTIC_SERVICES_REGEX = re.compile("(([\d|\.]|[^,:\/])*:\d*\/([\d|\.]|[^,:\/])*:\d*,?)*")

github-advanced-security[bot] (Migrated from github.com) commented

2022-09-19 16:22:32 +02:00

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings containing many repetitions of '.'.

Show more details

## Inefficient regular expression This part of the regular expression may cause exponential backtracking on strings containing many repetitions of '.'. [Show more details](https://github.com/lbryio/hub/security/code-scanning/2)

github-advanced-security[bot] (Migrated from github.com) commented

2022-09-19 16:22:32 +02:00

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with ':/' and containing many repetitions of '.'.

Show more details

## Inefficient regular expression This part of the regular expression may cause exponential backtracking on strings starting with ':/' and containing many repetitions of '.'. [Show more details](https://github.com/lbryio/hub/security/code-scanning/3)

moodyjon (Migrated from github.com) reviewed 2022-09-19 23:59:32 +02:00

hub/herald/service.py

moodyjon (Migrated from github.com) commented

2022-09-19 23:59:31 +02:00

This pattern won't work for the latest Python versions. CancelledError is derived from BaseException.

... a minor thing given the only thing done in the else branch is logging ("stopping the notifier...").

This pattern won't work for the latest Python versions. CancelledError is derived from BaseException. ... a minor thing given the only thing done in the else branch is logging ("stopping the notifier...").

jackrobison commented

2022-11-09 17:09:24 +01:00

(Migrated from github.com)

This is included in https://github.com/lbryio/hub/pull/109

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/hub#95