LBRYCommunity/lbcd
1
0
Fork 0
Code Issues 17 Pull requests 4 Projects Releases 28 Packages Wiki Activity

Make profiling easier to follow with static dispatch.

Browse source 
For example, when performing a heap profile, this:

         .          .    125:   fetchFunc := db.FetchUnSpentTxByShaList
         .          .    126:   if includeSpent {
         .          .    127:           fetchFunc = db.FetchTxByShaList
         .          .    128:   }
         .     9.11MB    129:   txReplyList := fetchFunc(txList)

Now becomes this:

         .          .    125:   var txReplyList []*database.TxListReply
         .          .    126:   if includeSpent {
         .          .    127:           txReplyList = db.FetchTxByShaList(txList)
         .          .    128:   } else {
         .     8.75MB    129:           txReplyList = db.FetchUnSpentTxByShaList(txList)
         .          .    130:   }

And it's clear where the majority of our allocations are coming from.
This commit is contained in:
Josh Rickmar 2015-02-06 20:04:57 -05:00 • committed by Dave Collins
parent 2713c8528d
commit fc8dae49e4
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
blockchain/txlookup.go
View file

@ -122,11 +122,12 @@ func fetchTxStoreMain(db database.Db, txSet map[wire.ShaHash]struct{}, includeSp
// will return the information from the point of view of the end of the // will return the information from the point of view of the end of the
// main chain. Choose whether or not to include fully spent // main chain. Choose whether or not to include fully spent
// transactions depending on the passed flag. // transactions depending on the passed flag.
fetchFunc := db.FetchUnSpentTxByShaList var txReplyList []*database.TxListReply
if includeSpent { if includeSpent {
fetchFunc = db.FetchTxByShaList txReplyList = db.FetchTxByShaList(txList)
} else {
txReplyList = db.FetchUnSpentTxByShaList(txList)
} }
txReplyList := fetchFunc(txList)
for _, txReply := range txReplyList { for _, txReply := range txReplyList {
// Lookup the existing results entry to modify. Skip // Lookup the existing results entry to modify. Skip
// this reply if there is no corresponding entry in // this reply if there is no corresponding entry in