LBRYCommunity/lbcd

Fork 0

Relax witness size checking #103

Open

roylee17 wants to merge 2 commits from relax-witness-size-checking into master

roylee17 commented

2023-05-02 06:06:44 +02:00

(Migrated from github.com)

this is a response to @nikooo777's inqury about CVE-2022-44797
and CVE-2022-39389

At the moment, I don't have enough bandwidth to further investigate if lbcd is impacted, but it seems fine as we only have two implementations (lbcd and lbrycrd), and both have the same witness-size-checking.

this is a response to @nikooo777's inqury about [CVE-2022-44797](https://devhub.checkmarx.com/cve-details/CVE-2022-44797/?utm_source=jetbrains&utm_medium=referral&utm_campaign=goland&utm_term=go) and [CVE-2022-39389](https://devhub.checkmarx.com/cve-details/CVE-2022-39389/?utm_source=jetbrains&utm_medium=referral&utm_campaign=goland&utm_term=go) At the moment, I don't have enough bandwidth to further investigate if lbcd is impacted, but it seems fine as we only have two implementations (lbcd and lbrycrd), and both have the same witness-size-checking.

coveralls commented

2023-05-02 06:11:00 +02:00

(Migrated from github.com)

Pull Request Test Coverage Report for Build 4857496858

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 51.09%

Files with Coverage Reduction	New Missed Lines	%
peer/peer.go	8	75.14%

Totals
Change from base Build 3534043008:	-0.02%
Covered Lines:	22490
Relevant Lines:	44020

💛 - Coveralls

## Pull Request Test Coverage Report for [Build 4857496858](https://coveralls.io/builds/59507874) * **3** of **3** **(100.0%)** changed or added relevant lines in **1** file are covered. * **8** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.02%**) to **51.09%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-----|--------------|--: | | [peer/peer.go](https://coveralls.io/builds/59507874/source?filename=peer%2Fpeer.go#L1316) | 8 | 75.14% |  | Totals | [![Coverage Status](https://coveralls.io/builds/59507874/badge)](https://coveralls.io/builds/59507874) | | :-- | --: | | Change from base [Build 3534043008](https://coveralls.io/builds/54510124): | -0.02% | | Covered Lines: | 22490 | | Relevant Lines: | 44020 | --- ##### 💛 - [Coveralls](https://coveralls.io)

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin relax-witness-size-checking:relax-witness-size-checking

git checkout relax-witness-size-checking

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master

git merge --no-ff relax-witness-size-checking

git checkout relax-witness-size-checking

git rebase master

git checkout master

git merge --ff-only relax-witness-size-checking

git checkout relax-witness-size-checking

git rebase master

git checkout master

git merge --no-ff relax-witness-size-checking

git checkout master

git merge --squash relax-witness-size-checking

git checkout master

git merge --ff-only relax-witness-size-checking

git checkout master

git merge relax-witness-size-checking

git push origin master

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcd#103

No description provided.