LBRYCommunity/lbcwallet
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 14 Packages Wiki Activity

import: add support for watchonly addresses/pubkeys [WIP] #23

Closed
roylee17 wants to merge 1 commit from support-imported-watchonly-account into master
pull from: support-imported-watchonly-account
merge into: LBRYCommunity:master
Conversation 1 Commits 1 Files changed 4 +67 -22
roylee17 commented 2022-08-11 19:00:15 +02:00 (Migrated from github.com)
Copy link

Fix #18

Previously, lbcwallet treats all imported keys as "watchonly".
We had a hotfix to reverse it treating all imported as "non-watchonly",
which is actually the use cases of known users. (exchanges/pools)

This patch aims to addresses this issue more properly by supporting
"imported-watchonly" accounts, which managed all imported addresses
and public keys.

Fix #18 Previously, lbcwallet treats all imported keys as "watchonly". We had a hotfix to reverse it treating all imported as "non-watchonly", which is actually the use cases of known users. (exchanges/pools) This patch aims to addresses this issue more properly by supporting "imported-watchonly" accounts, which managed all imported addresses and public keys.
roylee17 commented 2022-09-28 20:31:39 +02:00 (Migrated from github.com)
Copy link

Abandon watch-only address/account support for now.

Abandon watch-only address/account support for now.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
mining

   
question

Further information is requested

  
rpc

   
ux

User experience

  
wallet

   
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
mining
question
rpc
ux
wallet
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbcwallet#23
No description provided.
Delete branch "support-imported-watchonly-account"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?