Hide floating wallet on the Channel fragment #1177

Merged

kekkyojin merged 2 commits from lbry-android-1054 into master

2021-03-29 17:38:51 +02:00

kekkyojin commented

2021-03-18 21:30:00 +01:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Bugfix

Fixes

Issue Number: #1054

What is the current behavior?

What is the new behavior?

Floating wallet will disappear on About and Comment tabs on the Channel fragment

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Bugfix ## Fixes Issue Number: #1054 ## What is the current behavior? ## What is the new behavior? Floating wallet will disappear on About and Comment tabs on the Channel fragment

akinwale (Migrated from github.com) approved these changes 2021-03-19 10:34:06 +01:00

akinwale (Migrated from github.com) left a comment

Looks good.

kekkyojin commented

2021-03-19 12:12:00 +01:00

(Migrated from github.com)

I am re-requesting a review because the new code seems a little bit different, although it is just because of the fact it is no longer using an anonymous object for the callback.

Yesterday at night I realized that I had to unrefister the callback for the viewpager. This new commit changes code so it is done when user exits the channel fragment. The unregister method needs to get the callback class, so it has been to be changed from anonymous to a regular instance of the class. I am re-requesting a review because the new code seems a little bit different, although it is just because of the fact it is no longer using an anonymous object for the callback.

akinwale (Migrated from github.com) approved these changes 2021-03-29 03:28:39 +02:00