Hide floating wallet on the Channel fragment #1177
No reviewers
Labels
No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-android#1177
Loading…
Reference in a new issue
No description provided.
Delete branch "lbry-android-1054"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #1054
What is the current behavior?
What is the new behavior?
Floating wallet will disappear on About and Comment tabs on the Channel fragment
Looks good.
Yesterday at night I realized that I had to unrefister the callback for the viewpager. This new commit changes code so it is done when user exits the channel fragment. The unregister method needs to get the callback class, so it has been to be changed from anonymous to a regular instance of the class.
I am re-requesting a review because the new code seems a little bit different, although it is just because of the fact it is no longer using an anonymous object for the callback.