Add setting to enable sending buffering events #993

Merged

kekkyojin merged 2 commits from setting-buffering-events into master

2020-08-28 11:06:42 +02:00

kekkyojin commented

2020-08-24 23:54:51 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number:

What is the current behavior?

Buffering events are sent to LBRY without user permission. User cannot disable this behavior. This makes Tracking AntiFeature to appear in FDroid store listing.

What is the new behavior?

No buffering event is sent to LBRY servers by default. User can enable this events to be sent at will. FDroid will not show the Tracking AntiFeature as user is in control of data being sent and the default is to not send it.

Other information

This is a change required to remove the Tracking AntiFeature from FDroid listing. This PR adds the Preference to upstream lbry-android with a default 'true' value. Then FDroid build script will change default to 'false' so no data is sent by default on the APK built by FDroid.

Translation on 1 new string will be required. Of course it could be reworded if LBRY teams requires it.

Any required change to the PR, just ask for it and I will commit a new rebased PR.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: ## What is the current behavior? Buffering events are sent to LBRY without user permission. User cannot disable this behavior. This makes Tracking AntiFeature to appear in FDroid store listing. ## What is the new behavior? No buffering event is sent to LBRY servers by default. User can enable this events to be sent at will. FDroid will not show the Tracking AntiFeature as user is in control of data being sent and the default is to not send it. ## Other information This is a change required to remove the Tracking AntiFeature from FDroid listing. This PR adds the Preference to upstream lbry-android with a default 'true' value. Then FDroid build script will change default to 'false' so no data is sent by default on the APK built by FDroid. Translation on 1 new string will be required. Of course it could be reworded if LBRY teams requires it. Any required change to the PR, just ask for it and I will commit a new rebased PR.

kekkyojin commented

2020-08-26 19:30:26 +02:00

(Migrated from github.com)

This second commit uses consistently true as the default value. It also avoids a possible regression bug when it is unable to get the context ctx == null, so being the variable false, the event would not be sent.

This second commit uses consistently `true` as the default value. It also avoids a possible regression bug when it is unable to get the context `ctx == null`, so being the variable false, the event would not be sent.

akinwale (Migrated from github.com) approved these changes 2020-08-28 11:06:25 +02:00