Add setting to enable sending buffering events #993
No reviewers
Labels
No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-android#993
Loading…
Reference in a new issue
No description provided.
Delete branch "setting-buffering-events"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number:
What is the current behavior?
Buffering events are sent to LBRY without user permission. User cannot disable this behavior. This makes Tracking AntiFeature to appear in FDroid store listing.
What is the new behavior?
No buffering event is sent to LBRY servers by default. User can enable this events to be sent at will. FDroid will not show the Tracking AntiFeature as user is in control of data being sent and the default is to not send it.
Other information
This is a change required to remove the Tracking AntiFeature from FDroid listing. This PR adds the Preference to upstream lbry-android with a default 'true' value. Then FDroid build script will change default to 'false' so no data is sent by default on the APK built by FDroid.
Translation on 1 new string will be required. Of course it could be reworded if LBRY teams requires it.
Any required change to the PR, just ask for it and I will commit a new rebased PR.
This second commit uses consistently
true
as the default value. It also avoids a possible regression bug when it is unable to get the contextctx == null
, so being the variable false, the event would not be sent.Looks good. Thanks.