PR cleanup #1164

Merged
akinwale merged 32 commits from pr-1118 into master 2021-03-08 20:15:23 +01:00

32 commits

Author SHA1 Message Date
Akinwale Ariwodola
37f4b6b273 update build.gradle 2021-03-08 20:12:36 +01:00
Akinwale Ariwodola
60983929b9 clean up PR 2021-03-08 20:06:41 +01:00
Patric Karlström
09d5db287d Simplify code 2021-01-13 16:26:43 +01:00
Patric Karlström
722438ba41 Add missing null check 2021-01-13 16:20:47 +01:00
Patric Karlström
e8f78baca0 Add TODO 2021-01-13 16:19:07 +01:00
Patric Karlström
4ffc054bdd cannot compare doubles with == sainly, switch to checking if difference is less than 0.000001 instead 2021-01-13 16:16:29 +01:00
Patric Karlström
e18a740b20 Add missing null check 2021-01-13 16:11:37 +01:00
Patric Karlström
b002621861 add missing null check 2021-01-13 16:07:43 +01:00
Patric Karlström
da8ca05a38 Remove unused imports 2021-01-13 16:05:21 +01:00
Patric Karlström
2e026a6920 Unnecessecary semicolons 2021-01-13 15:37:08 +01:00
Patric Karlström
5879cbd3db context does not need null check 2021-01-13 15:36:17 +01:00
Patric Karlström
40b6591bb0 Simplify code for readability 2021-01-13 15:34:58 +01:00
Patric Karlström
49a3d157ee Simplify code for return value 2021-01-13 15:34:31 +01:00
Patric Karlström
3ca7d9b369 Use StandardCharsets.UTF_8 instead of string UTF8 2021-01-13 15:33:31 +01:00
Patric Karlström
e49b7b6776 use contains instead of indexOf 2021-01-13 15:32:39 +01:00
Patric Karlström
1ca2b92855 Add todo for MediaStore.Video.Media.DURATION that requires API level 29 2021-01-13 15:19:56 +01:00
Patric Karlström
62dbfed1a3 A couple more fields that can be final 2021-01-13 15:19:18 +01:00
Patric Karlström
fd5ffb1e50 Set gradle version to static 3.6.4 instead of dynamic 3.+ 2021-01-13 15:07:18 +01:00
Patric Karlström
1eed13e889 Bump buildToolsVersion 29.0.1 -> 29.0.2 for FDroid build compability 2021-01-13 15:00:11 +01:00
Patric Karlström
962cfda206 Downgrade from gradle-6.5 to 6.1.1 due to FDroid not compatible with 6.5 2021-01-12 20:06:02 +01:00
Patric Karlström
b9251c2036 code cleanup, make newInstance use final variables for listener and claim 2021-01-12 17:26:04 +01:00
Patric Karlström
c95f25b584 Change minSdkVersion from 21 to 24 since isInPictureInPictureMode requires 24 2021-01-12 16:51:33 +01:00
Patric Karlström
ac098c4062 Upgrade sdkVersion from 29 -> 30 2021-01-12 16:23:33 +01:00
Patric Karlström
dc6b218834 Upgrade gradle 5.6.4 -> 6.5 2021-01-12 16:23:28 +01:00
Patric Karlström
35d448c601 code-cleanup. Make non-changing variables final 2021-01-12 16:18:31 +01:00
Patric Karlström
e0bf54c304 simplify code for readability, no need for null check before instanceof check 2021-01-12 16:18:31 +01:00
Patric Karlström
d39952e048 simplify code for readability, stringbuilder is overkill 2021-01-12 16:18:31 +01:00
Patric Karlström
8c9a1a396a simplify code for readability 2021-01-12 16:18:31 +01:00
Patric Karlström
a261a62584 fix check for claims 2021-01-12 16:18:31 +01:00
Patric Karlström
49dee407c8 No need for null check before instanceof 2021-01-12 16:18:31 +01:00
Patric Karlström
6c5144e323 Simplify code, not needed to check if collection contains key before trying to remove it 2021-01-12 16:18:31 +01:00
Patric Karlström
258ea4aff6 FirebaseAnalytics needs ACCESS_NETWORK_STATE permission 2021-01-12 16:18:31 +01:00