Don't show link to Bittrex #1181

Merged

kekkyojin merged 1 commit from faq-exchanges into master

2021-04-12 18:54:00 +02:00

kekkyojin commented

2021-04-09 12:58:24 +02:00

(Migrated from github.com)

This fix uses two services:

The geolocation API service from LBRY for filtering users not on North-America
IP-API.com service when the LBRY service returns user is in North-America

This way users not on North-America won't see their IPs sent to a third-party provider.

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Bugfix

Fixes

Issue Number: #1179

What is the current behavior?

For IPs on the US, users are shown a message about using Bittrex to exchange LBRY Credits to USD. Bittrex is no longer allowing that for users in the US, but LBRY Android users are going to see the message

What is the new behavior?

Message is not being shown

Other information

By default, the message is not shown. Then, depending on the IP of the user, it is programmatically made visible. Network requests are using Java Future, because AsyncTask is now deprecated and Java Future works on all supported Android API levels.

This fix uses two services: - The geolocation API service from LBRY for filtering users not on North-America - IP-API.com service when the LBRY service returns user is in North-America This way users not on North-America won't see their IPs sent to a third-party provider. ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Bugfix ## Fixes Issue Number: #1179 ## What is the current behavior? For IPs on the US, users are shown a message about using Bittrex to exchange LBRY Credits to USD. Bittrex is no longer allowing that for users in the US, but LBRY Android users are going to see the message ## What is the new behavior? Message is not being shown ## Other information By default, the message is not shown. Then, depending on the IP of the user, it is programmatically made visible. Network requests are using Java Future, because AsyncTask is now deprecated and Java Future works on all supported Android API levels.

akinwale (Migrated from github.com) approved these changes 2021-04-12 18:32:47 +02:00