LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues 155 Pull requests 6 Projects Releases 84 Packages Wiki Activity

I've added a menu to share when long-pressing a video #1222

Open
veritaslogix wants to merge 2 commits from veritaslogix/09.29.2021-popup_menu into master
pull from: veritaslogix/09.29.2021-popup_menu
merge into: LBRYCommunity:master
Conversation 5 Commits 2 Files changed 3 +111
veritaslogix commented 2021-09-29 13:22:25 +02:00 (Migrated from github.com)
Copy link

Hi there!
I'm working on issue #1133 (https://github.com/lbryio/lbry-android/issues/1133)

So far, it's going well. However, there's quite a few ways to implement a menu after a long press. Signal Messenger has a cool UI for when users long click on a message. But other apps like NewPipe just use a dialog to display other options.

To keep things simple, I used a popup menu. I added other menu items that you'd see in the FileViewFragment (download, repost, etc.). I added these because only putting "share" in the menu didn't seem like much of a menu.

(Right now, "Share" is the only menu item that actually works.) Before I keep going, I was looking for some feedback on what I've done so far.

Thanks :)

[PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.]

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 1133

What is the current behavior?: Users have to click on a video to use options like sharing

What is the new behavior?: I added a menu so that when users click on a video they can share it without actually clicking on it

Other information

Hi there! I'm working on issue #1133 (https://github.com/lbryio/lbry-android/issues/1133) So far, it's going well. However, there's quite a few ways to implement a menu after a long press. Signal Messenger has a cool UI for when users long click on a message. But other apps like NewPipe just use a dialog to display other options. To keep things simple, I used a popup menu. I added other menu items that you'd see in the FileViewFragment (download, repost, etc.). I added these because only putting "share" in the menu didn't seem like much of a menu. (Right now, "Share" is the only menu item that actually works.) Before I keep going, I was looking for some feedback on what I've done so far. Thanks :) [PS, I submitted an application to LBRY for an android engineer position on September 9, 2021. This PR is part of my application process.] ## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: 1133 ## What is the current behavior?: Users have to click on a video to use options like sharing ## What is the new behavior?: I added a menu so that when users click on a video they can share it without actually clicking on it ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
kekkyojin commented 2021-09-29 14:47:24 +02:00 (Migrated from github.com)
Copy link

Please, rebase your branch so it is a child from commit ca08f7, latest one you pulled from LBRY-android repository.

By adding a commit to your master branch and then creating a new branch from it, this PR includes that commit, which is unrelated to the feature you are trying to merge to lbry—android.

Then you will need to force-push to your remote. GitHub will likely update automatically this PR.

Please, rebase your branch so it is a child from commit ca08f7, latest one you pulled from LBRY-android repository. By adding a commit to your master branch and then creating a new branch from it, this PR includes that commit, which is unrelated to the feature you are trying to merge to lbry—android. Then you will need to force-push to your remote. GitHub will likely update automatically this PR.
👍 1
veritaslogix commented 2021-09-30 04:18:37 +02:00 (Migrated from github.com)
Copy link

Okay thanks! So, I've made a new branch to my master branch and rebased this branch to it. Did I understand what you wanted me to do correctly?

Okay thanks! So, I've made a new branch to my master branch and rebased this branch to it. Did I understand what you wanted me to do correctly?
kekkyojin commented 2021-10-01 00:31:39 +02:00 (Migrated from github.com)
Copy link

Run these commands one by one from master branch:

git checkout 09.29.2021-popup_menu
git rebase --onto ca08f71 159494

And then verify project still builds. Once code has built, run following command, using the id you have setup as your remote (use git remote to see it):

git push -f YOUR_REMOTE_HERE 09.29.2021-popup_menu

This will update your remote branch and GitHub will also show the forced-push and update the commits, now showing only two.

Run these commands one by one from master branch: git checkout 09.29.2021-popup_menu git rebase --onto ca08f71 159494 And then verify project still builds. Once code has built, run following command, using the id you have setup as your remote (use git remote to see it): git push -f YOUR_REMOTE_HERE 09.29.2021-popup_menu This will update your remote branch and GitHub will also show the forced-push and update the commits, now showing only two.
veritaslogix commented 2021-10-02 00:22:44 +02:00 (Migrated from github.com)
Copy link

@kekkyojin you are 100% radical. Thank you so much for helping me with that. I just ran those commands they worked perfectly! Thanks!

@kekkyojin you are 100% radical. Thank you so much for helping me with that. I just ran those commands they worked perfectly! Thanks!
veritaslogix commented 2021-10-02 00:29:20 +02:00 (Migrated from github.com)
Copy link

Please let me know if there's anything you need or if you'd like me to explain my choices in the changes I made.

Please let me know if there's anything you need or if you'd like me to explain my choices in the changes I made.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin veritaslogix/09.29.2021-popup_menu:veritaslogix/09.29.2021-popup_menu
git checkout veritaslogix/09.29.2021-popup_menu

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master
git merge --no-ff veritaslogix/09.29.2021-popup_menu
git checkout veritaslogix/09.29.2021-popup_menu
git rebase master
git checkout master
git merge --ff-only veritaslogix/09.29.2021-popup_menu
git checkout veritaslogix/09.29.2021-popup_menu
git rebase master
git checkout master
git merge --no-ff veritaslogix/09.29.2021-popup_menu
git checkout master
git merge --squash veritaslogix/09.29.2021-popup_menu
git checkout master
git merge --ff-only veritaslogix/09.29.2021-popup_menu
git checkout master
git merge veritaslogix/09.29.2021-popup_menu
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android: closed alpha

   
android: open beta

   
app-parity

   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
creator

   
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
product review

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#1222
No description provided.
Delete branch "veritaslogix/09.29.2021-popup_menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?