LBRYCommunity/lbry-docker

Fork 0

[Chainquery] implement HEALTHCHECK #59

New issue

Closed

opened 2019-04-26 01:00:56 +02:00 by Leopere · 8 comments

Leopere commented

2019-04-26 01:00:56 +02:00

(Migrated from github.com)

Eventually, we need boilerplate health checks for all of the containers shipped with the containers themselves.

dangarthwaite commented

2019-10-04 16:53:08 +02:00

(Migrated from github.com)

I'd like to take this. Although I believe the first healthcheck should be librycrd.
Is there something that can be curl'd in order to determine if chainquery [or librycrd] is ready?

I'd like to take this. Although I believe the first healthcheck should be librycrd. Is there something that can be curl'd in order to determine if chainquery [or librycrd] is ready?

dangarthwaite commented

2019-10-04 18:47:20 +02:00

(Migrated from github.com)

I see this in Dockerfile:

## TODO: Implement healthcheck.
# HEALTHCHECK ["healthcheck"]

/usr/bin/healthcheck is a script that relies on curl, which isn't installed. I'd like to take a stab getting it to work with lbrycrd-cli

I see this in Dockerfile: ``` ## TODO: Implement healthcheck. # HEALTHCHECK ["healthcheck"] ``` /usr/bin/healthcheck is a script that relies on curl, which isn't installed. I'd like to take a stab getting it to work with lbrycrd-cli

dangarthwaite commented

2019-10-04 23:03:16 +02:00

(Migrated from github.com)

I have a working patch for lbrycrd healthcheck. Let's see if I can get chainquery done tonight.

Leopere commented

2019-10-09 18:10:32 +02:00

(Migrated from github.com)

@dangarthwaite open some PR's!

dangarthwaite commented

2019-10-10 03:52:04 +02:00

(Migrated from github.com)

What does work are healthcheckers for lbrycrd and mysql containers that are in this PR. Also a rewrite of chainquery/start.sh that ought to be wire-compatible and a LOT easier on the eyes.

So - the actual healthcheck for chainquery is untested. A whole lot of other configuration files were tweaked to get lbrycrd running in regtest mode. In the end this ticket is blocked until https://github.com/lbryio/chainquery/issues/121 is fixed. `chainquery serve` gives an error when it starts. What does work are healthcheckers for lbrycrd and mysql containers that are in this PR. Also a rewrite of chainquery/start.sh that ought to be wire-compatible and a LOT easier on the eyes.

Leopere commented

2019-10-10 04:46:52 +02:00

(Migrated from github.com)

For the most part the Chainquery "healthcheck" in this case was just to make sure the process hadn't died and had completed it's initial boot process.

dangarthwaite commented

2019-10-10 15:33:32 +02:00

(Migrated from github.com)

I changed chainquery's Dockerfile to download the latest version. All three containers now have healthchecks.

dan@macbook:~/Projects/forks/lbry-docker
$ cd lbrycrd && docker-compose ps && cd ..
      Name          Command      State                                             Ports
------------------------------------------------------------------------------------------------------------------------------
lbrycrd_lbrycrd_1   start     Up (healthy)   11337/tcp, 0.0.0.0:11337->29245/tcp, 0.0.0.0:11336->29246/tcp, 9245/tcp, 9246/tcp
dan@macbook:~/Projects/forks/lbry-docker
$ cd chainquery && docker-compose ps && cd ..
         Name                       Command                State                     Ports
--------------------------------------------------------------------------------------------------------
chainquery_chainquery_1   start                         Up (healthy)   0.0.0.0:6300->6300/tcp
chainquery_mysql_1        docker-entrypoint.sh mysqld   Up (healthy)   0.0.0.0:3306->3306/tcp, 33060/tcp

I changed chainquery's Dockerfile to download the latest version. All three containers now have healthchecks. ``` dan@macbook:~/Projects/forks/lbry-docker $ cd lbrycrd && docker-compose ps && cd .. Name Command State Ports ------------------------------------------------------------------------------------------------------------------------------ lbrycrd_lbrycrd_1 start Up (healthy) 11337/tcp, 0.0.0.0:11337->29245/tcp, 0.0.0.0:11336->29246/tcp, 9245/tcp, 9246/tcp dan@macbook:~/Projects/forks/lbry-docker $ cd chainquery && docker-compose ps && cd .. Name Command State Ports -------------------------------------------------------------------------------------------------------- chainquery_chainquery_1 start Up (healthy) 0.0.0.0:6300->6300/tcp chainquery_mysql_1 docker-entrypoint.sh mysqld Up (healthy) 0.0.0.0:3306->3306/tcp, 33060/tcp ```

Leopere commented

2019-10-10 17:42:19 +02:00

(Migrated from github.com)

Fixed by #87

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-docker#59

No description provided.