LBRYCommunity/lbry-fdroid
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity

Add setting to enable sending buffering events #2

Closed
kekkyojin wants to merge 1 commit from buffer-analytics-setting into master
pull from: buffer-analytics-setting
merge into: LBRYCommunity:master
Conversation 2 Commits 1 Files changed 4 +16 -1
kekkyojin commented 2020-08-03 10:11:57 +02:00 (Migrated from github.com)
Copy link

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 1

What is the current behavior?

Buffering events are sent to LBRY without user permission. User cannot disable this behavior. This makes Tracking AntiFeature to appear in FDroid store listing.

What is the new behavior?

No buffering event is sent to LBRY servers by default. User can enable this events to be sent at will. FDroid will not show the Tracking AntiFeature as user is in control of data being sent and the default is to not send it.

Other information

I am creating this PR so it could be reviewed by another person different than mine -which could spot any potential new bug-. This PR has also been created here instead of upstream because the problem is about FDroid, so it seems more logical to make modifications here.

EDIT: translation on 1 new string will be required. Of course it could be reworded if LBRY teams requires it.

I will leave it as it is until reviewer accepts the modifications or LBRY team gives explicit consent to merge it. If a new tagged release appears in lbry-android and this hasn't been merged yet, I will request for permission to merge it.

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: 1 ## What is the current behavior? Buffering events are sent to LBRY without user permission. User cannot disable this behavior. This makes Tracking AntiFeature to appear in FDroid store listing. ## What is the new behavior? No buffering event is sent to LBRY servers by default. User can enable this events to be sent at will. FDroid will not show the Tracking AntiFeature as user is in control of data being sent and the default is to not send it. ## Other information I am creating this PR so it could be reviewed by another person different than mine -which could spot any potential new bug-. This PR has also been created here instead of upstream because the problem is about FDroid, so it seems more logical to make modifications here. EDIT: translation on 1 new string will be required. Of course it could be reworded if LBRY teams requires it. I will leave it as it is until reviewer accepts the modifications or LBRY team gives explicit consent to merge it. If a new tagged release appears in lbry-android and this hasn't been merged yet, I will request for permission to merge it. <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
akinwale (Migrated from github.com) reviewed 2020-08-03 10:11:57 +02:00
kekkyojin commented 2020-08-23 18:25:22 +02:00 (Migrated from github.com)
Copy link

Could this be merged to be released along 0.16.0 on F-Droid, @akinwale? Or is it better to leave it for another future release?

Could this be merged to be released along 0.16.0 on F-Droid, @akinwale? Or is it better to leave it for another future release?
kekkyojin commented 2020-08-24 23:56:06 +02:00 (Migrated from github.com)
Copy link

Closed as it has been moved to upstream lbry-android repository PR 993

Closed as it has been moved to upstream lbry-android repository PR 993

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
akinwale
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-fdroid#2
No description provided.
Delete branch "buffer-analytics-setting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?