LBRYCommunity/lbry-fdroid
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity

Updated Readme for F-droid #5

Closed
iamflorencejay wants to merge 2 commits from patch-1 into master
pull from: patch-1
merge into: LBRYCommunity:master
Conversation 0 Commits 2 Files changed 1 +2 -2
iamflorencejay commented 2020-11-14 03:28:37 +01:00 (Migrated from github.com)
Copy link

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Readme.md

What is the current behavior?

What is the new behavior?

Other information

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [x] Documentation changes - [ ] Other - Please describe: ## Fixes Readme.md ## What is the current behavior? ## What is the new behavior? ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
kekkyojin (Migrated from github.com) reviewed 2020-11-14 06:20:16 +01:00
README.md
@ -1,13 +1,13 @@
# LBRY Android
# LBRY F-Droid
[![pipeline status](https://ci.lbry.tech/lbry/lbry-android/badges/master/pipeline.svg)](https://ci.lbry.tech/lbry/lbry-android/commits/master)
kekkyojin (Migrated from github.com) commented 2020-11-14 06:20:15 +01:00
Copy link

Thanks for this change, @LaroTayoGaming.

Thanks for this change, @LaroTayoGaming.
kekkyojin (Migrated from github.com) requested changes 2020-11-14 06:21:59 +01:00
README.md
@ -8,4 +9,3 @@
<img src="https://spee.ch/@lbry:3f/android-08-homepage.gif" alt="LBRY Android GIF" width="384px" />
## Installation
kekkyojin (Migrated from github.com) commented 2020-11-14 06:20:25 +01:00
Copy link

Revert this change, rebase your commit and push to your branch again.

I see the GIF is no longer loading, but this is also affecting lbry-android so it should also be fixed on that repository and then merged here.

Revert this change, rebase your commit and push to your branch again. I see the GIF is no longer loading, but this is also affecting lbry-android so it should also be fixed on that repository and then merged here.
iamflorencejay (Migrated from github.com) reviewed 2020-11-15 04:27:50 +01:00
README.md
@ -8,4 +9,3 @@
<img src="https://spee.ch/@lbry:3f/android-08-homepage.gif" alt="LBRY Android GIF" width="384px" />
## Installation
iamflorencejay (Migrated from github.com) commented 2020-11-15 04:27:49 +01:00
Copy link

Okay copy that

Okay copy that
kekkyojin (Migrated from github.com) requested changes 2020-11-15 12:17:58 +01:00
kekkyojin (Migrated from github.com) left a comment
Copy link

Perform these changes, then please squash your commits so there is only one of them to be merged here and then force push to your branch.

Perform these changes, then please squash your commits so there is only one of them to be merged here and then force push to your branch.
README.md
@ -5,3 +5,4 @@
An Android browser and wallet for the [LBRY](https://lbry.com) network.
<a href="https://f-droid.org/packages/io.lbry.browser"><img src="https://raw.githubusercontent.com/f-droid/artwork/master/badge/get-it-on-en-us.png" title="Get LBRY on F-droid"></a>
kekkyojin (Migrated from github.com) commented 2020-11-15 12:16:02 +01:00
Copy link

Remove this change.

This is the source code of the app. Final users can read the instructions on the Installation section.

Also, lbry-android doesn't provide something like this on their Readme file.

Remove this change. This is the source code of the app. Final users can read the instructions on the Installation section. Also, lbry-android doesn't provide something like this on their Readme file.
README.md
@ -9,4 +10,3 @@
## Installation
The minimum supported Android version is 5.0 Lollipop. There are two ways to install:
kekkyojin (Migrated from github.com) commented 2020-11-15 12:16:11 +01:00
Copy link

Revert this.

Revert this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
kekkyojin
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-fdroid#5
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?