Discovery #2

Merged
akinwale merged 10 commits from discovery into master 2019-07-26 10:13:47 +02:00
44 changed files with 1730 additions and 405 deletions

83
package-lock.json generated
View file

@ -1462,6 +1462,32 @@
}
}
},
"babel-eslint": {
"version": "10.0.2",
"resolved": "https://registry.npmjs.org/babel-eslint/-/babel-eslint-10.0.2.tgz",
"integrity": "sha512-UdsurWPtgiPgpJ06ryUnuaSXC2s0WoSZnQmEpbAH65XZSdwowgN5MvyP7e88nW07FYXv72erVtpBkxyDVKhH1Q==",
"dev": true,
"requires": {
"@babel/code-frame": "^7.0.0",
"@babel/parser": "^7.0.0",
"@babel/traverse": "^7.0.0",
"@babel/types": "^7.0.0",
"eslint-scope": "3.7.1",
"eslint-visitor-keys": "^1.0.0"
},
"dependencies": {
"eslint-scope": {
"version": "3.7.1",
"resolved": "https://registry.npmjs.org/eslint-scope/-/eslint-scope-3.7.1.tgz",
"integrity": "sha1-PWPD7f2gLgbgGkUq2IyqzHzctug=",
"dev": true,
"requires": {
"esrecurse": "^4.1.0",
"estraverse": "^4.1.1"
}
}
}
},
"babel-helper-bindify-decorators": {
"version": "6.24.1",
"resolved": "https://registry.npmjs.org/babel-helper-bindify-decorators/-/babel-helper-bindify-decorators-6.24.1.tgz",
@ -2521,6 +2547,12 @@
"resolved": "https://registry.npmjs.org/chardet/-/chardet-0.4.2.tgz",
"integrity": "sha1-tUc7M9yXxCTl2Y3IfVXU2KKci/I="
},
"ci-info": {
"version": "1.6.0",
"resolved": "https://registry.npmjs.org/ci-info/-/ci-info-1.6.0.tgz",
"integrity": "sha512-vsGdkwSCDpWmP80ncATX7iea5DWQemg1UgCW5J8tqjU3lYw4FBYuj89J0CTVomA7BEfvSZd84GmHko+MxFQU2A==",
"dev": true
},
"class-utils": {
"version": "0.3.6",
"resolved": "https://registry.npmjs.org/class-utils/-/class-utils-0.3.6.tgz",
@ -3769,7 +3801,8 @@
},
"ansi-regex": {
"version": "2.1.1",
"bundled": true
"bundled": true,
"optional": true
},
"aproba": {
"version": "1.2.0",
@ -4134,7 +4167,8 @@
},
"safe-buffer": {
"version": "5.1.2",
"bundled": true
"bundled": true,
"optional": true
},
"safer-buffer": {
"version": "2.1.2",
@ -4182,6 +4216,7 @@
"strip-ansi": {
"version": "3.0.1",
"bundled": true,
"optional": true,
"requires": {
"ansi-regex": "^2.0.0"
}
@ -4220,11 +4255,13 @@
},
"wrappy": {
"version": "1.0.2",
"bundled": true
"bundled": true,
"optional": true
},
"yallist": {
"version": "3.0.3",
"bundled": true
"bundled": true,
"optional": true
}
}
},
@ -4449,6 +4486,25 @@
"toidentifier": "1.0.0"
}
},
"husky": {
"version": "0.14.3",
"resolved": "https://registry.npmjs.org/husky/-/husky-0.14.3.tgz",
"integrity": "sha512-e21wivqHpstpoiWA/Yi8eFti8E+sQDSS53cpJsPptPs295QTOQR0ZwnHo2TXy1XOpZFD9rPOd3NpmqTK6uMLJA==",
"dev": true,
"requires": {
"is-ci": "^1.0.10",
"normalize-path": "^1.0.0",
"strip-indent": "^2.0.0"
},
"dependencies": {
"normalize-path": {
"version": "1.0.0",
"resolved": "https://registry.npmjs.org/normalize-path/-/normalize-path-1.0.0.tgz",
"integrity": "sha1-MtDkcvkf80VwHBWoMRAY07CpA3k=",
"dev": true
}
}
},
"iconv-lite": {
"version": "0.4.24",
"resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.4.24.tgz",
@ -4575,6 +4631,15 @@
"integrity": "sha512-r5p9sxJjYnArLjObpjA4xu5EKI3CuKHkJXMhT7kwbpUyIFD1n5PMAsoPvWnvtZiNz7LjkYDRZhd7FlI0eMijEA==",
"dev": true
},
"is-ci": {
"version": "1.2.1",
"resolved": "https://registry.npmjs.org/is-ci/-/is-ci-1.2.1.tgz",
"integrity": "sha512-s6tfsaQaQi3JNciBH6shVqEDvhGut0SUXr31ag8Pd8BBbVVlcGfWhpPmEOoM6RJ5TFhbypvf5yyRw/VXW1IiWg==",
"dev": true,
"requires": {
"ci-info": "^1.5.0"
}
},
"is-data-descriptor": {
"version": "0.1.4",
"resolved": "https://registry.npmjs.org/is-data-descriptor/-/is-data-descriptor-0.1.4.tgz",
@ -4954,8 +5019,8 @@
}
},
"lbry-redux": {
"version": "github:lbryio/lbry-redux#0ff6364a40253387fbe1c4a5b5cd444f616d84e6",
"from": "github:lbryio/lbry-redux",
"version": "github:lbryio/lbry-redux#b2044499c5f43e519384433538c1225d56d3a1f2",
"from": "github:lbryio/lbry-redux#multi-claim-search",
"requires": {
"proxy-polyfill": "0.1.6",
"reselect": "^3.0.0",
@ -8693,6 +8758,12 @@
"resolved": "https://registry.npmjs.org/strip-eof/-/strip-eof-1.0.0.tgz",
"integrity": "sha1-u0P/VZim6wXYm1n80SnJgzE2Br8="
},
"strip-indent": {
"version": "2.0.0",
"resolved": "https://registry.npmjs.org/strip-indent/-/strip-indent-2.0.0.tgz",
"integrity": "sha1-XvjbKV0B5u1sv3qrlpmNeCJSe2g=",
"dev": true
},
"strip-json-comments": {
"version": "2.0.1",
"resolved": "https://registry.npmjs.org/strip-json-comments/-/strip-json-comments-2.0.1.tgz",

View file

@ -11,7 +11,7 @@
"base-64": "^0.1.0",
"@expo/vector-icons": "^8.1.0",
"gfycat-style-urls": "^1.0.3",
"lbry-redux": "lbryio/lbry-redux",
"lbry-redux": "lbryio/lbry-redux#multi-claim-search",
"lbryinc": "lbryio/lbryinc",
"lodash": ">=4.17.11",
"merge": ">=1.2.1",
@ -41,10 +41,11 @@
"redux-persist-transform-compress": "^4.2.0",
"redux-persist-transform-filter": "0.0.18",
"redux-thunk": "^2.3.0",
"rn-fetch-blob": "^0.10.15"
"rn-fetch-blob": "0.10.15"
},
"devDependencies": {
"@babel/core": "^7.5.4",
"babel-eslint": "10.0.2",
"@babel/plugin-proposal-object-rest-spread": "^7.5.4",
"babel-preset-env": "^1.6.1",
"babel-preset-stage-2": "^6.18.0",
@ -59,6 +60,7 @@
"eslint-plugin-react": "^7.12.4",
"eslint-plugin-standard": "^4.0.0",
"flow-babel-webpack-plugin": "^1.1.1",
"husky": "^0.14.3",
"lint-staged": "^7.0.4",
"metro-react-native-babel-preset": "^0.55.0",
"prettier": "^1.11.1"

View file

@ -7,6 +7,7 @@ import FilePage from 'page/file';
import FirstRunScreen from 'page/firstRun';
import PublishPage from 'page/publish';
import RewardsPage from 'page/rewards';
import TagPage from 'page/tag';
import TrendingPage from 'page/trending';
import SearchPage from 'page/search';
import SettingsPage from 'page/settings';
@ -40,7 +41,7 @@ import { decode as atob } from 'base-64';
import { dispatchNavigateBack, dispatchNavigateToUri } from 'utils/helper';
import AsyncStorage from '@react-native-community/async-storage';
import Colors from 'styles/colors';
import Constants from 'constants';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import Icon from 'react-native-vector-icons/FontAwesome5';
import NavigationButton from 'component/navigationButton';
import discoverStyle from 'styles/discover';
@ -72,6 +73,12 @@ const discoverStack = createStackNavigator(
header: null,
}),
},
Tag: {
screen: TagPage,
navigationOptions: ({ navigation }) => ({
header: null,
}),
},
Search: {
screen: SearchPage,
navigationOptions: ({ navigation }) => ({
@ -87,9 +94,9 @@ const discoverStack = createStackNavigator(
discoverStack.navigationOptions = ({ navigation }) => {
let drawerLockMode = 'unlocked';
/*if (navigation.state.index > 0) {
/* if (navigation.state.index > 0) {
drawerLockMode = 'locked-closed';
}*/
} */
return {
drawerLockMode,
@ -139,7 +146,7 @@ const drawer = createDrawerNavigator(
screen: SubscriptionsPage,
navigationOptions: {
title: 'Subscriptions',
drawerIcon: ({ tintColor }) => <Icon name="heart" solid={true} size={20} style={{ color: tintColor }} />,
drawerIcon: ({ tintColor }) => <Icon name="heart" solid size={20} style={{ color: tintColor }} />,
},
},
WalletStack: {
@ -279,8 +286,8 @@ class AppWithNavigationState extends React.Component {
checkEmailVerification = () => {
const { dispatch } = this.props;
AsyncStorage.getItem(Constants.KEY_EMAIL_VERIFY_PENDING).then(pending => {
this.setState({ verifyPending: 'true' === pending });
if ('true' === pending) {
this.setState({ verifyPending: pending === Constants.TRUE_STRING });
if (pending === Constants.TRUE_STRING) {
dispatch(doUserCheckEmailVerified());
}
});
@ -322,7 +329,7 @@ class AppWithNavigationState extends React.Component {
currentDisplayType = 'toast';
}
if ('toast' === currentDisplayType) {
if (currentDisplayType === 'toast') {
ToastAndroid.show(message, ToastAndroid.LONG);
}
@ -331,7 +338,7 @@ class AppWithNavigationState extends React.Component {
if (user && !emailVerifyPending && !this.state.emailVerifyDone && (emailToVerify || emailVerifyErrorMessage)) {
AsyncStorage.getItem(Constants.KEY_SHOULD_VERIFY_EMAIL).then(shouldVerify => {
if ('true' === shouldVerify) {
if (shouldVerify === 'true') {
this.setState({ emailVerifyDone: true });
const message = emailVerifyErrorMessage
? String(emailVerifyErrorMessage)

View file

@ -1,7 +1,4 @@
import { connect } from 'react-redux';
import CategoryList from './view';
export default connect(
null,
null
)(CategoryList);
export default connect()(CategoryList);

View file

@ -0,0 +1,18 @@
import { connect } from 'react-redux';
import { doResolveUri, makeSelectClaimForUri, makeSelectThumbnailForUri, makeSelectIsUriResolving } from 'lbry-redux';
import ChannelIconItem from './view';
const select = (state, props) => ({
thumbnail: makeSelectThumbnailForUri(props.uri)(state),
claim: makeSelectClaimForUri(props.uri)(state),
isResolvingUri: makeSelectIsUriResolving(props.uri)(state),
});
const perform = dispatch => ({
resolveUri: uri => dispatch(doResolveUri(uri)),
});
export default connect(
select,
perform
)(ChannelIconItem);

View file

@ -0,0 +1,51 @@
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
import React from 'react';
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
import { ActivityIndicator, Image, Text, TouchableOpacity, View } from 'react-native';
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
import Colors from 'styles/colors';
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
import channelIconStyle from 'styles/channelIcon';
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
export default class ChannelIconItem extends React.PureComponent {
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
componentDidMount() {
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
const { claim, isPlaceholder, uri, resolveUri } = this.props;
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
if (!claim && !isPlaceholder) {
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
resolveUri(uri);
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
render() {
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
const { claim, isPlaceholder, isResolvingUri, onPress, thumbnail, title } = this.props;
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
return (
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
<TouchableOpacity style={channelIconStyle.container} onPress={onPress}>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
{isResolvingUri && (
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
<View style={channelIconStyle.centered}>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
<ActivityIndicator size={'small'} color={Colors.LbryGreen} />
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
</View>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
)}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
<View
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
style={[
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
channelIconStyle.thumbnailContainer,
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
isPlaceholder ? channelIconStyle.borderedThumbnailContainer : null,
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
]}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
{isPlaceholder && (
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
<View style={channelIconStyle.centered}>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
<Text style={channelIconStyle.placeholderText}>ALL</Text>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
</View>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
)}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
{!isPlaceholder && (
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
<Image
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
style={channelIconStyle.thumbnail}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
resizeMode={'cover'}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
source={thumbnail ? { uri: thumbnail } : require('../../assets/default_avatar.jpg')}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
/>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
)}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
</View>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
{!isPlaceholder && (
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
<Text style={channelIconStyle.title} numberOfLines={1}>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
{title || (claim ? claim.name : '')}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
</Text>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
)}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
</TouchableOpacity>
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
);
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux
}
kauffj commented 2019-07-24 19:13:25 +02:00 (Migrated from github.com)
Review

I assume the above line means that some claims have a thumbnail property of ' ' or similar.

Would it make sense to trim this value somewhere in lbry-redux or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.

I assume the above line means that some claims have a thumbnail property of `' '` or similar. Would it make sense to `trim` this value somewhere in `lbry-redux` or elsewhere in the data model instead? Otherwise, this line would theoretically have to be repeated whenever working with this property, which is not intuitive/expected.
kauffj commented 2019-07-24 19:51:55 +02:00 (Migrated from github.com)
Review
yep, just saw this here too https://github.com/lbryio/lbry-react-native/pull/2/files#diff-5cf471858420cda219b3d4720a301029R41 please move to redux

View file

@ -0,0 +1,40 @@
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
import { connect } from 'react-redux';
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
import {
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
MATURE_TAGS,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
doClaimSearch,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
doClaimSearchByTags,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
makeSelectClaimSearchUrisForTags,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
makeSelectFetchingClaimSearchForTags,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
selectFetchingClaimSearch,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
selectLastClaimSearchUris,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
} from 'lbry-redux';
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
import ClaimList from './view';
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
const select = (state, props) => {
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
return {
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
loading: makeSelectFetchingClaimSearchForTags(props.tags)(state),
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
uris: makeSelectClaimSearchUrisForTags(props.tags)(state),
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
// for subscriptions
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
claimSearchLoading: selectFetchingClaimSearch(state),
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
claimSearchUris: selectLastClaimSearchUris(state),
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
};
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
};
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
const perform = dispatch => ({
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
claimSearch: options => dispatch(doClaimSearch(Constants.DEFAULT_PAGE_SIZE, options)),
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
searchByTags: (tags, orderBy = Constants.DEFAULT_ORDER_BY, page = 1) =>
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
dispatch(
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
doClaimSearchByTags(tags, Constants.DEFAULT_PAGE_SIZE, {
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
no_totals: true,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
order_by: orderBy,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
page,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
not_tags: MATURE_TAGS,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
})
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
),
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
});
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
export default connect(
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
select,
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
perform
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant
)(ClaimList);
kauffj commented 2019-07-24 19:30:47 +02:00 (Migrated from github.com)
Review
https://lbryians.slack.com/archives/C81FGKR51/p1563989434031800
kauffj commented 2019-07-24 19:31:24 +02:00 (Migrated from github.com)
Review

If "10" is a default page size in multiple places, please abstract it as a shared constant

If "10" is a default page size in multiple places, please abstract it as a shared constant

View file

@ -0,0 +1,210 @@
import React from 'react';
import NavigationActions from 'react-navigation';
import { ActivityIndicator, FlatList, Text, View } from 'react-native';
import { MATURE_TAGS, normalizeURI } from 'lbry-redux';
import _ from 'lodash';
import FileItem from 'component/fileItem';
import FileListItem from 'component/fileListItem';
import Colors from 'styles/colors';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import claimListStyle from 'styles/claimList';
import discoverStyle from 'styles/discover';
const horizontalLimit = 10;
const softLimit = 500;
class ClaimList extends React.PureComponent {
scrollView = null;
state = {
currentPage: 1, // initial page load is page 1
subscriptionsView: false, // whether or not this claim list is for subscriptions
trendingForAllView: false,
};
componentDidMount() {
const {
channelIds,
trendingForAll,
claimSearch,
orderBy = Constants.DEFAULT_ORDER_BY,
searchByTags,
tags,
} = this.props;
if (channelIds || trendingForAll) {
const options = {
order_by: orderBy,
no_totals: true,
not_tags: MATURE_TAGS,
page: this.state.currentPage,
};
if (channelIds) {
this.setState({ subscriptionsView: true });
options.channel_ids = channelIds;
} else if (trendingForAll) {
this.setState({ trendingForAllView: true });
}
claimSearch(options);
} else if (tags && tags.length > 0) {
searchByTags(tags, orderBy, this.state.currentPgae);
}
}
componentWillReceiveProps(nextProps) {
const {
claimSearch,
orderBy: prevOrderBy,
searchByTags,
tags: prevTags,
channelIds: prevChannelIds,
trendingForAll: prevTrendingForAll,
} = this.props;
const { orderBy, tags, channelIds, trendingForAll } = nextProps;
if (
!_.isEqual(orderBy, prevOrderBy) ||
kauffj commented 2019-07-24 19:38:35 +02:00 (Migrated from github.com)
Review

I dislike bringing in a dependency just to compare objects :/

If we're not making heavy usage of lodash, I'd propose just bringing in this function (that is, just copy/paste it - yes, this is sometimes better than a dependency).

If this is only being used to determine if non-nested objects contain identical values and keys, I suspect it can be done in just a few lines ourselves

I dislike bringing in a dependency just to compare objects :/ If we're not making heavy usage of lodash, I'd propose just bringing in this function (that is, just copy/paste it - yes, this is sometimes better than a dependency). If this is only being used to determine if non-nested objects contain identical values and keys, I suspect it can be done in just a few lines ourselves
akinwale commented 2019-07-26 08:39:18 +02:00 (Migrated from github.com)
Review

I only decided to make use of the dependency since it was already being imported by a different module.

I only decided to make use of the dependency since it was already being imported by a different module.
!_.isEqual(tags, prevTags) ||
!_.isEqual(channelIds, prevChannelIds) ||
trendingForAll !== prevTrendingForAll
) {
// reset to page 1 because the order, tags or channelIds changed
this.setState({ currentPage: 1 }, () => {
if (this.scrollView) {
this.scrollView.scrollToOffset({ animated: true, offset: 0 });
}
if (trendingForAll || (prevChannelIds && channelIds)) {
const options = {
order_by: orderBy,
no_totals: true,
not_tags: MATURE_TAGS,
page: this.state.currentPage,
};
if (channelIds) {
this.setState({ subscriptionsView: true });
options.channel_ids = channelIds;
}
if (trendingForAll) {
this.setState({ trendingForAllView: true });
kauffj commented 2019-07-24 19:46:49 +02:00 (Migrated from github.com)
Review

if both tendingForAll and channelIds can be true it results in two calls to setState (and thus it's better to build an object)

if it shouldn't be possible for both to be true, I'd make it an else just to be clearer that they are exclusive conditions

it could also make sense to write a "stupid" (simple) claimList component that only receives claims, and then create a ChannelClaimList and StreamClaimList component that performs all component logic, then passes the resulting uris/claims to the stupid version

if both `tendingForAll` and `channelIds` can be true it results in two calls to `setState` (and thus it's better to build an object) if it shouldn't be possible for both to be true, I'd make it an else just to be clearer that they are exclusive conditions it could also make sense to write a "stupid" (simple) claimList component that only receives claims, and then create a ChannelClaimList and StreamClaimList component that performs all component logic, then passes the resulting uris/claims to the stupid version
akinwale commented 2019-07-26 08:41:33 +02:00 (Migrated from github.com)
Review

It's not possible for both to be true. I initially created the ClaimList component just for displaying content for a tag or set of tags, but then I realised I needed to have the subscriptions (using channelIds) and then eventually trending for all.

It's not possible for both to be true. I initially created the ClaimList component just for displaying content for a tag or set of tags, but then I realised I needed to have the subscriptions (using channelIds) and then eventually trending for all.
}
claimSearch(options);
} else if (tags && tags.length > 0) {
this.setState({ subscriptionsView: false, trendingForAllView: false });
searchByTags(tags, orderBy, this.state.currentPage);
}
});
}
}
handleVerticalEndReached = () => {
// fetch more content
const { channelIds, claimSearch, claimSearchUris, orderBy, searchByTags, tags, uris } = this.props;
const { subscriptionsView, trendingForAllView } = this.state;
if ((claimSearchUris && claimSearchUris.length >= softLimit) || (uris && uris.length >= softLimit)) {
// don't fetch more than the specified limit to be displayed
return;
}
this.setState({ currentPage: this.state.currentPage + 1 }, () => {
if (subscriptionsView || trendingForAllView) {
const options = {
order_by: orderBy,
no_totals: true,
not_tags: MATURE_TAGS,
page: this.state.currentPage,
};
if (subscriptionsView) {
options.channel_ids = channelIds;
}
claimSearch(options);
} else {
searchByTags(tags, orderBy, this.state.currentPage);
}
});
};
render() {
const {
ListHeaderComponent,
loading,
claimSearchLoading,
claimSearchUris,
navigation,
orientation = Constants.ORIENTATION_VERTICAL,
style,
uris,
} = this.props;
const { subscriptionsView, trendingForAllView } = this.state;
if (Constants.ORIENTATION_VERTICAL === orientation) {
const data = subscriptionsView || trendingForAllView ? claimSearchUris : uris;
return (
<View style={style}>
<FlatList
ref={ref => {
this.scrollView = ref;
}}
ListHeaderComponent={ListHeaderComponent}
style={claimListStyle.verticalScrollContainer}
contentContainerStyle={claimListStyle.verticalScrollPadding}
initialNumToRender={8}
maxToRenderPerBatch={24}
removeClippedSubviews
renderItem={({ item }) => (
<FileListItem key={item} uri={item} style={claimListStyle.verticalListItem} navigation={navigation} />
)}
data={data}
keyExtractor={(item, index) => item}
onEndReached={this.handleVerticalEndReached}
onEndReachedThreshold={0.9}
/>
{(((subscriptionsView || trendingForAllView) && claimSearchLoading) || loading) && (
<View style={claimListStyle.verticalLoading}>
<ActivityIndicator size={'small'} color={Colors.LbryGreen} />
</View>
)}
</View>
);
}
if (Constants.ORIENTATION_HORIZONTAL === orientation) {
if (loading) {
return (
<View style={discoverStyle.listLoading}>
<ActivityIndicator size={'small'} color={Colors.LbryGreen} />
</View>
);
}
return (
<FlatList
style={style || claimListStyle.horizontalScrollContainer}
contentContainerStyle={claimListStyle.horizontalScrollPadding}
initialNumToRender={3}
maxToRenderPerBatch={3}
removeClippedSubviews
renderItem={({ item }) => (
<FileItem
style={discoverStyle.fileItem}
mediaStyle={discoverStyle.fileItemMedia}
key={item}
uri={normalizeURI(item)}
navigation={navigation}
showDetails
compactView={false}
/>
)}
horizontal
showsHorizontalScrollIndicator={false}
data={uris ? uris.slice(0, horizontalLimit) : []}
keyExtractor={(item, index) => item}
/>
);
}
return null;
}
}
export default ClaimList;

View file

@ -13,10 +13,6 @@ import NsfwOverlay from 'component/nsfwOverlay';
import discoverStyle from 'styles/discover';
class FileItem extends React.PureComponent {
constructor(props) {
super(props);
}
componentWillMount() {
this.resolve(this.props);
}
@ -64,8 +60,7 @@ class FileItem extends React.PureComponent {
const isRewardContent = claim && rewardedContentClaimIds.includes(claim.claim_id);
const signingChannel = claim ? claim.signing_channel : null;
const channelName = signingChannel ? signingChannel.name : null;
const channelClaimId =
claim && claim.value && claim.value.publisherSignature && claim.value.publisherSignature.certificateId;
const channelClaimId = signingChannel ? signingChannel.claim_id : null;
const fullChannelUri = channelClaimId ? `${channelName}#${channelClaimId}` : channelName;
const height = claim ? claim.height : null;
@ -87,13 +82,7 @@ class FileItem extends React.PureComponent {
/>
{!compactView && fileInfo && fileInfo.completed && fileInfo.download_path && (
<Icon
style={discoverStyle.downloadedIcon}
solid={true}
color={Colors.NextLbryGreen}
name={'folder'}
size={16}
/>
<Icon style={discoverStyle.downloadedIcon} solid color={Colors.NextLbryGreen} name={'folder'} size={16} />
)}
{!compactView && (!fileInfo || !fileInfo.completed || !fileInfo.download_path) && (
<FilePrice uri={uri} style={discoverStyle.filePriceContainer} textStyle={discoverStyle.filePriceText} />

View file

@ -41,6 +41,11 @@ class FileListItem extends React.PureComponent {
}
}
defaultOnPress = () => {
const { navigation, uri } = this.props;
navigateToUri(navigation, uri);
};
render() {
const {
claim,
@ -60,13 +65,13 @@ class FileListItem extends React.PureComponent {
const obscureNsfw = this.props.obscureNsfw && metadata && metadata.nsfw;
const isResolving = !fileInfo && isResolvingUri;
let name, channel, height, channelClaimId, fullChannelUri;
let name, channel, height, channelClaimId, fullChannelUri, signingChannel;
if (claim) {
name = claim.name;
signingChannel = claim.signing_channel;
channel = signingChannel ? signingChannel.name : null;
height = claim.height;
channelClaimId = claim.value && claim.value.publisherSignature && claim.value.publisherSignature.certificateId;
channelClaimId = signingChannel ? signingChannel.claim_id : null;
fullChannelUri = channelClaimId ? `${channel}#${channelClaimId}` : channel;
}
@ -76,7 +81,7 @@ class FileListItem extends React.PureComponent {
return (
<View style={style}>
<TouchableOpacity style={style} onPress={onPress}>
<TouchableOpacity style={style} onPress={onPress || this.defaultOnPress}>
<FileItemMedia
style={fileListStyle.thumbnail}
blurRadius={obscureNsfw ? 15 : 0}
@ -85,13 +90,7 @@ class FileListItem extends React.PureComponent {
thumbnail={thumbnail}
/>
{fileInfo && fileInfo.completed && fileInfo.download_path && (
<Icon
style={fileListStyle.downloadedIcon}
solid={true}
color={Colors.NextLbryGreen}
name={'folder'}
size={16}
/>
<Icon style={fileListStyle.downloadedIcon} solid color={Colors.NextLbryGreen} name={'folder'} size={16} />
)}
<View style={fileListStyle.detailsContainer}>
{featuredResult && (

View file

@ -428,7 +428,7 @@ class MediaPlayer extends React.PureComponent {
bufferForPlaybackMs: 5000,
bufferForPlaybackAfterRebufferMs: 5000,
}}
ref={(ref: Video) => {
ref={ref => {
this.video = ref;
}}
resizeMode={this.state.resizeMode}
@ -445,7 +445,7 @@ class MediaPlayer extends React.PureComponent {
minLoadRetryCount={999}
/>
{this.state.firstPlay && thumbnail && thumbnail.trim().length > 0 && (
{this.state.firstPlay && thumbnail && (
<FastImage
source={{ uri: thumbnail }}
resizeMode={FastImage.resizeMode.cover}

View file

@ -0,0 +1,4 @@
import { connect } from 'react-redux';
import ModalPicker from './view';
export default connect()(ModalPicker);

View file

@ -0,0 +1,60 @@
import React from 'react';
import { Text, TouchableOpacity, View } from 'react-native';
import modalPickerStyle from 'styles/modalPicker';
import Colors from 'styles/colors';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import Icon from 'react-native-vector-icons/FontAwesome5';
export default class ModalPicker extends React.PureComponent {
state = {
selectedItem: null,
};
componentDidMount() {
const { items, selectedItem } = this.props;
if (!selectedItem && items && items.length > 0) {
this.setState({ selectedItem: items[0] });
return;
}
this.setState({ selectedItem });
}
componentWillReceiveProps(nextProps) {
const { selectedItem: prevSelectedItem } = this.props;
const { selectedItem } = nextProps;
if (selectedItem && selectedItem.name !== prevSelectedItem.name) {
this.setState({ selectedItem });
}
}
render() {
const { items, onItemSelected, title, onOverlayPress } = this.props;
const { selectedItem } = this.state;
return (
<TouchableOpacity style={modalPickerStyle.overlay} activeOpacity={1} onPress={onOverlayPress}>
<View style={modalPickerStyle.container}>
<Text style={modalPickerStyle.title}>{title}</Text>
<View style={modalPickerStyle.divider} />
<View style={modalPickerStyle.list}>
{items.length &&
items.map(item => (
<TouchableOpacity
key={item.name}
style={modalPickerStyle.listItem}
onPress={() => onItemSelected(item)}
>
<Icon style={modalPickerStyle.itemIcon} name={item.icon} size={16} />
<Text style={modalPickerStyle.itemLabel}>{item.label}</Text>
{selectedItem && selectedItem.name === item.name && (
<Icon style={modalPickerStyle.itemSelected} name={'check'} color={Colors.LbryGreen} size={16} />
)}
</TouchableOpacity>
))}
</View>
</View>
</TouchableOpacity>
);
}
}

View file

@ -0,0 +1,27 @@
import { connect } from 'react-redux';
import {
selectUnfollowedTags,
selectFollowedTags,
doReplaceTags,
doToggleTagFollow,
doAddTag,
doDeleteTag,
doToast,
} from 'lbry-redux';
import ModalTagSelector from './view';
const select = state => ({
unfollowedTags: selectUnfollowedTags(state),
followedTags: selectFollowedTags(state),
});
export default connect(
select,
{
doToggleTagFollow,
doAddTag,
doDeleteTag,
doReplaceTags,
doToast,
}
)(ModalTagSelector);

View file

@ -0,0 +1,66 @@
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import React from 'react';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import { Text, TouchableOpacity, View } from 'react-native';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import { DEFAULT_FOLLOWED_TAGS } from 'lbry-redux';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import Button from 'component/button';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import Colors from 'styles/colors';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import Icon from 'react-native-vector-icons/FontAwesome5';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import Tag from 'component/tag';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import TagSearch from 'component/tagSearch';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import modalTagSelectorStyle from 'styles/modalTagSelector';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
import __ from 'utils/helper';
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
export default class ModalTagSelector extends React.PureComponent {
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
handleAddTag = tag => {
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
if (!tag) {
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
return;
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
const { followedTags, doToast } = this.props;
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
if (followedTags.map(followedTag => followedTag.name).includes(tag.toLowerCase())) {
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
doToast({ message: __(`You already added the "${tag}" tag.`) });
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
return;
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
this.props.doToggleTagFollow(tag);
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
};
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
handleRemoveTag = tag => {
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
if (!tag) {
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
return;
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
this.props.doToggleTagFollow(tag);
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
};
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
render() {
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
const { followedTags, onOverlayPress, onDonePress } = this.props;
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
const tags = followedTags ? followedTags.map(tag => tag.name) : DEFAULT_FOLLOWED_TAGS;
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
return (
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<TouchableOpacity style={modalTagSelectorStyle.overlay} activeOpacity={1} onPress={onOverlayPress}>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<View style={modalTagSelectorStyle.container}>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<View style={modalTagSelectorStyle.titleRow}>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<Text style={modalTagSelectorStyle.title}>Customize your tags</Text>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
</View>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<View style={modalTagSelectorStyle.tagList}>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
{tags &&
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
tags.map(tag => (
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<Tag
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
key={tag}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
name={tag}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
type={'remove'}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
style={modalTagSelectorStyle.tag}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
onRemovePress={this.handleRemoveTag}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
/>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
))}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
</View>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<TagSearch handleAddTag={this.handleAddTag} selectedTags={tags} />
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<View style={modalTagSelectorStyle.buttons}>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
<Button style={modalTagSelectorStyle.doneButton} text={'Done'} onPress={onDonePress} />
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
</View>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
</View>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
</TouchableOpacity>
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
);
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.
}
kauffj commented 2019-07-24 19:49:40 +02:00 (Migrated from github.com)
Review

missing __

missing `__`
kauffj commented 2019-07-24 19:50:37 +02:00 (Migrated from github.com)
Review

why are we calling toLowerCase only here? tag display should be consistent

IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast

why are we calling `toLowerCase` only here? tag display should be consistent IMO either lowercase always (and thus move to redux) or display as they are with mixed capitalization even in the toast
akinwale commented 2019-07-26 08:43:52 +02:00 (Migrated from github.com)
Review

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

This is a habit I picked up for whenever I want to compare strings making sure they're case insensitive first. I believe the names in followedTags are always lowercase.

View file

@ -0,0 +1,4 @@
import { connect } from 'react-redux';
import SubscribedChannelList from './view';
export default connect()(SubscribedChannelList);

View file

@ -0,0 +1,36 @@
import React from 'react';
import { Text, FlatList, View } from 'react-native';
import { normalizeURI } from 'lbry-redux';
import ChannelIconItem from 'component/channelIconItem';
import Colors from 'styles/colors';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import subscriptionsStyle from 'styles/subscriptions';
export default class SubscribedChannelList extends React.PureComponent {
render() {
const { subscribedChannels, onChannelSelected } = this.props;
return (
<View style={subscriptionsStyle.channelList}>
<FlatList
contentContainerStyle={subscriptionsStyle.channelListScrollContainer}
initialNumToRender={5}
maxToRenderPerBatch={5}
removeClippedSubviews
horizontal
showsHorizontalScrollIndicator={false}
renderItem={({ item }) => (
<ChannelIconItem
key={item}
isPlaceholder={item.toLowerCase() === Constants.ALL_PLACEHOLDER}
uri={normalizeURI(item)}
onPress={() => onChannelSelected(item)}
/>
)}
data={subscribedChannels}
keyExtractor={(item, index) => item}
/>
</View>
);
}
}

View file

@ -1,22 +1,22 @@
import { connect } from 'react-redux';
import {
makeSelectFetchingChannelClaims,
makeSelectClaimsInChannelForPage,
doFetchClaimsByChannel,
doResolveUris,
doResolveUri,
makeSelectClaimForUri,
makeSelectThumbnailForUri,
makeSelectTitleForUri,
makeSelectIsUriResolving,
} from 'lbry-redux';
import { selectShowNsfw } from 'redux/selectors/settings';
import SuggestedSubscriptionItem from './view';
const select = (state, props) => ({
claims: makeSelectClaimsInChannelForPage(props.categoryLink)(state),
fetching: makeSelectFetchingChannelClaims(props.categoryLink)(state),
obscureNsfw: !selectShowNsfw(state),
thumbnail: makeSelectThumbnailForUri(props.uri)(state),
title: makeSelectTitleForUri(props.uri)(state),
claim: makeSelectClaimForUri(props.uri)(state),
isResolvingUri: makeSelectIsUriResolving(props.uri)(state),
});
const perform = dispatch => ({
fetchChannel: channel => dispatch(doFetchClaimsByChannel(channel)),
resolveUris: uris => dispatch(doResolveUris(uris, true)),
resolveUri: uri => dispatch(doResolveUri(uri)),
});
export default connect(

View file

@ -1,76 +1,70 @@
import React from 'react';
import { buildURI, normalizeURI } from 'lbry-redux';
import { ActivityIndicator, FlatList, Text, View } from 'react-native';
import { ActivityIndicator, FlatList, Image, Text, View } from 'react-native';
import Colors from 'styles/colors';
import discoverStyle from 'styles/discover';
import FileItem from 'component/fileItem';
import SubscribeButton from 'component/subscribeButton';
import subscriptionsStyle from 'styles/subscriptions';
import Tag from 'component/tag';
class SuggestedSubscriptionItem extends React.PureComponent {
componentDidMount() {
const { fetching, categoryLink, fetchChannel, resolveUris, claims } = this.props;
if (!fetching && categoryLink && (!claims || claims.length)) {
fetchChannel(categoryLink);
const { claim, uri, resolveUri } = this.props;
if (!claim) {
resolveUri(uri);
}
}
uriForClaim = claim => {
const { name: claimName, claim_name: claimNameDownloaded, claim_id: claimId } = claim;
const uriParams = {};
// This is unfortunate
// https://github.com/lbryio/lbry/issues/1159
const name = claimName || claimNameDownloaded;
uriParams.contentName = name;
uriParams.claimId = claimId;
const uri = buildURI(uriParams);
return uri;
};
render() {
const { categoryLink, fetching, obscureNsfw, claims, navigation } = this.props;
const { claim, isResolvingUri, navigation, thumbnail, title, uri } = this.props;
let tags;
if (claim && claim.value) {
tags = claim.value.tags;
}
if (!claims || !claims.length) {
if (isResolvingUri) {
return (
<View style={subscriptionsStyle.busyContainer}>
<View style={subscriptionsStyle.itemLoadingContainer}>
<ActivityIndicator size={'small'} color={Colors.LbryGreen} />
</View>
);
}
if (claims && claims.length > 0) {
return (
<View style={subscriptionsStyle.suggestedContainer}>
<FileItem
style={subscriptionsStyle.compactMainFileItem}
mediaStyle={subscriptionsStyle.fileItemMedia}
uri={this.uriForClaim(claims[0])}
navigation={navigation}
return (
<View style={subscriptionsStyle.suggestedItem}>
<View style={subscriptionsStyle.suggestedItemThumbnailContainer}>
<Image
style={subscriptionsStyle.suggestedItemThumbnail}
resizeMode={'cover'}
source={thumbnail ? { uri: thumbnail } : require('../../assets/default_avatar.jpg')}
/>
{claims.length > 1 && (
<FlatList
style={subscriptionsStyle.compactItems}
horizontal={true}
renderItem={({ item }) => (
<FileItem
style={subscriptionsStyle.compactFileItem}
mediaStyle={subscriptionsStyle.compactFileItemMedia}
key={item}
uri={normalizeURI(item)}
navigation={navigation}
compactView={true}
/>
)}
data={claims.slice(1, 4).map(claim => this.uriForClaim(claim))}
keyExtractor={(item, index) => item}
/>
)}
</View>
);
}
return null;
<View style={subscriptionsStyle.suggestedItemDetails}>
<View style={subscriptionsStyle.suggestedItemInfo}>
{title && (
<Text style={subscriptionsStyle.suggestedItemTitle} numberOfLines={1}>
{title}
</Text>
)}
<Text style={subscriptionsStyle.suggestedItemName} numberOfLines={1}>
{claim && claim.name}
</Text>
{tags && (
<View style={subscriptionsStyle.suggestedItemTagList}>
{tags &&
tags
.slice(0, 3)
.map(tag => <Tag style={subscriptionsStyle.tag} key={tag} name={tag} navigation={navigation} />)}
</View>
)}
</View>
</View>
<SubscribeButton style={subscriptionsStyle.suggestedItemSubscribe} uri={normalizeURI(uri)} />
</View>
);
}
}

View file

@ -1,13 +1,20 @@
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
import { connect } from 'react-redux';
import { doClaimSearch, selectFetchingClaimSearch, selectLastClaimSearchUris, selectFollowedTags } from 'lbry-redux';
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
import { selectSuggestedChannels, selectIsFetchingSuggested } from 'lbryinc';
import SuggestedSubscriptions from './view';
const select = state => ({
followedTags: selectFollowedTags(state),
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
suggested: selectSuggestedChannels(state),
loading: selectIsFetchingSuggested(state),
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state),
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
claimSearchUris: selectLastClaimSearchUris(state),
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
});
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
const perform = dispatch => ({
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
claimSearch: options => dispatch(doClaimSearch(10, options)),
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
});
export default connect(
select,
null
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
perform
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
)(SuggestedSubscriptions);

kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```
kauffj commented 2019-07-24 19:54:03 +02:00 (Migrated from github.com)
Review

reading logic below, I think you can do:

loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state)
reading logic below, I think you can do: ``` loading: selectIsFetchingSuggested(state) || selectFetchingClaimSearch(state) ```

View file

@ -1,53 +1,67 @@
import React from 'react';
import { ActivityIndicator, SectionList, Text, View } from 'react-native';
import { ActivityIndicator, FlatList, SectionList, Text, View } from 'react-native';
import { normalizeURI } from 'lbry-redux';
import { navigateToUri } from 'utils/helper';
import __, { navigateToUri } from 'utils/helper';
import SubscribeButton from 'component/subscribeButton';
import SuggestedSubscriptionItem from 'component/suggestedSubscriptionItem';
import Colors from 'styles/colors';
kauffj commented 2019-07-24 19:52:45 +02:00 (Migrated from github.com)
Review

i18n

i18n
import discoverStyle from 'styles/discover';
import subscriptionsStyle from 'styles/subscriptions';
import Link from 'component/link';
import _ from 'lodash';
class SuggestedSubscriptions extends React.PureComponent {
componentDidMount() {
const { claimSearch, followedTags } = this.props;
const options = {
any_tags: _.shuffle(followedTags.map(tag => tag.name)).slice(0, 2),
page: 1,
no_totals: true,
claim_type: 'channel',
};
claimSearch(options);
}
buildSections = () => {
const { suggested, claimSearchUris } = this.props;
kauffj commented 2019-07-24 19:52:36 +02:00 (Migrated from github.com)
Review

why shuffle?

why shuffle?
akinwale commented 2019-07-26 08:50:20 +02:00 (Migrated from github.com)
Review

There is currently a sdk bug where if I try to search for claims using channel for claim_type, and having more than 2 items in any_tags, the request times out and no results are returned.

Working with the limitation of 2 items, I decided to display suggested channels based on two random tags from the list of the user's followed tags. This also makes the suggested subscriptions list look dynamic every time a sees the suggestions.

There is currently a sdk bug where if I try to search for claims using `channel` for `claim_type`, and having more than 2 items in `any_tags`, the request times out and no results are returned. Working with the limitation of 2 items, I decided to display suggested channels based on two random tags from the list of the user's followed tags. This also makes the suggested subscriptions list look dynamic every time a sees the suggestions.
const suggestedUris = suggested ? suggested.map(suggested => suggested.uri) : [];
return [
{
title: __('You might like'),
data: suggestedUris,
},
{
title: __('Tags you follow'),
data: claimSearchUris ? claimSearchUris.filter(uri => !suggestedUris.includes(uri)) : [],
},
];
};
render() {
const { suggested, loading, navigation } = this.props;
if (loading) {
return (
<View>
<View style={subscriptionsStyle.centered}>
<ActivityIndicator size="large" color={Colors.LbryGreen} />
</View>
);
}
return suggested ? (
return (
<SectionList
style={subscriptionsStyle.scrollContainer}
contentContainerStyle={subscriptionsStyle.suggestedScrollPadding}
renderItem={({ item, index, section }) => (
<SuggestedSubscriptionItem key={item} categoryLink={normalizeURI(item)} navigation={navigation} />
<SuggestedSubscriptionItem key={item} uri={normalizeURI(item)} navigation={navigation} />
)}
renderSectionHeader={({ section: { title } }) => {
const titleParts = title.split(';');
const channelName = titleParts[0];
const channelUri = normalizeURI(titleParts[1]);
return (
<View style={subscriptionsStyle.titleRow}>
<Link
style={subscriptionsStyle.channelTitle}
text={channelName}
onPress={() => {
navigateToUri(navigation, normalizeURI(channelUri));
}}
/>
<SubscribeButton style={subscriptionsStyle.subscribeButton} uri={channelUri} name={channelName} />
</View>
);
}}
sections={suggested.map(({ uri, label }) => ({ title: label + ';' + uri, data: [uri] }))}
renderSectionHeader={({ section: { title } }) => (
<Text style={subscriptionsStyle.suggestedSubTitle}>{title}</Text>
)}
sections={this.buildSections()}
keyExtractor={(item, index) => item}
/>
) : null;
);
}
}

View file

@ -2,6 +2,7 @@ import React from 'react';
import { Text, TouchableOpacity, View } from 'react-native';
import tagStyle from 'styles/tag';
import Colors from 'styles/colors';
import Constants from 'constants';
import Icon from 'react-native-vector-icons/FontAwesome5';
export default class Tag extends React.PureComponent {
@ -22,6 +23,7 @@ export default class Tag extends React.PureComponent {
if (navigation) {
// navigate to tag page
navigation.navigate({ routeName: Constants.DRAWER_ROUTE_TAG, key: `tagPage`, params: { tag: name } });
}
};

View file

@ -1,5 +1,5 @@
import React from 'react';
import { Text, TextInput, TouchableOpacity, View } from 'react-native';
import { KeyboardAvoidingView, Text, TextInput, TouchableOpacity, View } from 'react-native';
import Tag from 'component/tag';
import tagStyle from 'styles/tag';
import Colors from 'styles/colors';
@ -47,9 +47,17 @@ export default class TagSearch extends React.PureComponent {
const suggestedTagsSet = new Set(unfollowedTags.map(tag => tag.name));
const suggestedTags = Array.from(suggestedTagsSet).filter(tagNotSelected);
if (tag && tag.trim().length > 0) {
results.push(tag.toLowerCase());
const lcTag = tag.toLowerCase();
if (!results.includes(lcTag)) {
results.push(lcTag);
}
const doesTagMatch = name => name.toLowerCase().includes(tag.toLowerCase());
results = results.concat(suggestedTags.filter(doesTagMatch).slice(0, 5));
results = results.concat(
suggestedTags
.filter(doesTagMatch)
.filter(suggested => lcTag !== suggested.toLowerCase())
.slice(0, 5)
);
} else {
results = results.concat(suggestedTags.slice(0, 5));
}
@ -70,11 +78,13 @@ export default class TagSearch extends React.PureComponent {
numberOfLines={1}
onChangeText={this.handleTagChange}
/>
<View style={tagStyle.tagResultsList}>
{this.state.tagResults.map(tag => (
<Tag key={tag} name={tag} style={tagStyle.tag} type="add" onAddPress={name => this.onAddTagPress(name)} />
))}
</View>
<KeyboardAvoidingView behavior={'position'}>
<View style={tagStyle.tagResultsList}>
{this.state.tagResults.map(tag => (
<Tag key={tag} name={tag} style={tagStyle.tag} type="add" onAddPress={name => this.onAddTagPress(name)} />
))}
</View>
</KeyboardAvoidingView>
</View>
);
}

View file

@ -136,19 +136,19 @@ class UriBar extends React.PureComponent {
}
render() {
const { navigation, suggestions, query, value } = this.props;
const { navigation, suggestions, query, value, belowOverlay } = this.props;
if (this.state.currentValue === null) {
this.setState({ currentValue: value });
}
let style = [uriBarStyle.overlay];
let style = [uriBarStyle.overlay, belowOverlay ? null : uriBarStyle.overlayElevated];
// TODO: Add optional setting to enable URI / search bar suggestions
/*if (this.state.focused) { style.push(uriBarStyle.inFocus); }*/
return (
<View style={style}>
<View style={uriBarStyle.uriContainer}>
<View style={[uriBarStyle.uriContainer, belowOverlay ? null : uriBarStyle.containerElevated]}>
<NavigationButton
name="bars"
size={24}

View file

@ -1,3 +1,7 @@
const SORT_BY_NEW = 'new';
const SORT_BY_HOT = 'hot';
const SORT_BY_TOP = 'top';
const Constants = {
FIRST_RUN_PAGE_WELCOME: 'welcome',
FIRST_RUN_PAGE_EMAIL_COLLECT: 'email-collect',
@ -43,6 +47,9 @@ const Constants = {
ACTION_REACT_NAVIGATION_NAVIGATE: 'Navigation/NAVIGATE',
ACTION_REACT_NAVIGATION_REPLACE: 'Navigation/REPLACE',
ORIENTATION_HORIZONTAL: 'horizontal',
ORIENTATION_VERTICAL: 'vertical',
PAGE_REWARDS: 'rewards',
PAGE_SETTINGS: 'settings',
PAGE_TRENDING: 'trending',
@ -59,6 +66,7 @@ const Constants = {
DRAWER_ROUTE_ABOUT: 'About',
DRAWER_ROUTE_SEARCH: 'Search',
DRAWER_ROUTE_TRANSACTION_HISTORY: 'TransactionHistory',
DRAWER_ROUTE_TAG: 'Tag',
FULL_ROUTE_NAME_DISCOVER: 'DiscoverStack',
FULL_ROUTE_NAME_TRENDING: 'TrendingStack',
@ -76,6 +84,24 @@ const Constants = {
PLAY_STORE_URL: 'https://play.google.com/store/apps/details?id=io.lbry.browser',
RATING_REMINDER_INTERVAL: 604800, // 7 days (7 * 24 * 3600s)
SORT_BY_HOT,
SORT_BY_NEW,
SORT_BY_TOP,
CLAIM_SEARCH_SORT_BY_ITEMS: [
{ icon: 'fire-alt', name: SORT_BY_HOT, label: 'Hot content' },
{ icon: 'certificate', name: SORT_BY_NEW, label: 'New content' },
{ icon: 'chart-line', name: SORT_BY_TOP, label: 'Top content' },
],
DEFAULT_ORDER_BY: ['trending_global', 'trending_mixed'],
DEFAULT_PAGE_SIZE: 10,
ALL_PLACEHOLDER: '_all',
TRUE_STRING: 'true',
};
export default Constants;

View file

@ -42,7 +42,6 @@ import thunk from 'redux-thunk';
const globalExceptionHandler = (error, isFatal) => {
if (error && NativeModules.Firebase) {
console.log(error);
NativeModules.Firebase.logException(isFatal, error.message ? error.message : 'No message', JSON.stringify(error));
}
};
@ -76,9 +75,9 @@ function enableBatching(reducer) {
};
}
/*const router = AppNavigator.router;
/* const router = AppNavigator.router;
const navAction = router.getActionForPathAndParams('FirstRun');
const initialNavState = router.getStateForAction(navAction);*/
const initialNavState = router.getStateForAction(navAction); */
const reducers = combineReducers({
auth: authReducer,
@ -122,10 +121,11 @@ const contentFilter = createFilter('content', ['positions']);
const saveClaimsFilter = createFilter('claims', ['byId', 'claimsByUri']);
const subscriptionsFilter = createFilter('subscriptions', ['enabledChannelNotifications', 'subscriptions']);
const settingsFilter = createFilter('settings', ['clientSettings']);
const tagsFilter = createFilter('tags', ['followedTags']);
const walletFilter = createFilter('wallet', ['receiveAddress']);
const persistOptions = {
whitelist: ['auth', 'claims', 'content', 'subscriptions', 'settings', 'wallet'],
whitelist: ['auth', 'claims', 'content', 'subscriptions', 'settings', 'tags', 'wallet'],
// Order is important. Needs to be compressed last or other transforms can't
// read the data
transforms: [authFilter, saveClaimsFilter, subscriptionsFilter, settingsFilter, walletFilter, compressor],

View file

@ -1,5 +1,12 @@
import { connect } from 'react-redux';
import { doFileList, selectBalance, selectFileInfosDownloaded } from 'lbry-redux';
import {
doClaimSearch,
doFileList,
selectBalance,
selectFileInfosDownloaded,
selectLastClaimSearchUris,
selectFollowedTags,
} from 'lbry-redux';
import {
doFetchFeaturedUris,
doFetchRewardedContent,
@ -11,9 +18,10 @@ import {
selectSubscriptionClaims,
selectUnreadSubscriptions,
} from 'lbryinc';
import { doSetClientSetting } from 'redux/actions/settings';
import { makeSelectClientSetting } from 'redux/selectors/settings';
import Constants from 'constants';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import DiscoverPage from './view';
const select = state => ({
@ -23,12 +31,15 @@ const select = state => ({
featuredUris: selectFeaturedUris(state),
fetchingFeaturedUris: selectFetchingFeaturedUris(state),
fileInfos: selectFileInfosDownloaded(state),
followedTags: selectFollowedTags(state),
ratingReminderDisabled: makeSelectClientSetting(Constants.SETTING_RATING_REMINDER_DISABLED)(state),
ratingReminderLastShown: makeSelectClientSetting(Constants.SETTING_RATING_REMINDER_LAST_SHOWN)(state),
unreadSubscriptions: selectUnreadSubscriptions(state),
uris: selectLastClaimSearchUris(state),
});
const perform = dispatch => ({
doClaimSearch,
fetchFeaturedUris: () => dispatch(doFetchFeaturedUris()),
fetchRewardedContent: () => dispatch(doFetchRewardedContent()),
fetchSubscriptions: () => dispatch(doFetchMySubscriptions()),

View file

@ -1,17 +1,41 @@
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import React from 'react';
import NavigationActions from 'react-navigation';
import { Alert, ActivityIndicator, Linking, NativeModules, SectionList, Text, View } from 'react-native';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import { Lbry, normalizeURI, parseURI } from 'lbry-redux';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
Alert,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
ActivityIndicator,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
Linking,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
NativeModules,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
SectionList,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
Text,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
TouchableOpacity,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
View,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
} from 'react-native';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import { DEFAULT_FOLLOWED_TAGS, Lbry, normalizeURI, parseURI } from 'lbry-redux';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import __, { formatTagTitle } from 'utils/helper';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import AsyncStorage from '@react-native-community/async-storage';
import moment from 'moment';
import CategoryList from 'component/categoryList';
import Constants from 'constants';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import ClaimList from 'component/claimList';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import Colors from 'styles/colors';
import discoverStyle from 'styles/discover';
import FloatingWalletBalance from 'component/floatingWalletBalance';
import Icon from 'react-native-vector-icons/FontAwesome5';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import Link from 'component/link';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import ModalTagSelector from 'component/modalTagSelector';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import ModalPicker from 'component/modalPicker';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
import UriBar from 'component/uriBar';
import _ from 'lodash';
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
class DiscoverPage extends React.PureComponent {
state = {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
tagCollection: [],
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
showModalTagSelector: false,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
showSortPicker: false,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
orderBy: Constants.DEFAULT_ORDER_BY,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
currentSortByItem: Constants.CLAIM_SEARCH_SORT_BY_ITEMS[0],
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
};
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
componentDidMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
@ -19,7 +43,7 @@ class DiscoverPage extends React.PureComponent {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
// We don't need this value anymore once we've retrieved it
AsyncStorage.removeItem('firstLaunchTime');
// We know this is the first app launch because firstLaunchTime is set and it's a valid number
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
// We know this is the first app launch because firstLaunchTime is set and it"s a valid number
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const start = parseInt(startTime, 10);
const now = moment().unix();
const delta = now - start;
@ -36,9 +60,9 @@ class DiscoverPage extends React.PureComponent {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}
});
const { fetchFeaturedUris, fetchRewardedContent, fetchSubscriptions, fileList } = this.props;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const { fetchRewardedContent, fetchSubscriptions, fileList, followedTags } = this.props;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
fetchFeaturedUris();
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
this.buildTagCollection(followedTags);
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
fetchRewardedContent();
fetchSubscriptions();
fileList();
@ -46,6 +70,25 @@ class DiscoverPage extends React.PureComponent {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
this.showRatingReminder();
}
handleSortByItemSelected = item => {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
let orderBy = [];
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
switch (item.name) {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
case Constants.SORT_BY_HOT:
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
orderBy = Constants.DEFAULT_ORDER_BY;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
break;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
case Constants.SORT_BY_NEW:
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
orderBy = ['release_time'];
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
break;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
case Constants.SORT_BY_TOP:
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
orderBy = ['effective_amount'];
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
break;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
this.setState({ currentSortByItem: item, orderBy, showSortPicker: false });
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
};
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
subscriptionForUri = (uri, channelName) => {
const { allSubscriptions } = this.props;
const { claimId, claimName } = parseURI(uri);
@ -63,6 +106,14 @@ class DiscoverPage extends React.PureComponent {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
return null;
};
componentWillReceiveProps(nextProps) {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const { followedTags: prevFollowedTags } = this.props;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const { followedTags } = nextProps;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
if (!_.isEqual(followedTags, prevFollowedTags)) {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
this.buildTagCollection(followedTags);
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
componentDidUpdate(prevProps, prevState) {
const { unreadSubscriptions, enabledChannelNotifications } = this.props;
@ -112,7 +163,7 @@ class DiscoverPage extends React.PureComponent {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const { ratingReminderDisabled, ratingReminderLastShown, setClientSetting } = this.props;
const now = moment().unix();
if ('true' !== ratingReminderDisabled && ratingReminderLastShown) {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
if (ratingReminderDisabled !== 'true' && ratingReminderLastShown) {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const lastShownParts = ratingReminderLastShown.split('|');
if (lastShownParts.length === 2) {
const lastShownTime = parseInt(lastShownParts[0], 10);
@ -154,43 +205,104 @@ class DiscoverPage extends React.PureComponent {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
setClientSetting(Constants.SETTING_RATING_REMINDER_LAST_SHOWN, settingString);
};
trimClaimIdFromCategory(category) {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
return category.split('#')[0];
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
buildSections = () => {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
return this.state.tagCollection.map(tags => ({
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
title: tags.length === 1 ? tags[0] : 'Trending',
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
data: [tags],
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}));
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
};
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
buildTagCollection = followedTags => {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const tags = followedTags.map(tag => tag.name);
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
// each of the followed tags
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const tagCollection = tags.map(tag => [tag]);
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
// everything
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
tagCollection.unshift(tags);
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
this.setState({ tagCollection });
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
};
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
handleTagPress = name => {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const { navigation } = this.props;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
if (name.toLowerCase() !== 'trending') {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
navigation.navigate({ routeName: Constants.DRAWER_ROUTE_TAG, key: `tagPage`, params: { tag: name } });
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
} else {
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
// navigate to the trending page
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
navigation.navigate({ routeName: Constants.FULL_ROUTE_NAME_TRENDING });
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
};
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
render() {
const { featuredUris, fetchingFeaturedUris, navigation } = this.props;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const hasContent = typeof featuredUris === 'object' && Object.keys(featuredUris).length,
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
failedToLoad = !fetchingFeaturedUris && !hasContent;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const { navigation } = this.props;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
const { currentSortByItem, orderBy, showModalTagSelector, showSortPicker } = this.state;
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
return (
<View style={discoverStyle.container}>
<UriBar navigation={navigation} />
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
{!hasContent && fetchingFeaturedUris && (
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<View style={discoverStyle.busyContainer}>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<ActivityIndicator size="large" color={Colors.LbryGreen} />
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<Text style={discoverStyle.title}>Fetching content...</Text>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
</View>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
)}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
{!!hasContent && (
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<SectionList
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
style={discoverStyle.scrollContainer}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
contentContainerStyle={discoverStyle.scrollPadding}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
initialNumToRender={4}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
maxToRenderPerBatch={4}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
removeClippedSubviews={true}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
renderItem={({ item, index, section }) => (
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<CategoryList key={item} category={item} categoryMap={featuredUris} navigation={navigation} />
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
)}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
renderSectionHeader={({ section: { title } }) => <Text style={discoverStyle.categoryName}>{title}</Text>}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
sections={Object.keys(featuredUris).map(category => ({
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
title: this.trimClaimIdFromCategory(category),
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
data: [category],
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}))}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
keyExtractor={(item, index) => item}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<UriBar navigation={navigation} belowOverlay={showModalTagSelector} />
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<SectionList
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
ListHeaderComponent={
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<View style={discoverStyle.titleRow}>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<Text style={discoverStyle.pageTitle}>Explore</Text>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<View style={discoverStyle.rightTitleRow}>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<Link
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
style={discoverStyle.customizeLink}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
text={'Customize'}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
onPress={() => this.setState({ showModalTagSelector: true })}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
/>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<TouchableOpacity
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
style={discoverStyle.tagSortBy}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
onPress={() => this.setState({ showSortPicker: true })}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<Text style={discoverStyle.tagSortText}>{currentSortByItem.label.split(' ')[0]}</Text>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<Icon style={discoverStyle.tagSortIcon} name={'sort-down'} size={14} />
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
</TouchableOpacity>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
</View>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
</View>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
style={discoverStyle.scrollContainer}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
contentContainerStyle={discoverStyle.scrollPadding}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
initialNumToRender={4}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
maxToRenderPerBatch={4}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
removeClippedSubviews
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
renderItem={({ item, index, section }) => (
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<ClaimList
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
key={item.join(',')}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
orderBy={item.length > 1 ? Constants.DEFAULT_ORDER_BY : orderBy}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
tags={item}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
navigation={navigation}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
orientation={Constants.ORIENTATION_HORIZONTAL}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
/>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
)}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
renderSectionHeader={({ section: { title } }) => (
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<View style={discoverStyle.categoryTitleRow}>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<Text style={discoverStyle.categoryName} onPress={() => this.handleTagPress(title)}>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
{formatTagTitle(title)}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
</Text>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<TouchableOpacity onPress={() => this.handleTagPress(title)}>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<Icon name={'ellipsis-v'} size={16} />
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
</TouchableOpacity>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
</View>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
)}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
sections={this.buildSections()}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
keyExtractor={(item, index) => item}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
/>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
{!showModalTagSelector && !showSortPicker && <FloatingWalletBalance navigation={navigation} />}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
{showModalTagSelector && (
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<ModalTagSelector
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
onOverlayPress={() => this.setState({ showModalTagSelector: false })}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
onDonePress={() => this.setState({ showModalTagSelector: false })}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
/>
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
)}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
{showSortPicker && (
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
<ModalPicker
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
title={__('Sort content by')}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
onOverlayPress={() => this.setState({ showSortPicker: false })}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
onItemSelected={this.handleSortByItemSelected}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
selectedItem={currentSortByItem}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
items={Constants.CLAIM_SEARCH_SORT_BY_ITEMS}
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
/>
)}
<FloatingWalletBalance navigation={navigation} />
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
</View>
);
}

kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!
kauffj commented 2019-07-24 19:57:14 +02:00 (Migrated from github.com)
Review

we have a find and replace spill in aisle 5

we have a find and replace spill in aisle 5
akinwale commented 2019-07-26 08:52:58 +02:00 (Migrated from github.com)
Review

I don't even know how I managed this!

I don't even know how I managed this!

View file

@ -25,7 +25,7 @@ import Button from 'component/button';
import Tag from 'component/tag';
import ChannelPage from 'page/channel';
import Colors from 'styles/colors';
import Constants from 'constants';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import DateTime from 'component/dateTime';
import FileDownloadButton from 'component/fileDownloadButton';
import FileItemMedia from 'component/fileItemMedia';
@ -379,23 +379,23 @@ class FilePage extends React.PureComponent {
tokens.length === 0
? ''
: tokens.map((token, j) => {
let hasSpace = j !== tokens.length - 1;
let space = hasSpace ? ' ' : '';
let hasSpace = j !== tokens.length - 1;
let space = hasSpace ? ' ' : '';
if (token.match(/^(lbry|https?):\/\//g)) {
return (
<Link
key={j}
style={filePageStyle.link}
href={token}
text={token}
effectOnTap={filePageStyle.linkTapped}
/>
);
} else {
return token + space;
}
});
if (token.match(/^(lbry|https?):\/\//g)) {
return (
<Link
key={j}
style={filePageStyle.link}
href={token}
text={token}
effectOnTap={filePageStyle.linkTapped}
/>
);
} else {
return token + space;
}
});
lineContent.push('\n');
return <Text key={i}>{lineContent}</Text>;
@ -503,7 +503,10 @@ class FilePage extends React.PureComponent {
};
renderTags = tags => {
return tags.map((tag, i) => <Tag style={filePageStyle.tagItem} key={`${tag}-${i}`} name={tag} />);
const { navigation } = this.props;
return tags.map((tag, i) => (
<Tag style={filePageStyle.tagItem} key={`${tag}-${i}`} name={tag} navigation={navigation} />
));
};
onFileDownloadButtonPlayed = () => {
@ -637,15 +640,15 @@ class FilePage extends React.PureComponent {
this.state.isLandscape
? filePageStyle.containedPlayerLandscape
: this.state.fullscreenMode
? filePageStyle.fullscreenPlayer
: filePageStyle.containedPlayer,
? filePageStyle.fullscreenPlayer
: filePageStyle.containedPlayer,
];
const playerBgStyle = [filePageStyle.playerBackground, filePageStyle.containedPlayerBackground];
const fsPlayerBgStyle = [filePageStyle.playerBackground, filePageStyle.fullscreenPlayerBackground];
// at least 2MB (or the full download) before media can be loaded
const canLoadMedia =
this.state.streamingMode ||
(fileInfo && (fileInfo.written_bytes >= 2097152 || fileInfo.written_bytes == fileInfo.total_bytes)); // 2MB = 1024*1024*2
(fileInfo && (fileInfo.written_bytes >= 2097152 || fileInfo.written_bytes === fileInfo.total_bytes)); // 2MB = 1024*1024*2
const isViewable = mediaType === 'image' || mediaType === 'text';
const isWebViewable = mediaType === 'text';
const canOpen = isViewable && completed;
@ -679,7 +682,7 @@ class FilePage extends React.PureComponent {
fileInfo &&
!this.state.autoDownloadStarted &&
this.state.uriVars &&
'true' === this.state.uriVars.download
this.state.uriVars.download === 'true'
) {
this.setState({ autoDownloadStarted: true }, () => {
purchaseUri(uri, costInfo, !isPlayable);
@ -727,17 +730,17 @@ class FilePage extends React.PureComponent {
canOpen ||
(!completed && !this.state.streamingMode)) &&
!this.state.downloadPressed && (
<FileDownloadButton
uri={uri}
style={filePageStyle.downloadButton}
openFile={openFile}
isPlayable={isPlayable}
isViewable={isViewable}
onPlay={this.onFileDownloadButtonPlayed}
onView={() => this.setState({ downloadPressed: true })}
onButtonLayout={() => this.setState({ downloadButtonShown: true })}
/>
)}
<FileDownloadButton
uri={uri}
style={filePageStyle.downloadButton}
openFile={openFile}
isPlayable={isPlayable}
isViewable={isViewable}
onPlay={this.onFileDownloadButtonPlayed}
onView={() => this.setState({ downloadPressed: true })}
onButtonLayout={() => this.setState({ downloadButtonShown: true })}
/>
)}
{!fileInfo && (
<FilePrice
uri={uri}
@ -808,14 +811,14 @@ class FilePage extends React.PureComponent {
!fileInfo.stopped &&
fileInfo.written_bytes < fileInfo.total_bytes &&
!this.state.stopDownloadConfirmed && (
<Button
style={filePageStyle.actionButton}
icon={'stop'}
theme={'light'}
text={'Stop Download'}
onPress={this.onStopDownloadPressed}
/>
)}
<Button
style={filePageStyle.actionButton}
icon={'stop'}
theme={'light'}
text={'Stop Download'}
onPress={this.onStopDownloadPressed}
/>
)}
</View>
)}
</View>
@ -833,7 +836,7 @@ class FilePage extends React.PureComponent {
onPress={() => this.setState({ showDescription: !this.state.showDescription })}
>
<View style={filePageStyle.titleRow}>
<Text style={filePageStyle.title} selectable={true}>
<Text style={filePageStyle.title} selectable>
{title}
</Text>
<View style={filePageStyle.descriptionToggle}>
@ -846,7 +849,7 @@ class FilePage extends React.PureComponent {
<View style={filePageStyle.publishInfo}>
<Link
style={filePageStyle.channelName}
selectable={true}
selectable
text={channelName}
numberOfLines={1}
ellipsizeMode={'tail'}
@ -865,13 +868,13 @@ class FilePage extends React.PureComponent {
<View style={filePageStyle.subscriptionRow}>
{false &&
((isPlayable && !fileInfo) || (isPlayable && fileInfo && !fileInfo.download_path)) && (
<Button
style={[filePageStyle.actionButton, filePageStyle.saveFileButton]}
theme={'light'}
icon={'download'}
onPress={this.onSaveFilePressed}
/>
)}
<Button
style={[filePageStyle.actionButton, filePageStyle.saveFileButton]}
theme={'light'}
icon={'download'}
onPress={this.onSaveFilePressed}
/>
)}
<Button
style={[filePageStyle.actionButton, filePageStyle.tipButton]}
theme={'light'}
@ -928,7 +931,7 @@ class FilePage extends React.PureComponent {
)}
{this.state.showDescription && description && (
<View>
<Text style={filePageStyle.description} selectable={true}>
<Text style={filePageStyle.description} selectable>
{this.linkify(description)}
</Text>
{tags && tags.length > 0 && (

View file

@ -22,7 +22,7 @@ import RNFS from 'react-native-fs';
import Button from 'component/button';
import ChannelSelector from 'component/channelSelector';
import Colors from 'styles/colors';
import Constants from 'constants';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import FastImage from 'react-native-fast-image';
import FloatingWalletBalance from 'component/floatingWalletBalance';
import Icon from 'react-native-vector-icons/FontAwesome5';
@ -384,7 +384,7 @@ class PublishPage extends React.PureComponent {
},
(error, res) => {
if (!error) {
//console.log(res);
// console.log(res);
}
}
);
@ -439,7 +439,7 @@ class PublishPage extends React.PureComponent {
newTags.push(tag);
this.setState({ tags: newTags });
} else {
notify({ message: `You already added the "${tag}" tag.` });
notify({ message: __(`You already added the "${tag}" tag.`) });
}
};
@ -471,7 +471,7 @@ class PublishPage extends React.PureComponent {
const mediaType = media.type.substring(0, 5);
const tempId = this.getRandomFileId();
if ('video' === mediaType && media.id > -1) {
if (mediaType === 'video' && media.id > -1) {
const uri = `file://${thumbnailPath}/${media.id}.png`;
this.setState({ currentThumbnailUri: uri, updatingThumbnailUri: false });
@ -479,9 +479,9 @@ class PublishPage extends React.PureComponent {
if (!this.state.uploadedThumbnailUri) {
this.setState({ uploadThumbnailStarted: true }, () => uploadThumbnail(this.getFilePathFromUri(uri), RNFS));
}
} else if ('image' === mediaType || 'video' === mediaType) {
} else if (mediaType === 'image' || mediaType === 'video') {
const create =
'image' === mediaType
mediaType === 'image'
? NativeModules.Gallery.createImageThumbnail
: NativeModules.Gallery.createVideoThumbnail;
create(tempId, media.filePath)
@ -867,13 +867,7 @@ class PublishPage extends React.PureComponent {
<View style={publishStyle.cameraAction}>
<Feather style={publishStyle.cameraActionIcon} name="circle" size={72} color={Colors.White} />
{this.state.recordingVideo && (
<Icon
style={publishStyle.recordingIcon}
name="circle"
solid={true}
size={44}
color={Colors.Red}
/>
<Icon style={publishStyle.recordingIcon} name="circle" solid size={44} color={Colors.Red} />
)}
</View>
</TouchableOpacity>

View file

@ -1,24 +1,41 @@
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import React from 'react';
import NavigationActions from 'react-navigation';
import { ActivityIndicator, FlatList, NativeModules, SectionList, ScrollView, Text, View } from 'react-native';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
ActivityIndicator,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
FlatList,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
NativeModules,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
SectionList,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
ScrollView,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
Text,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
TouchableOpacity,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
View,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
} from 'react-native';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import { buildURI, parseURI } from 'lbry-redux';
import { uriFromFileInfo } from 'utils/helper';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import __, { uriFromFileInfo } from 'utils/helper';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import AsyncStorage from '@react-native-community/async-storage';
import moment from 'moment';
import Button from 'component/button';
import ClaimList from 'component/claimList';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import Colors from 'styles/colors';
import Constants from 'constants';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import fileListStyle from 'styles/fileList';
import subscriptionsStyle from 'styles/subscriptions';
import FloatingWalletBalance from 'component/floatingWalletBalance';
import FileItem from 'component/fileItem';
import Icon from 'react-native-vector-icons/FontAwesome5';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import Link from 'component/link';
import ModalPicker from 'component/modalPicker';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import SubscribedChannelList from 'component/subscribedChannelList';
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
import SuggestedSubscriptions from 'component/suggestedSubscriptions';
import UriBar from 'component/uriBar';
class SubscriptionsPage extends React.PureComponent {
state = {
showingSuggestedSubs: false,
showSortPicker: false,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
orderBy: ['release_time'],
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
filteredChannels: [],
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
currentSortByItem: Constants.CLAIM_SEARCH_SORT_BY_ITEMS[1], // should always default to sorting subscriptions by new
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
};
didFocusListener;
@ -48,7 +65,6 @@ class SubscriptionsPage extends React.PureComponent {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
setPlayerVisible();
doFetchMySubscriptions();
doFetchRecommendedSubscriptions();
doSetViewMode(subscriptionsViewMode ? subscriptionsViewMode : Constants.SUBSCRIPTIONS_VIEW_ALL);
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
};
componentDidMount() {
@ -63,10 +79,38 @@ class SubscriptionsPage extends React.PureComponent {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
}
}
changeViewMode = viewMode => {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
const { setClientSetting, doSetViewMode } = this.props;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
setClientSetting(Constants.SETTING_SUBSCRIPTIONS_VIEW_MODE, viewMode);
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
doSetViewMode(viewMode);
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
handleSortByItemSelected = item => {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
let orderBy = [];
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
switch (item.name) {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
case Constants.SORT_BY_HOT:
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
orderBy = Constants.DEFAULT_ORDER_BY;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
break;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
case Constants.SORT_BY_NEW:
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
orderBy = ['release_time'];
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
break;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
case Constants.SORT_BY_TOP:
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
orderBy = ['effective_amount'];
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
break;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
this.setState({ currentSortByItem: item, orderBy, showSortPicker: false });
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
};
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
handleChannelSelected = channelUri => {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
const { subscribedChannels } = this.props;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
this.setState({
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
filteredChannels:
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
channelUri === Constants.ALL_PLACEHOLDER
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
? []
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
: subscribedChannels.filter(channel => channel.uri === channelUri),
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
});
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
};
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
prependSubscribedChannelsWithAll = subscribedChannels => {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
const channelUris = subscribedChannels.map(channel => channel.uri);
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
return [Constants.ALL_PLACEHOLDER].concat(channelUris);
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
};
render() {
@ -84,6 +128,7 @@ class SubscriptionsPage extends React.PureComponent {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
unreadSubscriptions,
navigation,
} = this.props;
const { currentSortByItem, filteredChannels } = this.state;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
const numberOfSubscriptions = subscribedChannels ? subscribedChannels.length : 0;
const hasSubscriptions = numberOfSubscriptions > 0;
@ -92,91 +137,46 @@ class SubscriptionsPage extends React.PureComponent {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
this.setState({ showingSuggestedSubs: true });
}
const channelIds =
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
filteredChannels.length > 0
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
? filteredChannels.map(channel => {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
const { claimId } = parseURI(channel.uri);
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
return claimId;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
})
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
: subscribedChannels &&
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
subscribedChannels.map(channel => {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
const { claimId } = parseURI(channel.uri);
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
return claimId;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
});
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
return (
<View style={subscriptionsStyle.container}>
<UriBar navigation={navigation} />
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{!this.state.showingSuggestedSubs && hasSubscriptions && !loading && (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<View style={subscriptionsStyle.viewModeRow}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<Link
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
text={'All Subscriptions'}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
style={[
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
subscriptionsStyle.viewModeLink,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
viewMode === Constants.SUBSCRIPTIONS_VIEW_ALL
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
? subscriptionsStyle.activeMode
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
: subscriptionsStyle.inactiveMode,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
]}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
onPress={() => this.changeViewMode(Constants.SUBSCRIPTIONS_VIEW_ALL)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
/>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<Link
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
text={'Latest Only'}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
style={[
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
subscriptionsStyle.viewModeLink,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
viewMode === Constants.SUBSCRIPTIONS_VIEW_LATEST_FIRST
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
? subscriptionsStyle.activeMode
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
: subscriptionsStyle.inactiveMode,
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
]}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
onPress={() => this.changeViewMode(Constants.SUBSCRIPTIONS_VIEW_LATEST_FIRST)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
/>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</View>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<UriBar navigation={navigation} belowOverlay={this.state.showSortPicker} />
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<View style={subscriptionsStyle.titleRow}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<Text style={subscriptionsStyle.pageTitle}>Channels you follow</Text>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{!this.state.showingSuggestedSubs && hasSubscriptions && (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<TouchableOpacity
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
style={subscriptionsStyle.tagSortBy}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
onPress={() => this.setState({ showSortPicker: true })}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<Text style={subscriptionsStyle.tagSortText}>{currentSortByItem.label.split(' ')[0]}</Text>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<Icon style={subscriptionsStyle.tagSortIcon} name={'sort-down'} size={14} />
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</TouchableOpacity>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</View>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{!this.state.showingSuggestedSubs && hasSubscriptions && !loading && (
<View style={subscriptionsStyle.subContainer}>
{viewMode === Constants.SUBSCRIPTIONS_VIEW_ALL && (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<FlatList
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
style={subscriptionsStyle.scrollContainer}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
contentContainerStyle={subscriptionsStyle.scrollPadding}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
renderItem={({ item }) => (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<FileItem
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
style={subscriptionsStyle.fileItem}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
mediaStyle={fileListStyle.fileItemMedia}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
key={item}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
uri={uriFromFileInfo(item)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
navigation={navigation}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
compactView={false}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
showDetails={true}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
/>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
data={allSubscriptions.sort((a, b) => {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
return b.height - a.height;
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
})}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
keyExtractor={(item, index) => uriFromFileInfo(item)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
/>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{viewMode === Constants.SUBSCRIPTIONS_VIEW_LATEST_FIRST && (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<View style={subscriptionsStyle.subContainer}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{unreadSubscriptions.length ? (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<ScrollView
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
style={subscriptionsStyle.scrollContainer}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
contentContainerStyle={subscriptionsStyle.scrollPadding}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{unreadSubscriptions.map(({ channel, uris }) => {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
const { claimName } = parseURI(channel);
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
return uris.map(uri => (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<FileItem
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
style={subscriptionsStyle.fileItem}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
mediaStyle={fileListStyle.fileItemMedia}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
key={uri}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
uri={uri}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
navigation={navigation}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
compactView={false}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
showDetails={true}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
/>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
));
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
})}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</ScrollView>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
) : (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<View style={subscriptionsStyle.contentContainer}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<Text style={subscriptionsStyle.contentText}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
All caught up! You might like the channels below.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</Text>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<SuggestedSubscriptions navigation={navigation} />
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</View>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</View>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<SubscribedChannelList
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
subscribedChannels={this.prependSubscribedChannelsWithAll(subscribedChannels)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
onChannelSelected={this.handleChannelSelected}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
/>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<ClaimList
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
style={subscriptionsStyle.claimList}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
channelIds={channelIds}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
orderBy={this.state.orderBy}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
navigation={navigation}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
orientation={Constants.ORIENTATION_VERTICAL}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
/>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</View>
)}
@ -189,14 +189,13 @@ class SubscriptionsPage extends React.PureComponent {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{this.state.showingSuggestedSubs && (
<View style={subscriptionsStyle.suggestedSubsContainer}>
{!hasSubscriptions && (
<Text style={subscriptionsStyle.infoText}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
You are not subscribed to any channels at the moment. Here are some channels that we think you might
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
enjoy.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</Text>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<View style={subscriptionsStyle.infoArea}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<Text style={subscriptionsStyle.infoText}>You are not subscribed to any channels at the moment.</Text>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</View>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
{hasSubscriptions && (
<View>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<View style={subscriptionsStyle.infoArea}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<Text style={subscriptionsStyle.infoText}>
You are currently subscribed to {numberOfSubscriptions} channel{numberOfSubscriptions > 1 ? 's' : ''}.
</Text>
@ -209,13 +208,25 @@ class SubscriptionsPage extends React.PureComponent {
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
{loadingSuggested && (
<ActivityIndicator size="large" colors={Colors.LbryGreen} style={subscriptionsStyle.loading} />
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<View style={subscriptionsStyle.centered}>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<ActivityIndicator size="large" colors={Colors.LbryGreen} style={subscriptionsStyle.loading} />
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
\\
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</View>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
{!loadingSuggested && <SuggestedSubscriptions navigation={navigation} />}
</View>
)}
<FloatingWalletBalance navigation={navigation} />
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{!this.state.showSortPicker && <FloatingWalletBalance navigation={navigation} />}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
{this.state.showSortPicker && (
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
<ModalPicker
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
title={__('Sort content by')}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
onOverlayPress={() => this.setState({ showSortPicker: false })}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
onItemSelected={this.handleSortByItemSelected}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
selectedItem={this.state.currentSortByItem}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
items={Constants.CLAIM_SEARCH_SORT_BY_ITEMS}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
/>
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
)}
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
</View>
);
}

kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.
kauffj commented 2019-07-24 20:00:19 +02:00 (Migrated from github.com)
Review

🤢

:nauseated_face:
kauffj commented 2019-07-24 20:02:33 +02:00 (Migrated from github.com)
Review
https://github.com/lbryio/lbry-react-native/pull/2/files#diff-a7748843fbda5167d065231e3a2e7a1fR85 is more constructive than the above emoji
akinwale commented 2019-07-26 09:00:21 +02:00 (Migrated from github.com)
Review

I'm using the entire object at that index here, not just the name value. I would expect the index to always be at the same spot since it is defined as a constant.

I'm using the entire object at that index here, not just the `name` value. I would expect the index to always be at the same spot since it is defined as a constant.

19
src/page/tag/index.js Normal file
View file

@ -0,0 +1,19 @@
import { connect } from 'react-redux';
import { doPushDrawerStack, doSetPlayerVisible } from 'redux/actions/drawer';
import { selectCurrentRoute } from 'redux/selectors/drawer';
import Constants from 'constants';
import TagPage from './view';
const select = state => ({
currentRoute: selectCurrentRoute(state),
});
const perform = dispatch => ({
pushDrawerStack: () => dispatch(doPushDrawerStack(Constants.DRAWER_ROUTE_TAG)),
setPlayerVisible: () => dispatch(doSetPlayerVisible(false)),
});
export default connect(
select,
perform
)(TagPage);

115
src/page/tag/view.js Normal file
View file

@ -0,0 +1,115 @@
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import React from 'react';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import { ActivityIndicator, NativeModules, FlatList, Text, TouchableOpacity, View } from 'react-native';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import { DEFAULT_FOLLOWED_TAGS, normalizeURI } from 'lbry-redux';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import { formatTagTitle } from 'utils/helper';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import AsyncStorage from '@react-native-community/async-storage';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import moment from 'moment';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import ClaimList from 'component/claimList';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import FileItem from 'component/fileItem';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import Icon from 'react-native-vector-icons/FontAwesome5';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import discoverStyle from 'styles/discover';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import fileListStyle from 'styles/fileList';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import Colors from 'styles/colors';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import FloatingWalletBalance from 'component/floatingWalletBalance';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import ModalPicker from 'component/modalPicker';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
import UriBar from 'component/uriBar';
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
class TagPage extends React.PureComponent {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
state = {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
tag: null,
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
showSortPicker: false,
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
orderBy: Constants.DEFAULT_ORDER_BY,
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
currentSortByItem: Constants.CLAIM_SEARCH_SORT_BY_ITEMS[0],
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
};
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
didFocusListener;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
componentWillMount() {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
const { navigation } = this.props;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
this.didFocusListener = navigation.addListener('didFocus', this.onComponentFocused);
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
componentWillUnmount() {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
if (this.didFocusListener) {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
this.didFocusListener.remove();
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
onComponentFocused = () => {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
const { pushDrawerStack, setPlayerVisible, navigation } = this.props;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
this.setState({ tag: navigation.state.params.tag });
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
pushDrawerStack();
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
setPlayerVisible();
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
};
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
componentDidMount() {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
this.onComponentFocused();
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
componentWillReceiveProps(nextProps) {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
const { currentRoute, navigation } = nextProps;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
const { currentRoute: prevRoute } = this.props;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
if (Constants.DRAWER_ROUTE_TAG === currentRoute && currentRoute !== prevRoute) {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
this.onComponentFocused();
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
handleSortByItemSelected = item => {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
let orderBy = [];
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
switch (item.name) {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
case Constants.SORT_BY_HOT:
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
orderBy = Constants.DEFAULT_ORDER_BY;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
break;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
case Constants.SORT_BY_NEW:
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
orderBy = ['release_time'];
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
break;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
case Constants.SORT_BY_TOP:
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
orderBy = ['effective_amount'];
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
break;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
this.setState({ currentSortByItem: item, orderBy, showSortPicker: false });
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
};
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
render() {
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
const { navigation } = this.props;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
const { tag, currentSortByItem } = this.state;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
return (
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<View style={discoverStyle.container}>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<UriBar navigation={navigation} belowOverlay={this.state.showSortPicker} />
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<ClaimList
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
ListHeaderComponent={
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<View style={discoverStyle.tagTitleRow}>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<Text style={discoverStyle.tagPageTitle}>{formatTagTitle(tag)}</Text>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<TouchableOpacity style={discoverStyle.tagSortBy} onPress={() => this.setState({ showSortPicker: true })}>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<Text style={discoverStyle.tagSortText}>{currentSortByItem.label.split(' ')[0]}</Text>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<Icon style={discoverStyle.tagSortIcon} name={'sort-down'} size={14} />
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
</TouchableOpacity>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
</View>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
style={discoverStyle.tagPageClaimList}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
orderBy={this.state.orderBy}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
tags={[tag]}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
navigation={navigation}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
orientation={Constants.ORIENTATION_VERTICAL}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
/>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
{!this.state.showSortPicker && <FloatingWalletBalance navigation={navigation} />}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
{this.state.showSortPicker && (
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
<ModalPicker
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
title={__('Sort content by')}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
onOverlayPress={() => this.setState({ showSortPicker: false })}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
onItemSelected={this.handleSortByItemSelected}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
selectedItem={this.state.currentSortByItem}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
items={Constants.CLAIM_SEARCH_SORT_BY_ITEMS}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
/>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
)}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
</View>
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
);
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
}
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.
export default TagPage;
kauffj commented 2019-07-24 20:03:57 +02:00 (Migrated from github.com)
Review

.

.

View file

@ -1,18 +1,16 @@
import { connect } from 'react-redux';
import { doFetchTrendingUris, selectTrendingUris, selectFetchingTrendingUris } from 'lbryinc';
import { selectFollowedTags } from 'lbry-redux';
import { doPushDrawerStack, doSetPlayerVisible } from 'redux/actions/drawer';
import { selectCurrentRoute } from 'redux/selectors/drawer';
import Constants from 'constants';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import TrendingPage from './view';
const select = state => ({
currentRoute: selectCurrentRoute(state),
trendingUris: selectTrendingUris(state),
fetchingTrendingUris: selectFetchingTrendingUris(state),
followedTags: selectFollowedTags(state),
});
const perform = dispatch => ({
fetchTrendingUris: () => dispatch(doFetchTrendingUris()),
pushDrawerStack: () => dispatch(doPushDrawerStack(Constants.DRAWER_ROUTE_TRENDING)),
setPlayerVisible: () => dispatch(doSetPlayerVisible(false)),
});

View file

@ -1,17 +1,32 @@
import React from 'react';
import { ActivityIndicator, NativeModules, FlatList, Text, View } from 'react-native';
import { normalizeURI } from 'lbry-redux';
import { ActivityIndicator, NativeModules, FlatList, Text, TouchableOpacity, View } from 'react-native';
import { DEFAULT_FOLLOWED_TAGS, normalizeURI } from 'lbry-redux';
import AsyncStorage from '@react-native-community/async-storage';
import moment from 'moment';
import ClaimList from 'component/claimList';
import FileItem from 'component/fileItem';
import discoverStyle from 'styles/discover';
import fileListStyle from 'styles/fileList';
import Link from 'component/link';
import ModalPicker from 'component/modalPicker';
import ModalTagSelector from 'component/modalTagSelector';
import Colors from 'styles/colors';
import Constants from 'constants';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import FloatingWalletBalance from 'component/floatingWalletBalance';
import Icon from 'react-native-vector-icons/FontAwesome5';
import UriBar from 'component/uriBar';
import discoverStyle from 'styles/discover';
const TRENDING_FOR_ITEMS = [
{ icon: 'globe-americas', name: 'everyone', label: 'Everyone' },
{ icon: 'hashtag', name: 'tags', label: 'Tags you follow' },
];
class TrendingPage extends React.PureComponent {
state = {
showModalTagSelector: false,
showTrendingForPicker: false,
currentTrendingForItem: TRENDING_FOR_ITEMS[0],
};
didFocusListener;
componentWillMount() {
kauffj commented 2019-07-24 20:05:11 +02:00 (Migrated from github.com)
Review

use same pattern as above

also if all usage of values is confined to a single file I don't feel nearly as strongly about using constant patterns

the insistence on constant patterns is significantly driven by making inter-dependencies clear and explicit

use same pattern as above also if all usage of values is confined to a single file I don't feel nearly as strongly about using constant patterns the insistence on constant patterns is significantly driven by making inter-dependencies clear and explicit
@ -26,10 +41,9 @@ class TrendingPage extends React.PureComponent {
}
onComponentFocused = () => {
const { fetchTrendingUris, pushDrawerStack, setPlayerVisible } = this.props;
const { pushDrawerStack, setPlayerVisible } = this.props;
pushDrawerStack();
setPlayerVisible();
fetchTrendingUris();
};
componentDidMount() {
@ -44,39 +58,62 @@ class TrendingPage extends React.PureComponent {
}
}
handleTrendingForItemSelected = item => {
this.setState({ currentTrendingForItem: item, showTrendingForPicker: false });
};
render() {
const { trendingUris, fetchingTrendingUris, navigation } = this.props;
const hasContent = typeof trendingUris === 'object' && trendingUris.length,
failedToLoad = !fetchingTrendingUris && !hasContent;
const { followedTags, navigation } = this.props;
const { currentTrendingForItem, showModalTagSelector, showTrendingForPicker } = this.state;
return (
<View style={discoverStyle.container}>
<UriBar navigation={navigation} />
{!hasContent && fetchingTrendingUris && (
<View style={discoverStyle.busyContainer}>
<ActivityIndicator size="large" color={Colors.LbryGreen} />
<Text style={discoverStyle.title}>Fetching content...</Text>
</View>
)}
{hasContent && (
<FlatList
style={discoverStyle.trendingContainer}
renderItem={({ item }) => (
<FileItem
style={fileListStyle.fileItem}
mediaStyle={fileListStyle.fileItemMedia}
key={item}
uri={normalizeURI(item)}
navigation={navigation}
showDetails={true}
compactView={false}
/>
)}
data={trendingUris.map(uri => uri.url)}
keyExtractor={(item, index) => item}
<ClaimList
ListHeaderComponent={
<View style={discoverStyle.titleRow}>
<Text style={discoverStyle.pageTitle}>Trending</Text>
<View style={discoverStyle.rightTitleRow}>
{TRENDING_FOR_ITEMS[1].name === currentTrendingForItem.name && (
<Link
style={discoverStyle.customizeLink}
text={'Customize'}
onPress={() => this.setState({ showModalTagSelector: true })}
/>
)}
<TouchableOpacity
style={discoverStyle.tagSortBy}
onPress={() => this.setState({ showTrendingForPicker: true })}
>
<Text style={discoverStyle.tagSortText}>{currentTrendingForItem.label.split(' ')[0]}</Text>
<Icon style={discoverStyle.tagSortIcon} name={'sort-down'} size={14} />
</TouchableOpacity>
</View>
</View>
}
style={discoverStyle.verticalClaimList}
orderBy={Constants.DEFAULT_ORDER_BY}
trendingForAll={TRENDING_FOR_ITEMS[0].name === currentTrendingForItem.name}
tags={followedTags.map(tag => tag.name)}
navigation={navigation}
orientation={Constants.ORIENTATION_VERTICAL}
/>
{!showModalTagSelector && <FloatingWalletBalance navigation={navigation} />}
{showModalTagSelector && (
<ModalTagSelector
onOverlayPress={() => this.setState({ showModalTagSelector: false })}
onDonePress={() => this.setState({ showModalTagSelector: false })}
/>
)}
{showTrendingForPicker && (
<ModalPicker
title={'Trending for'}
onOverlayPress={() => this.setState({ showTrendingForPicker: false })}
onItemSelected={this.handleTrendingForItemSelected}
selectedItem={currentTrendingForItem}
items={TRENDING_FOR_ITEMS}
/>
)}
<FloatingWalletBalance navigation={navigation} />
</View>
);
}

48
src/styles/channelIcon.js Normal file
View file

@ -0,0 +1,48 @@
import { StyleSheet } from 'react-native';
import Colors from './colors';
const channelIconStyle = StyleSheet.create({
container: {
flex: 1,
justifyContent: 'center',
alignItems: 'center',
marginRight: 16,
alignSelf: 'flex-start',
},
placeholderText: {
fontFamily: 'Inter-UI-SemiBold',
fontSize: 14,
},
thumbnailContainer: {
width: 80,
height: 80,
borderRadius: 160,
overflow: 'hidden',
},
borderedThumbnailContainer: {
borderWidth: 1,
borderColor: Colors.LighterGrey,
},
thumbnail: {
width: '100%',
height: '100%',
},
centered: {
position: 'absolute',
left: 0,
right: 0,
top: 0,
bottom: 0,
alignItems: 'center',
justifyContent: 'center',
},
title: {
fontFamily: 'Inter-UI-Regular',
fontSize: 12,
width: 80,
marginTop: 4,
textAlign: 'center',
},
});
export default channelIconStyle;

34
src/styles/claimList.js Normal file
View file

@ -0,0 +1,34 @@
import { StyleSheet } from 'react-native';
import Colors from './colors';
const claimListStyle = StyleSheet.create({
horizontalScrollContainer: {
marginBottom: 12,
},
horizontalScrollPadding: {
paddingLeft: 16,
},
verticalScrollContainer: {
flex: 1,
},
verticalScrollPadding: {
paddingBottom: 16,
},
verticalListItem: {
flex: 1,
flexDirection: 'row',
justifyContent: 'space-between',
marginLeft: 8,
marginRight: 8,
marginTop: 4,
marginBottom: 4,
},
verticalLoading: {
width: '100%',
height: 48,
alignItems: 'center',
justifyContent: 'center',
},
});
export default claimListStyle;

View file

@ -27,8 +27,28 @@ const discoverStyle = StyleSheet.create({
},
scrollContainer: {
flex: 1,
paddingTop: 12,
marginTop: 60,
},
titleRow: {
flexDirection: 'row',
marginTop: 76,
marginBottom: 8,
alignItems: 'center',
justifyContent: 'space-between',
marginLeft: 16,
marginRight: 16,
},
rightTitleRow: {
flexDirection: 'row',
alignItems: 'center',
},
pageTitle: {
fontFamily: 'Inter-UI-Regular',
fontSize: 24,
},
customizeLink: {
fontFamily: 'Inter-UI-Regular',
fontSize: 14,
marginRight: 48,
},
trendingContainer: {
flex: 1,
@ -47,12 +67,18 @@ const discoverStyle = StyleSheet.create({
textAlign: 'center',
marginLeft: 10,
},
categoryTitleRow: {
flexDirection: 'row',
alignItems: 'center',
justifyContent: 'space-between',
marginLeft: 16,
marginRight: 16,
marginTop: 6,
marginBottom: 6,
},
categoryName: {
fontFamily: 'Inter-UI-SemiBold',
fontSize: 18,
marginLeft: 24,
marginTop: 12,
marginBottom: 6,
color: Colors.Black,
},
fileItem: {
@ -163,12 +189,49 @@ const discoverStyle = StyleSheet.create({
scrollPadding: {
paddingBottom: 24,
},
listLoading: {
flex: 1,
height: 64,
alignItems: 'center',
justifyContent: 'center',
},
horizontalScrollContainer: {
marginBottom: 12,
},
horizontalScrollPadding: {
paddingLeft: 20,
},
verticalClaimList: {
flex: 1,
},
tagPageTitle: {
fontFamily: 'Inter-UI-Regular',
fontSize: 24,
},
tagPageClaimList: {
flex: 1,
},
tagTitleRow: {
marginTop: 76,
marginLeft: 16,
marginRight: 16,
flexDirection: 'row',
alignItems: 'center',
justifyContent: 'space-between',
},
tagSortBy: {
flexDirection: 'row',
alignItems: 'center',
marginRight: 4,
},
tagSortText: {
fontFamily: 'Inter-UI-Regular',
fontSize: 14,
marginRight: 4,
},
tagSortIcon: {
marginTop: -6,
},
});
export default discoverStyle;

65
src/styles/modalPicker.js Normal file
View file

@ -0,0 +1,65 @@
import { StyleSheet } from 'react-native';
import Colors from './colors';
const modalPickerStyle = StyleSheet.create({
overlay: {
backgroundColor: '#00000055',
flex: 1,
position: 'absolute',
left: 0,
right: 0,
top: 0,
bottom: 0,
zIndex: 300,
},
overlayTouchArea: {
position: 'absolute',
left: 0,
right: 0,
top: 0,
bottom: 0,
},
container: {
position: 'absolute',
left: 8,
right: 8,
bottom: 8,
borderRadius: 8,
backgroundColor: Colors.White,
padding: 12,
},
title: {
fontFamily: 'Inter-UI-SemiBold',
fontSize: 12,
marginTop: 4,
textTransform: 'uppercase',
},
listItem: {
paddingTop: 10,
paddingBottom: 10,
flexDirection: 'row',
alignItems: 'center',
},
divider: {
marginTop: 12,
marginBottom: 8,
borderBottomColor: Colors.LighterGrey,
borderBottomWidth: 1,
width: '100%',
},
itemIcon: {
marginLeft: 8,
marginRight: 12,
},
itemLabel: {
alignSelf: 'flex-start',
fontFamily: 'Inter-UI-Regular',
fontSize: 16,
},
itemSelected: {
position: 'absolute',
right: 8,
},
});
export default modalPickerStyle;

View file

@ -0,0 +1,59 @@
import { StyleSheet } from 'react-native';
import Colors from './colors';
const modalTagSelectorStyle = StyleSheet.create({
overlay: {
backgroundColor: '#00000099',
flex: 1,
position: 'absolute',
left: 0,
right: 0,
top: 0,
bottom: 0,
zIndex: 300,
alignItems: 'center',
},
overlayTouchArea: {
position: 'absolute',
left: 0,
right: 0,
top: 0,
bottom: 0,
},
container: {
flex: 1,
borderRadius: 8,
backgroundColor: Colors.White,
padding: 16,
position: 'absolute',
left: 8,
right: 8,
bottom: 8,
},
tag: {
marginRight: 4,
marginBottom: 4,
},
tagList: {
flexDirection: 'row',
flexWrap: 'wrap',
},
titleRow: {
marginBottom: 12,
},
title: {
fontFamily: 'Inter-UI-Regular',
fontSize: 24,
},
buttons: {
marginTop: 16,
},
doneButton: {
alignSelf: 'flex-start',
backgroundColor: Colors.LbryGreen,
paddingLeft: 16,
paddingRight: 16,
},
});
export default modalTagSelectorStyle;

View file

@ -12,15 +12,16 @@ const subscriptionsStyle = StyleSheet.create({
},
suggestedSubsContainer: {
flex: 1,
marginTop: 60,
},
suggestedScrollPadding: {
paddingTop: 8,
},
button: {
alignSelf: 'flex-start',
backgroundColor: Colors.LbryGreen,
paddingLeft: 16,
paddingRight: 16,
marginLeft: 16,
marginBottom: 16,
marginBottom: 8,
},
busyContainer: {
flex: 1,
@ -38,7 +39,15 @@ const subscriptionsStyle = StyleSheet.create({
infoText: {
fontFamily: 'Inter-UI-Regular',
fontSize: 16,
margin: 16,
marginTop: 8,
marginBottom: 8,
},
infoArea: {
marginLeft: 16,
marginRight: 16,
paddingBottom: 4,
borderBottomWidth: 1,
borderBottomColor: Colors.LighterGrey,
},
suggestedContainer: {
flex: 1,
@ -91,6 +100,14 @@ const subscriptionsStyle = StyleSheet.create({
marginTop: 8,
fontSize: 18,
},
channelList: {
marginLeft: 16,
marginRight: 16,
marginTop: 8,
paddingBottom: 8,
borderBottomColor: Colors.LighterGrey,
borderBottomWidth: 1,
},
channelTitle: {
fontFamily: 'Inter-UI-SemiBold',
fontSize: 20,
@ -99,11 +116,6 @@ const subscriptionsStyle = StyleSheet.create({
marginBottom: 16,
color: Colors.LbryGreen,
},
titleRow: {
flex: 1,
flexDirection: 'row',
justifyContent: 'space-between',
},
subscribeButton: {
alignSelf: 'flex-start',
marginRight: 24,
@ -129,6 +141,99 @@ const subscriptionsStyle = StyleSheet.create({
activeMode: {
fontFamily: 'Inter-UI-SemiBold',
},
claimList: {
flex: 1,
},
pageTitle: {
fontFamily: 'Inter-UI-Regular',
fontSize: 24,
},
titleRow: {
marginTop: 76,
marginLeft: 16,
marginRight: 16,
flexDirection: 'row',
alignItems: 'center',
justifyContent: 'space-between',
},
tagSortBy: {
flexDirection: 'row',
alignItems: 'center',
marginRight: 4,
},
tagSortText: {
fontFamily: 'Inter-UI-Regular',
fontSize: 14,
marginRight: 4,
},
tagSortIcon: {
marginTop: -6,
},
centered: {
position: 'absolute',
left: 0,
right: 0,
top: 0,
bottom: 0,
alignItems: 'center',
justifyContent: 'center',
},
suggestedItem: {
flexDirection: 'row',
alignItems: 'center',
marginBottom: 16,
marginLeft: 16,
marginRight: 16,
},
suggestedItemThumbnailContainer: {
width: 70,
height: 70,
borderRadius: 140,
overflow: 'hidden',
},
suggestedItemThumbnail: {
width: '100%',
height: '100%',
},
suggestedItemDetails: {
marginLeft: 16,
flexDirection: 'row',
},
suggestedItemSubscribe: {
backgroundColor: Colors.White,
position: 'absolute',
right: 0,
top: 0,
},
suggestedItemTitle: {
fontFamily: 'Inter-UI-Regular',
fontSize: 16,
marginBottom: 4,
},
suggestedItemName: {
fontFamily: 'Inter-UI-SemiBold',
fontSize: 14,
marginBottom: 4,
color: Colors.LbryGreen,
},
suggestedItemTagList: {
flexDirection: 'row',
flexWrap: 'wrap',
},
suggestedSubTitle: {
fontFamily: 'Inter-UI-Regular',
fontSize: 20,
marginLeft: 16,
marginRight: 16,
marginBottom: 12,
},
suggestedSectionSeparator: {
marginBottom: 16,
},
tag: {
marginRight: 4,
marginBottom: 4,
},
});
export default subscriptionsStyle;

View file

@ -16,6 +16,8 @@ const uriBarStyle = StyleSheet.create({
shadowOffset: {
height: StyleSheet.hairlineWidth,
},
},
containerElevated: {
elevation: 4,
},
uriText: {
@ -34,6 +36,8 @@ const uriBarStyle = StyleSheet.create({
top: 0,
width: '100%',
zIndex: 200,
},
overlayElevated: {
elevation: 16,
},
inFocus: {

View file

@ -227,7 +227,7 @@ const walletStyle = StyleSheet.create({
marginTop: 16,
paddingBottom: 14,
borderBottomWidth: 1,
borderBottomColor: Colors.PageBackground
borderBottomColor: Colors.PageBackground,
},
syncDriverLink: {
color: Colors.LbryGreen,

View file

@ -1,8 +1,7 @@
import { NavigationActions, StackActions } from 'react-navigation';
import { buildURI, isURIValid } from 'lbry-redux';
import { doPopDrawerStack, doPushDrawerStack, doSetPlayerVisible } from 'redux/actions/drawer';
import { DrawerRoutes } from 'constants';
import Constants from 'constants';
import Constants, { DrawerRoutes } from 'constants'; // eslint-disable-line node/no-deprecated-api
function getRouteForSpecialUri(uri) {
let targetRoute;
@ -35,7 +34,8 @@ export function dispatchNavigateToUri(dispatch, nav, uri, isNavigatingBack) {
return;
}
let uriVars = {};
let uriVars = {},
uriVarsStr;
if (uri.indexOf('?') > -1) {
uriVarsStr = uri.substring(uri.indexOf('?') + 1);
uri = uri.substring(0, uri.indexOf('?'));
@ -49,10 +49,10 @@ export function dispatchNavigateToUri(dispatch, nav, uri, isNavigatingBack) {
dispatch(doSetPlayerVisible(true));
}
if (nav && nav.routes && nav.routes.length > 0 && 'Main' === nav.routes[0].routeName) {
if (nav && nav.routes && nav.routes.length > 0 && nav.routes[0].routeName === 'Main') {
const mainRoute = nav.routes[0];
const discoverRoute = mainRoute.routes[0];
if (discoverRoute.index > 0 && 'File' === discoverRoute.routes[discoverRoute.index].routeName) {
if (discoverRoute.index > 0 && discoverRoute.routes[discoverRoute.index].routeName === 'File') {
const fileRoute = discoverRoute.routes[discoverRoute.index];
// Currently on a file page, so we can ignore (if the URI is the same) or replace (different URIs)
if (uri !== fileRoute.params.uri) {
@ -119,7 +119,8 @@ export function navigateToUri(navigation, uri, additionalParams, isNavigatingBac
return;
}
let uriVars = {};
let uriVars = {},
uriVarsStr;
if (uri.indexOf('?') > -1) {
uriVarsStr = uri.substring(uri.indexOf('?') + 1);
uri = uri.substring(0, uri.indexOf('?'));
@ -128,7 +129,7 @@ export function navigateToUri(navigation, uri, additionalParams, isNavigatingBac
const { store } = window;
const params = Object.assign({ uri, uriVars }, additionalParams);
if ('File' === navigation.state.routeName) {
if (navigation.state.routeName === 'File') {
const stackAction = StackActions.replace({ routeName: 'File', newKey: uri, params });
navigation.dispatch(stackAction);
if (store && store.dispatch && !isNavigatingBack) {
@ -182,3 +183,15 @@ export function uriFromFileInfo(fileInfo) {
uriParams.claimId = claimId;
return buildURI(uriParams);
}
export function formatTagTitle(title) {
if (!title) {
return null;
}
return title.charAt(0).toUpperCase() + title.substring(1);
}
// i18n placeholder until we find a good react-native i18n module
export function __(str) {
return str;
}