LBRYCommunity/lbry-react-native

better featured search result item handling #37

Merged

akinwale merged 2 commits from featured-search-item into master

2019-09-05 16:57:27 +02:00

akinwale commented

2019-09-02 15:18:10 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-09-02 15:18:10 +02:00

kauffj (Migrated from github.com) reviewed 2019-09-04 00:05:39 +02:00

src/component/claimList/view.js

					
				@ -208,0 +209,4 @@

				    if (uris) {

				      // temporary workaround for missing short_urls

				      uris = uris.filter(uri => uri && uri.length > 0);

				    }

kauffj (Migrated from github.com) commented

2019-09-04 00:02:40 +02:00

if 0.40 fixes this, want to just make the switch?

if 0.40 fixes this, want to just make the switch?

src/component/fileListItem/view.js

kauffj (Migrated from github.com) commented

2019-09-04 00:03:47 +02:00

i18n

i18n

kauffj (Migrated from github.com) commented

2019-09-04 00:04:13 +02:00

Can this text be "Nothing here. Publish something!"

Can this text be "Nothing here. Publish something!"

src/component/fileListItem/view.js

					
				@ -167,6 +173,13 @@ class FileListItem extends React.PureComponent {

				                {isRewardContent && <Icon style={fileListStyle.rewardIcon} name="award" size={12} />}

kauffj (Migrated from github.com) commented

2019-09-04 00:03:39 +02:00

when would you have a uri but not a name for a file list item?

when would you have a uri but not a name for a file list item?

src/page/publish/view.js

kauffj (Migrated from github.com) commented

2019-09-04 00:05:19 +02:00

imo it's much better to perform this cleaning either in the reducer or the selector than to litter it in components

can you just make vanityUrl = vanityUrl.trim() before getting into the component at all?

imo it's much better to perform this cleaning either in the reducer or the selector than to litter it in components can you just make `vanityUrl = vanityUrl.trim()` before getting into the component at all?

akinwale (Migrated from github.com) reviewed 2019-09-05 16:52:30 +02:00

src/component/fileListItem/view.js

					
				@ -167,6 +173,13 @@ class FileListItem extends React.PureComponent {

				                {isRewardContent && <Icon style={fileListStyle.rewardIcon} name="award" size={12} />}

akinwale (Migrated from github.com) commented

2019-09-05 16:52:30 +02:00

This applies when there's no claim for a featured search item. The values for title and name are obtained from the claim.

This applies when there's no claim for a featured search item. The values for `title` and `name` are obtained from the claim.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#37

No description provided.