Publish UX #44

Merged

akinwale merged 3 commits from publish-ux into master

2019-09-20 11:29:37 +02:00

akinwale commented

2019-09-15 13:48:49 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-09-15 13:48:49 +02:00

kauffj (Migrated from github.com) reviewed 2019-09-18 23:39:43 +02:00

src/page/publish/view.js

kauffj (Migrated from github.com) commented

2019-09-18 23:39:38 +02:00

This code along with some of the code in componentWillReceiveProps makes me think there is a cleaner way of doing this, but this is a non-blocking objection and something we should discuss on upcoming 1-1 or standup.

This code along with some of the code in `componentWillReceiveProps` makes me think there is a cleaner way of doing this, but this is a non-blocking objection and something we should discuss on upcoming 1-1 or standup.

src/page/publish/view.js

kauffj (Migrated from github.com) commented

2019-09-18 23:37:51 +02:00

are you sure this does what you want it to do? won't the end state of value depend on the order of items in the array?

are you sure this does what you want it to do? won't the end state of `value` depend on the order of items in the array?

akinwale (Migrated from github.com) reviewed 2019-09-20 11:27:52 +02:00

src/page/publish/view.js

akinwale (Migrated from github.com) commented

2019-09-20 11:27:52 +02:00

Yes. I replace value with an empty string for each of the items, and only assign the url string when there's a url match found.

akinwale (Migrated from github.com) reviewed 2019-09-20 11:29:28 +02:00

src/page/publish/view.js

akinwale (Migrated from github.com) commented

2019-09-20 11:29:28 +02:00

The onComponentFocused method is pretty much a workaround for the bugs I was facing with the navigation component not calling componentDidMount every time the user opened a particular page. It's something I'd like to address properly in the future.

The `onComponentFocused` method is pretty much a workaround for the bugs I was facing with the navigation component not calling `componentDidMount` every time the user opened a particular page. It's something I'd like to address properly in the future.

kauffj (Migrated from github.com) reviewed 2019-09-20 17:22:38 +02:00

src/page/publish/view.js

kauffj (Migrated from github.com) commented

2019-09-20 17:22:38 +02:00

const license = LICENSES.CC_LICENSES.find(item => { return item.value === license }));
const licenseUrl = license ? license.url : null;

``` const license = LICENSES.CC_LICENSES.find(item => { return item.value === license })); const licenseUrl = license ? license.url : null; ```

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#44

No description provided.