LBRYCommunity/lbry-react-native
1
0
Fork 0
Code Issues Pull requests 12 Projects Releases Packages Wiki Activity

Uri bar suggestions #59

Closed
akinwale wants to merge 2 commits from uri-bar-suggestions into master
pull from: uri-bar-suggestions
merge into: LBRYCommunity:master
Conversation 1 Commits 2 Files changed 9 +110 -48
akinwale commented 2019-10-15 14:53:23 +02:00 (Migrated from github.com)
Copy link
No description provided.
neb-b (Migrated from github.com) reviewed 2019-10-15 14:53:23 +02:00
kauffj (Migrated from github.com) reviewed 2019-10-17 00:12:53 +02:00
src/component/uriBar/index.js
kauffj (Migrated from github.com) commented 2019-10-17 00:10:10 +02:00
Copy link

I'm not sure this setting adds value. Why would you want to turn this off?

I'm not sure this setting adds value. Why would you want to turn this off?
kauffj (Migrated from github.com) commented 2019-10-17 00:10:26 +02:00
Copy link

(We can always ship it and see if anyone does before removing it, since you already wrote it)

(We can always ship it and see if anyone does before removing it, since you already wrote it)
src/component/uriBar/view.js
kauffj (Migrated from github.com) commented 2019-10-17 00:12:03 +02:00
Copy link

booo 60

if we have to put a value here, please explain what it is and why, if only for future @akinwale's sake

booo 60 if we have to put a value here, please explain what it is and why, if only for future @akinwale's sake
src/page/settings/view.js
@ -89,0 +98,4 @@
<Switch
value={showUriBarSuggestions}
onValueChange={value => setClientSetting(SETTINGS.SHOW_URI_BAR_SUGGESTIONS, value)}
/>
kauffj (Migrated from github.com) commented 2019-10-17 00:12:17 +02:00
Copy link

👍 good change, missing i18n

:+1: good change, missing i18n
src/page/settings/view.js
kauffj (Migrated from github.com) commented 2019-10-17 00:12:23 +02:00
Copy link

missing i18n

missing i18n
src/page/settings/view.js
kauffj (Migrated from github.com) commented 2019-10-17 00:12:37 +02:00
Copy link

this whole file seems to missing i18n

this whole file seems to missing i18n
akinwale commented 2019-10-21 17:34:34 +02:00 (Migrated from github.com)
Copy link

https://github.com/lbryio/lbry-react-native/pull/57

https://github.com/lbryio/lbry-react-native/pull/57

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

No labels
area: devops
area: discovery
area: docs
area: livestream
consider soon
dependencies
documentation
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#59
No description provided.
Delete branch "uri-bar-suggestions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?