add share button to channel page #65

Merged

akinwale merged 1 commit from channel-share into master

2019-10-29 13:33:30 +01:00

akinwale commented

2019-10-25 16:25:56 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-10-25 16:25:56 +02:00

kauffj (Migrated from github.com) approved these changes 2019-10-28 19:52:48 +01:00

src/page/channel/view.js

kauffj (Migrated from github.com) commented

2019-10-28 19:52:08 +01:00

what SDK bug requires this to be done? can we patch the missing fields in lbry-redux rather than repeating code like this? if this code has to be here, can you tag it with a link to the SDK issue so it can eventually be removed?

kauffj (Migrated from github.com) commented

2019-10-28 19:52:20 +01:00

(this would have been a good one to mention on app/SDK meeting)

akinwale (Migrated from github.com) reviewed 2019-10-29 13:33:23 +01:00

src/page/channel/view.js

akinwale (Migrated from github.com) commented

2019-10-29 13:33:23 +01:00

There are cases where claim_list doesn't return the short url. Haven't checked if this has been fixed yet.

There are cases where `claim_list` doesn't return the `short url`. Haven't checked if this has been fixed yet.

No reviewers

neb-b

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#65

No description provided.