LBRYCommunity/lbry-react-native

avoid re-resolving a claim when navigation to a short / canonical URL #79

Merged

akinwale merged 1 commit from faster-short-urls into master

2019-11-12 15:35:29 +01:00

akinwale commented

2019-11-08 07:15:08 +01:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-11-08 07:15:08 +01:00

kauffj (Migrated from github.com) reviewed 2019-11-08 16:05:29 +01:00

src/utils/helper.js

kauffj (Migrated from github.com) commented

2019-11-08 16:05:22 +01:00

It seems like a hack fix to pass two versions of the URI. If we're consistent with the URI type we use, doesn't this problem go away?

It seems like a hack fix to pass two versions of the URI. If we're consistent with the URI type we use, doesn't this problem go away?

akinwale (Migrated from github.com) reviewed 2019-11-12 15:35:15 +01:00

src/utils/helper.js

akinwale (Migrated from github.com) commented

2019-11-12 15:35:14 +01:00

At the moment, the canonical url is the default url we use in lbry-redux, which could be different from the short url, as it tends to include the channel name (which the short url doesn't have), so we end up having to resolve again, either way.

At the moment, the canonical url is the default url we use in `lbry-redux`, which could be different from the short url, as it tends to include the channel name (which the short url doesn't have), so we end up having to resolve again, either way.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#79

No description provided.