i18n #80

2019-11-13T22:57:08+01:00

akinwale commented

2019-11-13 22:57:08 +01:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-11-13 22:57:08 +01:00

kauffj (Migrated from github.com) requested changes 2019-12-03 18:27:20 +01:00

kauffj (Migrated from github.com) left a comment

Only required change is to make sure users receive updated translations periodically. I did not do a thorough scan of the line-by-line translation changes.

src/i18n.js

kauffj (Migrated from github.com) commented

2019-12-03 18:26:17 +01:00

do you want this here?

src/page/settings/view.js

					
				@ -56,0 +127,4 @@

				    }

				    navigateBack(navigation, drawerStack, popDrawerStack);

				  };

kauffj (Migrated from github.com) commented

2019-12-03 18:24:00 +01:00

I believe this needs to happen on startup and/or at some other interval to ensure a user receives new translations after changing their language.

akinwale (Migrated from github.com) reviewed 2019-12-04 08:12:52 +01:00

src/i18n.js

akinwale (Migrated from github.com) commented

2019-12-04 08:12:52 +01:00

No, the commented code can be removed.

akinwale (Migrated from github.com) reviewed 2019-12-04 08:14:32 +01:00

src/page/settings/view.js

					
				@ -56,0 +127,4 @@

				    }

				    navigateBack(navigation, drawerStack, popDrawerStack);

				  };

akinwale (Migrated from github.com) commented

2019-12-04 08:14:32 +01:00

I can make this happen on startup. We probably don't need to do an interval since it's unlikely the translations are going to be changing that often.

Sign in to join this conversation.

No reviewers

neb-b

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#80