LBRYCommunity/lbry-react-native
1
0
Fork 0
Code Issues Pull requests 12 Projects Releases Packages Wiki Activity

i18n #80

Merged
akinwale merged 12 commits from i18n into master 2019-12-05 13:16:45 +01:00
Conversation 0 Commits 12 Files changed 74 +7 -5
3 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6be536da98 - Show all commits

4
package-lock.json generated
View file

@ -5649,8 +5649,8 @@
} }
}, },
"lbryinc": { "lbryinc": {
"version": "github:lbryio/lbryinc#69fcd910a61f191e6eae1bdb0baf0e55bae7cf5f", "version": "github:lbryio/lbryinc#9ffb883cc11e36d55a729c65b70c405a4a56d35e",
"from": "github:lbryio/lbryinc#69fcd910a61f191e6eae1bdb0baf0e55bae7cf5f", "from": "github:lbryio/lbryinc#9ffb883cc11e36d55a729c65b70c405a4a56d35e",
"requires": { "requires": {
"reselect": "^3.0.0" "reselect": "^3.0.0"
} }

2
package.json
View file

@ -13,7 +13,7 @@
"@expo/vector-icons": "^8.1.0", "@expo/vector-icons": "^8.1.0",
"gfycat-style-urls": "^1.0.3", "gfycat-style-urls": "^1.0.3",
"lbry-redux": "lbryio/lbry-redux#8ac92e3abfa0a9aacdb2fa4a144c3fadc4da6b11", "lbry-redux": "lbryio/lbry-redux#8ac92e3abfa0a9aacdb2fa4a144c3fadc4da6b11",
"lbryinc": "lbryio/lbryinc#69fcd910a61f191e6eae1bdb0baf0e55bae7cf5f", "lbryinc": "lbryio/lbryinc#9ffb883cc11e36d55a729c65b70c405a4a56d35e",
"lodash": ">=4.17.11", "lodash": ">=4.17.11",
"merge": ">=1.2.1", "merge": ">=1.2.1",
"moment": "^2.22.1", "moment": "^2.22.1",

6
src/i18n.js
View file

@ -38,16 +38,18 @@ function checkMessageAndSave(message, messagesFilePath) {
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
.then(() => { .then(() => {
// successful write // successful write
// send to transifex (should we do this even if the file doesn't get saved?) // send to transifex (should we do this even if the file doesn't get saved?)
doTransifexUpload( // TODO: load token from .env
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
/* doTransifexUpload(
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
contents, contents,
'lbry-mobile', 'lbry-mobile',
'*token*',
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
() => { () => {
// successful // successful
}, },
err => { err => {
// failed // failed
} }
); ); */
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
}) })
.catch(err => { .catch(err => {
if (err) { if (err) {

kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.
kauffj commented 2019-12-03 18:26:17 +01:00 (Migrated from github.com)
Review
Copy link

do you want this here?

do you want this here?
akinwale commented 2019-12-04 08:12:52 +01:00 (Migrated from github.com)
Review
Copy link

No, the commented code can be removed.

No, the commented code can be removed.