Wallet servers #250

Merged
jessopb merged 4 commits from walletServers into master 2019-12-13 19:04:02 +01:00
jessopb commented 2019-12-11 21:28:54 +01:00 (Migrated from github.com)
No description provided.
neb-b (Migrated from github.com) reviewed 2019-12-11 21:28:54 +01:00
neb-b (Migrated from github.com) requested changes 2019-12-11 22:55:13 +01:00
neb-b (Migrated from github.com) left a comment

Small changes

Small changes
neb-b (Migrated from github.com) commented 2019-12-11 22:52:42 +01:00

I don't think this file needs to exist. Just import from constants/daemon_settings

I don't think this file needs to exist. Just import from `constants/daemon_settings`
neb-b (Migrated from github.com) commented 2019-12-11 22:53:29 +01:00

comment not needed

comment not needed
@ -341,0 +344,4 @@
type: ACTIONS.WALLET_RESTART,
});
// this basically returns null when it's done. :(
// might be good to dispatch ACTIONS.WALLET_RESTARTED
neb-b (Migrated from github.com) commented 2019-12-11 22:54:24 +01:00

Can you create an issue against https://github.com/lbryio/lbry-sdk asking for better responses and include a comment for that here?

Can you create an issue against https://github.com/lbryio/lbry-sdk asking for better responses and include a comment for that here?
neb-b (Migrated from github.com) commented 2019-12-11 22:55:00 +01:00

Also

.then(() => dispatch(...

instead of

.then(dispatch(

Also `.then(() => dispatch(...` instead of `.then(dispatch(`
jessopb (Migrated from github.com) reviewed 2019-12-12 05:17:19 +01:00
jessopb (Migrated from github.com) commented 2019-12-12 05:17:18 +01:00

The idea was, any time daemonSetting is set, if its key is in SHARED_PREFS, we have the middleware save the preference before sending it along to the sharedPreference state. That allows us to pick and choose daemonsettings to keep as preferences.
f361208488/ui/redux/actions/settings.js (L61)

The idea was, any time daemonSetting is set, if its key is in SHARED_PREFS, we have the middleware save the preference before sending it along to the sharedPreference state. That allows us to pick and choose daemonsettings to keep as preferences. https://github.com/lbryio/lbry-desktop/blob/f3612084885beb7afce96c5aa2a5093042c6e706/ui/redux/actions/settings.js#L61
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#250
No description provided.