Wallet servers #250
No reviewers
Labels
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-redux#250
Loading…
Reference in a new issue
No description provided.
Delete branch "walletServers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Small changes
I don't think this file needs to exist. Just import from
constants/daemon_settings
comment not needed
@ -341,0 +344,4 @@
type: ACTIONS.WALLET_RESTART,
});
// this basically returns null when it's done. :(
// might be good to dispatch ACTIONS.WALLET_RESTARTED
Can you create an issue against https://github.com/lbryio/lbry-sdk asking for better responses and include a comment for that here?
Also
.then(() => dispatch(...
instead of
.then(dispatch(
The idea was, any time daemonSetting is set, if its key is in SHARED_PREFS, we have the middleware save the preference before sending it along to the sharedPreference state. That allows us to pick and choose daemonsettings to keep as preferences.
f361208488/ui/redux/actions/settings.js (L61)