LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Collections #383

Merged
jessopb merged 20 commits from collections into master 2021-06-08 17:51:49 +02:00
Conversation 0 Commits 20 Files changed 19 +3028 -67
jessopb commented 2021-02-15 20:35:43 +01:00 (Migrated from github.com)
Copy link
No description provided.
neb-b (Migrated from github.com) reviewed 2021-02-15 23:12:19 +01:00
dist/flow-typed/Lbry.js
@ -172,1 +172,4 @@
declare type CollectionCreateResponse = {
outputs: Array<Claim>,
page: number,
neb-b (Migrated from github.com) commented 2021-02-15 21:40:58 +01:00
Copy link

Array<Claim>

Array\<Claim>
flow-typed/Collections.js
neb-b (Migrated from github.com) commented 2021-02-15 22:35:25 +01:00
Copy link
{
  [string]: boolean,
}
``` { [string]: boolean, } ```
neb-b (Migrated from github.com) commented 2021-02-15 22:38:37 +01:00
Copy link

remove added and leftOff for now

remove added and leftOff for now
src/constants/action_types.js
neb-b (Migrated from github.com) commented 2021-02-15 21:43:38 +01:00
Copy link

maybe COLLECTION_CREATE/COLLECTION_PUBLISH?

maybe COLLECTION_CREATE/COLLECTION_PUBLISH?
src/redux/actions/claims.js
neb-b (Migrated from github.com) commented 2021-02-15 21:48:06 +01:00
Copy link

collection_resolve({ claim_id: collectionId, page_size: 3

`collection_resolve({ claim_id: collectionId, page_size: 3 `
src/redux/actions/claims.js
neb-b (Migrated from github.com) commented 2021-02-15 21:49:23 +01:00
Copy link

Some of these aren't needed

Some of these aren't needed
neb-b (Migrated from github.com) commented 2021-02-15 22:59:04 +01:00
Copy link

some of these aren't needed

some of these aren't needed
neb-b (Migrated from github.com) commented 2021-02-15 23:01:05 +01:00
Copy link

doFetchCollectionListMine

doFetchCollectionListMine
src/redux/actions/collections.js
neb-b (Migrated from github.com) commented 2021-02-15 22:09:42 +01:00
Copy link

stateAfterClaimSearch

`stateAfterClaimSearch`
neb-b (Migrated from github.com) commented 2021-02-15 22:15:47 +01:00
Copy link

promises.push((claim_id) =>

`promises.push((claim_id) => `
neb-b (Migrated from github.com) commented 2021-02-15 22:17:52 +01:00
Copy link
try {
} catch (e) { return {
    [claim_id]: null
    }
  }
``` try { } catch (e) { return { [claim_id]: null } } ```
neb-b (Migrated from github.com) commented 2021-02-15 22:19:12 +01:00
Copy link

[string]: ?Array<GenericClaim>

\[string]: ?Array\<GenericClaim>
neb-b (Migrated from github.com) commented 2021-02-15 22:20:41 +01:00
Copy link

remove repost comments

remove repost comments
neb-b (Migrated from github.com) commented 2021-02-15 22:30:17 +01:00
Copy link

return { claim_id, items: result.items }

return { claim_id, items: result.items }
neb-b (Migrated from github.com) commented 2021-02-15 22:31:48 +01:00
Copy link

If above is changed on line 48, entry will be entry.claim_id and entry.items

If above is changed on line 48, entry will be `entry.claim_id` and `entry.items`
neb-b (Migrated from github.com) commented 2021-02-15 22:45:54 +01:00
Copy link

const processedFlatCollectionItems = processClaims(flatResolve
const processedClaimsByUri = processClaims(claimsByUri

const processedFlatCollectionItems = processClaims(flatResolve const processedClaimsByUri = processClaims(claimsByUri
neb-b (Migrated from github.com) commented 2021-02-15 22:50:12 +01:00
Copy link

doUpdateUnpublishedCollection

doUpdateUnpublishedCollection
neb-b (Migrated from github.com) commented 2021-02-15 22:54:19 +01:00
Copy link

doCreateUnpublishedCollection

doCreateUnpublishedCollection
neb-b (Migrated from github.com) commented 2021-02-15 22:55:46 +01:00
Copy link

makeSelectUnpublishedCollectionById

makeSelectUnpublishedCollectionById
neb-b (Migrated from github.com) commented 2021-02-15 22:56:27 +01:00
Copy link

comment

comment
neb-b (Migrated from github.com) commented 2021-02-15 22:56:52 +01:00
Copy link

addedAt is dead for now

addedAt is dead for now
src/redux/actions/collections.js
@ -0,0 +31,4 @@
data: {
entry: {
id: uuid(), // start with a uuid, this becomes a claimId after publish
name: name,
neb-b (Migrated from github.com) commented 2021-02-15 22:53:39 +01:00
Copy link

timestamp: Math.floor(Date.now() / 1000)

timestamp: Math.floor(Date.now() / 1000)
src/redux/reducers/claims.js
@ -306,6 +327,53 @@ reducers[ACTIONS.FETCH_CHANNEL_LIST_FAILED] = (state: State, action: any): State
});
};
reducers[ACTIONS.FETCH_COLLECTION_LIST_STARTED] = (state: State): State => ({
neb-b (Migrated from github.com) commented 2021-02-15 21:52:19 +01:00
Copy link

return { ...state,

return { ...state,
neb-b (Migrated from github.com) commented 2021-02-15 22:02:26 +01:00
Copy link

const { claims }: { claims: Array<CollectionClaim> } = action.data;

`const { claims }: { claims: Array<CollectionClaim> } = action.data;`
src/redux/reducers/claims.js
neb-b (Migrated from github.com) commented 2021-02-15 22:04:05 +01:00
Copy link

add comment explaining that this will protect against overwriting collections on edit

add comment explaining that this will protect against overwriting collections on edit
src/redux/reducers/collections.js
neb-b (Migrated from github.com) commented 2021-02-15 23:01:59 +01:00
Copy link

make watchlater a constant

make watchlater a constant
neb-b (Migrated from github.com) commented 2021-02-15 23:03:06 +01:00
Copy link

move this to the action

move this to the action
neb-b (Migrated from github.com) commented 2021-02-15 23:05:58 +01:00
Copy link

COLLECTION_UNPUBLISHED_CREATE

COLLECTION_UNPUBLISHED_CREATE
neb-b (Migrated from github.com) commented 2021-02-15 23:07:20 +01:00
Copy link

resolvingCollectionById[id] = true

From comment above about keeping this the same type as isResolvingClaimsById

resolvingCollectionById[id] = true From comment above about keeping this the same type as isResolvingClaimsById
src/redux/selectors/claims.js
neb-b (Migrated from github.com) commented 2021-02-15 23:08:14 +01:00
Copy link

comment

comment
src/redux/selectors/collections.js
neb-b (Migrated from github.com) commented 2021-02-15 23:08:50 +01:00
Copy link

selectBuiltinCollections

selectBuiltinCollections
neb-b (Migrated from github.com) commented 2021-02-15 23:09:40 +01:00
Copy link

return state.isResolvingCollectionById[id]

return state.isResolvingCollectionById[id]
jessopb (Migrated from github.com) reviewed 2021-02-17 17:16:08 +01:00
src/redux/actions/collections.js
jessopb (Migrated from github.com) commented 2021-02-17 17:16:08 +01:00
Copy link

Array/< { claimId: string, items: ?Array } >

Array/< { claimId: string, items: ?Array<GenericClaim> } >
infinite-persistence (Migrated from github.com) reviewed 2021-06-04 14:28:44 +02:00
infinite-persistence (Migrated from github.com) left a comment
Copy link

First pass ok. Mostly indirectly tested using the Desktop PR.
Only minor (ignorable) cleanup here.

First pass ok. Mostly indirectly tested using the Desktop PR. Only minor (ignorable) cleanup here.
dist/flow-typed/Collections.js
infinite-persistence (Migrated from github.com) commented 2021-06-04 14:08:06 +02:00
Copy link

typo?

typo?
src/redux/actions/claims.js
@ -10,16 +10,22 @@ import {
selectClaimsByUri,
infinite-persistence (Migrated from github.com) commented 2021-06-04 14:12:15 +02:00
Copy link

There are a few unused variables in this file.

There are a few unused variables in this file.
src/redux/actions/collections.js
@ -0,0 +7,4 @@
import {
makeSelectCollectionForId,
// makeSelectPublishedCollectionForId, // for "save" or "copy" action
makeSelectMyPublishedCollectionForId,
infinite-persistence (Migrated from github.com) commented 2021-06-04 14:19:23 +02:00
Copy link

Unused

Unused
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#383
No description provided.
Delete branch "collections"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?