Transaction export: move file-creation to background. #404

Merged

infinite-persistence merged 1 commit from ip/export-transactions into master

2021-04-19 22:44:04 +02:00

infinite-persistence commented

2021-04-17 16:13:27 +02:00

(Migrated from github.com)

Move the file-creation code to the background so that it won't stall the GUI if the list is large.

In actuality, a 100k CSV only took 1 second on my slow VM to generate, so we could avoid this PR if we want. But I think we should still not do it in the GUI thread in case the columns get larger, or we expand doFetchTransactions's default to beyond 100k entries.

Move the file-creation code to the background so that it won't stall the GUI if the list is large. In actuality, a 100k CSV only took 1 second on my slow VM to generate, so we could avoid this PR if we want. But I think we should still not do it in the GUI thread in case the columns get larger, or we expand `doFetchTransactions`'s default to beyond 100k entries.

neb-b (Migrated from github.com) reviewed 2021-04-17 16:13:27 +02:00

kauffj commented

2021-04-19 21:08:14 +02:00

(Migrated from github.com)

@tzarebczan has concerns about performance of the export function. We may need to consider how to properly design and scale this feature. Will start a conversation with @andybeletsky.

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#404

No description provided.