store pendingById #418

2021-06-24T20:47:01+02:00

jessopb commented

2021-06-24 20:47:01 +02:00

(Migrated from github.com)

because we've been tracking pending using claim_list and it's hit or miss whether the confirmations=0 shows up on the first page or last page, persisting pending and checking them with txo_list will work better.

infinite-persistence (Migrated from github.com) reviewed 2021-06-25 11:44:37 +02:00

infinite-persistence (Migrated from github.com) left a comment

Not sure about the inline comments on merging claims too.
While testing, I hit a scenario where a claim is stuck in "confirming..." state, and I don't see any further txo_list requests. Clicking on the "Refresh" button didn't help. Haven't tried F5, but I think that would fix it.
- Can't recall my exact steps to reproduce, but it's something like this:
  - Create a post, and go to Uploads page to see the "confirming..." thing.
  - Quickly create another post.
  - I now see 2 posts both "confirming..." (although the first post actually already confirmed. I monitored this from another browser using the wallet page).
  - The first post shown as finished confirming within 30s later. The second post is stuck "confirming..." indefinitely.
Previous discussions gave me the impression that txo_list is slow. Looks ok during testing (300ms) -- I assume it's just to the simpler parameters.

- Not sure about the inline comments on merging claims too. - [ ] While testing, I hit a scenario where a claim is stuck in "confirming..." state, and I don't see any further `txo_list` requests. Clicking on the "Refresh" button didn't help. Haven't tried F5, but I think that would fix it. - Can't recall my exact steps to reproduce, but it's something like this: - Create a post, and go to Uploads page to see the "confirming..." thing. - Quickly create another post. - I now see 2 posts both "confirming..." (although the first post actually already confirmed. I monitored this from another browser using the wallet page). - The first post shown as finished confirming within 30s later. The second post is stuck "confirming..." indefinitely. - Previous discussions gave me the impression that `txo_list` is slow. Looks ok during testing (300ms) -- I assume it's just to the simpler parameters.

src/redux/actions/claims.js

					
				@ -13,3 +13,4 @@

				  selectPendingClaimsById,

				} from 'redux/selectors/claims';

				import { doFetchTxoPage } from 'redux/actions/wallet';

infinite-persistence (Migrated from github.com) commented

2021-06-25 11:35:43 +02:00

Put into existing import?

jessopb commented

2021-07-02 04:11:32 +02:00

(Migrated from github.com)

Fixed the above bugs.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#418