LBRYCommunity/lbry-sdk
1
0
Fork 1
Code Issues Pull requests Projects Releases 282 Packages Wiki Activity

bring back test for picking oldest on dupe claims

Browse source
This commit is contained in:
Victor Shyba 2019-03-22 19:44:17 -03:00 • committed by Lex Berezhny
parent 56db631626
commit 1ed086e90f
1 changed files with 37 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

66
tests/integration/test_claim_commands.py
View file

@ -1,4 +1,5 @@
import tempfile import tempfile
from binascii import unhexlify
from lbrynet.wallet.transaction import Transaction from lbrynet.wallet.transaction import Transaction
from lbrynet.error import InsufficientFundsError from lbrynet.error import InsufficientFundsError
@ -13,7 +14,7 @@ class ClaimCommands(CommandTestCase):
async def craft_claim(self, name, amount_dewies, claim_dict, address): async def craft_claim(self, name, amount_dewies, claim_dict, address):
# FIXME: this is here mostly because publish has defensive code for situations that happens accidentally # FIXME: this is here mostly because publish has defensive code for situations that happens accidentally
# However, it still happens... So, let's reproduce them. # However, it still happens... So, let's reproduce them.
claim = ClaimDict.load_dict(claim_dict) claim = Claim.load_bytes(claim_dict)
address = address or (await self.account.receiving.get_addresses(limit=1, only_usable=True))[0] address = address or (await self.account.receiving.get_addresses(limit=1, only_usable=True))[0]
tx = await Transaction.claim(name, claim, amount_dewies, address, [self.account], self.account) tx = await Transaction.claim(name, claim, amount_dewies, address, [self.account], self.account)
await self.broadcast(tx) await self.broadcast(tx)
@ -214,16 +215,16 @@ class ClaimCommands(CommandTestCase):
self.assertEqual(len(empty['claims']), 0) self.assertEqual(len(empty['claims']), 0)
async def test_abandoned_channel_with_signed_claims(self): async def test_abandoned_channel_with_signed_claims(self):
channel = await self.out(self.daemon.jsonrpc_channel_new('@abc', "1.0")) channel = await self.daemon.jsonrpc_channel_new('@abc', "1.0")
self.assertTrue(channel['success']) self.assertTrue(channel['success'])
await self.confirm_tx(channel['tx']['txid']) await self.confirm_tx(channel['tx'].id)
claim = await self.make_claim(amount='0.0001', name='on-channel-claim', channel_name='@abc') orphan_claim = await self.make_claim(amount='0.0001', name='on-channel-claim', channel_name='@abc')
self.assertTrue(claim['success']) self.assertTrue(orphan_claim['success'])
abandon = await self.out(self.daemon.jsonrpc_claim_abandon(txid=channel['tx']['txid'], nout=0, blocking=False)) abandon = await self.out(self.daemon.jsonrpc_claim_abandon(txid=channel['tx'].id, nout=0, blocking=False))
self.assertTrue(abandon['success']) self.assertTrue(abandon['success'])
channel = await self.out(self.daemon.jsonrpc_channel_new('@abc', "1.0")) channel = await self.daemon.jsonrpc_channel_new('@abc', "1.0")
self.assertTrue(channel['success']) self.assertTrue(channel['success'])
await self.confirm_tx(channel['tx']['txid']) await self.confirm_tx(channel['tx'].id)
# Original channel doesnt exists anymore, so the signature is invalid. For invalid signatures, resolution is # Original channel doesnt exists anymore, so the signature is invalid. For invalid signatures, resolution is
# only possible outside a channel # only possible outside a channel
@ -232,39 +233,46 @@ class ClaimCommands(CommandTestCase):
response = await self.resolve('lbry://on-channel-claim') response = await self.resolve('lbry://on-channel-claim')
self.assertIn('claim', response['lbry://on-channel-claim']) self.assertIn('claim', response['lbry://on-channel-claim'])
self.assertFalse(response['lbry://on-channel-claim']['claim']['signature_is_valid']) self.assertFalse(response['lbry://on-channel-claim']['claim']['signature_is_valid'])
direct_uri = 'lbry://on-channel-claim#' + claim['claim_id'] direct_uri = 'lbry://on-channel-claim#' + orphan_claim['claim_id']
response = await self.resolve(direct_uri) response = await self.resolve(direct_uri)
self.assertIn('claim', response[direct_uri]) self.assertIn('claim', response[direct_uri])
self.assertFalse(response[direct_uri]['claim']['signature_is_valid']) self.assertFalse(response[direct_uri]['claim']['signature_is_valid'])
await self.daemon.jsonrpc_claim_abandon(claim_id=orphan_claim['claim_id'])
uri = 'lbry://@abc/on-channel-claim' uri = 'lbry://@abc/on-channel-claim'
# now, claim something on this channel (it will update the invalid claim, but we save and forcefully restore) # now, claim something on this channel (it will update the invalid claim, but we save and forcefully restore)
original_claim = await self.make_claim(amount='0.00000001', name='on-channel-claim', channel_name='@abc') valid_claim = await self.make_claim(amount='0.00000001', name='on-channel-claim', channel_name='@abc')
self.assertTrue(original_claim['success']) self.assertTrue(valid_claim['success'])
# resolves normally # resolves normally
response = await self.resolve(uri) response = await self.resolve(uri)
self.assertIn('claim', response[uri]) self.assertIn('claim', response[uri])
self.assertTrue(response[uri]['claim']['signature_is_valid']) self.assertTrue(response[uri]['claim']['signature_is_valid'])
# FIXME BEING FIXED -- doesnt happen on current sigs but on migrated ones # ooops! claimed a valid conflict! (this happens on the wild, mostly by accident or race condition)
# tamper it, invalidating the signature dupe_claim = Transaction(unhexlify(valid_claim['tx']['hex'])).outputs[valid_claim['output']['nout']].claim
#value = response[uri]['claim']['value'].copy() dupe_claim.stream.hash = ''.join(reversed(dupe_claim.stream.hash))
#value['stream']['author'] = 'some troll' address = response[uri]['claim']['address']
#address = response[uri]['claim']['address'] tx = await Transaction.claim(
#await self.craft_claim('on-channel-claim', 1, value, address) 'on-channel-claim', dupe_claim, 1,
# it resolves to the now only valid claim under the channel, ignoring the fake one holding_address=address, funding_accounts=[self.account], change_account=self.account
#response = await self.resolve(uri) )
#self.assertIn('claim', response[uri]) tx.outputs[0].sign(channel['output'])
#self.assertTrue(response[uri]['claim']['signature_is_valid']) await tx.sign([self.account])
await self.broadcast(tx)
await self.ledger.wait(tx)
await self.generate(1)
await self.ledger.wait(tx)
#await self.make_claim()craft_claim('on-channel-claim', 1, )
## ooops! claimed a valid conflict! (this happens on the wild, mostly by accident or race condition) # it still resolves! but to the older claim
#await self.craft_claim('on-channel-claim', 1, response[uri]['claim']['value'], address) response = await self.resolve(uri)
self.assertIn('claim', response[uri])
## it still resolves! but to the older claim self.assertTrue(response[uri]['claim']['signature_is_valid'])
#response = await self.resolve(uri) self.assertEqual(response[uri]['claim']['txid'], valid_claim['tx']['txid'])
#self.assertIn('claim', response[uri]) claims = (await self.daemon.jsonrpc_claim_list('on-channel-claim'))['claims']
#self.assertTrue(response[uri]['claim']['signature_is_valid']) self.assertEqual(2, len(claims))
#self.assertEqual(response[uri]['claim']['txid'], original_claim['tx']['txid']) signer_ids = set([claim['value'].signing_channel_id for claim in claims])
self.assertEqual({channel['claim_id']}, signer_ids)
async def test_claim_list_by_channel(self): async def test_claim_list_by_channel(self):
self.maxDiff = None self.maxDiff = None