LBRYCommunity/lbry-sdk
1
0
Fork 1
Code Issues Pull requests Projects Releases 282 Packages Wiki Activity

check headers bounds on access

Browse source
This commit is contained in:
Victor Shyba 2019-08-16 03:07:46 -03:00
parent 92823dcea9
commit 4c41e7cb29
2 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
torba/tests/client_tests/unit/test_headers.py
View file

@ -94,6 +94,17 @@ class BasicHeadersTests(BitcoinHeadersTestCase):
await headers.connect(len(headers), remainder) await headers.connect(len(headers), remainder)
self.assertEqual(headers.height, 32259) self.assertEqual(headers.height, 32259)
async def test_bounds(self):
headers = MainHeaders(':memory:')
await headers.connect(0, self.get_bytes(block_bytes(3001)))
self.assertEqual(headers.height, 3000)
with self.assertRaises(IndexError):
_ = headers[3001]
with self.assertRaises(IndexError):
_ = headers[-1]
self.assertIsNotNone(headers[3000])
self.assertIsNotNone(headers[0])
async def test_repair(self): async def test_repair(self):
headers = MainHeaders(':memory:') headers = MainHeaders(':memory:')
await headers.connect(0, self.get_bytes(block_bytes(3001))) await headers.connect(0, self.get_bytes(block_bytes(3001)))

6
torba/torba/client/baseheader.py
View file

@ -70,8 +70,10 @@ class BaseHeaders:
return True return True
def __getitem__(self, height) -> dict: def __getitem__(self, height) -> dict:
assert not isinstance(height, slice), \ if isinstance(height, slice):
"Slicing of header chain has not been implemented yet." raise NotImplementedError("Slicing of header chain has not been implemented yet.")
if not 0 <= height <= self.height:
raise IndexError(f"{height} is out of bounds, current height: {self.height}")
return self.deserialize(height, self.get_raw_header(height)) return self.deserialize(height, self.get_raw_header(height))
def get_raw_header(self, height) -> bytes: def get_raw_header(self, height) -> bytes: