LBRYCommunity/lbry-sdk
1
0
Fork 1
Code Issues Pull requests Projects Releases 282 Packages Wiki Activity

Merge pull request #2286 from osilkin98/2279-fix

Browse source 
Fixes corner case on comment validation for pending channel
This commit is contained in:
Thomas Zarebczan 2019-07-03 14:14:47 -04:00 committed by GitHub
commit 4f208b6b31
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
lbry/lbry/extras/daemon/comment_client.py
View file

@ -19,19 +19,20 @@ def get_encoded_signature(signature):
def is_comment_signed_by_channel(comment: dict, channel: Output): def is_comment_signed_by_channel(comment: dict, channel: Output):
try: if type(channel) is Output:
pieces = [ try:
comment['signing_ts'].encode(), pieces = [
channel.claim_hash, comment['signing_ts'].encode(),
comment['comment'].encode() channel.claim_hash,
] comment['comment'].encode()
return Output.is_signature_valid( ]
get_encoded_signature(comment['signature']), return Output.is_signature_valid(
sha256(b''.join(pieces)), get_encoded_signature(comment['signature']),
channel.claim.channel.public_key_bytes sha256(b''.join(pieces)),
) channel.claim.channel.public_key_bytes
except KeyError: )
pass except KeyError:
pass
return False return False