LBRYCommunity/lbry-sdk
1
0
Fork 1
Code Issues Pull requests Projects Releases 282 Packages Wiki Activity

Extend close nodes list by right amount

Browse source 
When a k-bucket does not contain enough close nodes, the
DHT will look into neighbouring k-buckets in order to entend
the list of returned nodes.

However, the list should not be extended beyond its maximum size.

Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
This commit is contained in:
Antonio Quartulli 2017-10-25 09:02:50 +08:00 committed by Antonio Quartulli
parent c63d368e1c
commit 673d1c4d43
No known key found for this signature in database
GPG key ID: 07A53C580EF2CD74
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -20,6 +20,7 @@ at anytime.
* Fixed lbryid length validation * Fixed lbryid length validation
* Fixed an old print statement that polluted logs * Fixed an old print statement that polluted logs
* Fixed rpc id length for dht requests * Fixed rpc id length for dht requests
* Fixed amount of closed nodes to add to list in case of extension to neighbouring k-buckets
### Deprecated ### Deprecated
* *

7
lbrynet/dht/routingtable.py
View file

@ -138,15 +138,14 @@ class TreeRoutingTable(object):
# Fill up the node list to k nodes, starting with the closest neighbouring nodes known # Fill up the node list to k nodes, starting with the closest neighbouring nodes known
while len(closestNodes) < min(count, constants.k) and (canGoLower or canGoHigher): while len(closestNodes) < min(count, constants.k) and (canGoLower or canGoHigher):
# TODO: this may need to be optimized # TODO: this may need to be optimized
remain = min(count, constants.k) - len(closestNodes)
if canGoLower: if canGoLower:
closestNodes.extend( closestNodes.extend(
self._buckets[bucketIndex - i].getContacts( self._buckets[bucketIndex - i].getContacts(remain, _rpcNodeID))
constants.k - len(closestNodes), _rpcNodeID))
canGoLower = bucketIndex - (i + 1) >= 0 canGoLower = bucketIndex - (i + 1) >= 0
if canGoHigher: if canGoHigher:
closestNodes.extend( closestNodes.extend(
self._buckets[bucketIndex + i].getContacts(constants.k - len(closestNodes), self._buckets[bucketIndex + i].getContacts(remain, _rpcNodeID))
_rpcNodeID))
canGoHigher = bucketIndex + (i + 1) < len(self._buckets) canGoHigher = bucketIndex + (i + 1) < len(self._buckets)
i += 1 i += 1
return closestNodes return closestNodes