pylint

lbry/blockchain/transaction.py

@@ -372,7 +372,10 @@ class Output(InputOutput):
     def is_signature_valid(encoded_signature, signature_digest, public_key_bytes):
         try:
             public_key = load_der_public_key(public_key_bytes, default_backend())
-            public_key.verify(encoded_signature, signature_digest, ec.ECDSA(Prehashed(hashes.SHA256())))
+            public_key.verify(  # pylint: disable=no-value-for-parameter
+                encoded_signature, signature_digest,
+                ec.ECDSA(Prehashed(hashes.SHA256()))
+            )
             return True
         except (ValueError, InvalidSignature):
             pass

lbry/cli.py

@@ -41,7 +41,7 @@ class ArgumentParser(argparse.ArgumentParser):
         self._optionals.title = 'Options'
         if group_name is None:
             self.epilog = (
-                f"Run 'lbrynet COMMAND --help' for more information on a command or group."
+                "Run 'lbrynet COMMAND --help' for more information on a command or group."
             )
         else:
             self.epilog = (

lbry/conf.py

@@ -192,7 +192,7 @@ class MaxKeyFee(Setting[dict]):
         )
         parser.add_argument(
             self.no_cli_name,
-            help=f"Disable maximum key fee check.",
+            help="Disable maximum key fee check.",
             dest=self.name,
             const=None,
             action="store_const",

lbry/console.py

@@ -35,7 +35,7 @@ class Basic(Console):
         elif isinstance(self.service, LightClient):
             s.append('Light Client')
         if conf.processes == -1:
-            s.append(f'Threads Only')
+            s.append('Threads Only')
         elif conf.processes == 0:
             s.append(f'{os.cpu_count()} Process(es)')
         else:

lbry/dht/serialization/datagram.py

@@ -171,7 +171,7 @@ def decode_datagram(datagram: bytes) -> typing.Union[RequestDatagram, ResponseDa
 def make_compact_ip(address: str) -> bytearray:
     compact_ip = reduce(lambda buff, x: buff + bytearray([int(x)]), address.split('.'), bytearray())
     if len(compact_ip) != 4:
-        raise ValueError(f"invalid IPv4 length")
+        raise ValueError("invalid IPv4 length")
     return compact_ip
 
 
@@ -180,7 +180,7 @@ def make_compact_address(node_id: bytes, address: str, port: int) -> bytearray:
     if not 0 < port < 65536:
         raise ValueError(f'Invalid port: {port}')
     if len(node_id) != constants.HASH_BITS // 8:
-        raise ValueError(f"invalid node node_id length")
+        raise ValueError("invalid node node_id length")
     return compact_ip + port.to_bytes(2, 'big') + node_id
 
 
@@ -191,5 +191,5 @@ def decode_compact_address(compact_address: bytes) -> typing.Tuple[bytes, str, i
     if not 0 < port < 65536:
         raise ValueError(f'Invalid port: {port}')
     if len(node_id) != constants.HASH_BITS // 8:
-        raise ValueError(f"invalid node node_id length")
+        raise ValueError("invalid node node_id length")
     return node_id, address, port

lbry/error/generate.py

@@ -63,7 +63,7 @@ class ErrorClass:
     @staticmethod
     def get_fields(args):
         if len(args) > 1:
-            return f''.join(f'\n{INDENT*2}self.{field} = {field}' for field in args[1:])
+            return ''.join(f'\n{INDENT*2}self.{field} = {field}' for field in args[1:])
         return ''
 
     @staticmethod

lbry/file_analysis.py

@@ -69,8 +69,8 @@ class VideoFileAnalyzer:
             version = str(e)
         if code != 0 or not version.startswith("ffmpeg"):
             log.warning("Unable to run ffmpeg, but it was requested. Code: %d; Message: %s", code, version)
-            raise FileNotFoundError(f"Unable to locate or run ffmpeg or ffprobe. Please install FFmpeg "
+            raise FileNotFoundError("Unable to locate or run ffmpeg or ffprobe. Please install FFmpeg "
-                                    f"and ensure that it is callable via PATH or conf.ffmpeg_path")
+                                    "and ensure that it is callable via PATH or conf.ffmpeg_path")
         log.debug("Using %s at %s", version.splitlines()[0].split(" Copyright")[0], self._which_ffmpeg)
         return version
 

lbry/service/parser.py

@@ -285,7 +285,7 @@ def get_api_definitions(cls):
 def write(fp):
     fp.write('# pylint: skip-file\n')
     fp.write('# DO NOT EDIT: GENERATED FILE\n')
-    fp.write(f'interface = ')
+    fp.write('interface = ')
     defs = get_api_definitions(api.API)
     for c in defs['commands'].values():
         del c['method']

lbry/wallet/account.py

@@ -75,7 +75,7 @@ class AddressManager:
     async def ensure_address_gap(self):
         raise NotImplementedError
 
-    def get_address_records(self, only_usable: bool = False, **constraints):
+    async def get_address_records(self, only_usable: bool = False, **constraints):
         raise NotImplementedError
 
     async def get_addresses(self, only_usable: bool = False, **constraints) -> List[str]: